UI Error - (Compact Raid Frame)
Code:
Message: CreateFrame: Can't create protected 'Button' now It looks like its just the default Blizzard Raid frames erroring. I have tried deleting the Blizzard CompactRaidFrames.lua file and letting blizzard create a new one. Still same errors. |
Blizzard's CompactRaidFrames are probably the worst code they have ever included in the WoW UI. It's even worse than the UIDropDownMenu.
Technically the problem you're seeing is caused by addons -- because taint cannot occur if no addons are present -- but realistically, it's likely that none of your addons are actually doing anything wrong, and something somewhere just touched a variable that, 1500 indirect links in some nebulous chain of unrelated actions later, the CompactRaidFrames decided was tainted. If the errors don't noticably break anything, just ignore them. Install BugSack so they don't pop up and annoy you. If you can consistently reproduce the problem (eg. it happens every time you enter combat, or something like that) then you could try narrowing it down: 1. Enable half of your addons, disable the other half, and log in. 3. If the problem does not occur, log out, disable all enabled addons, and enable the other half. 4. If the problem does occur, log out, disable half of the enabled addons, and log in. 5. Repeat until you have narrowed it down to 1 addon that causes the problem. |
I know this is an old thread but for those searching this error:
http://us.battle.net/wow/en/forum/to...1970?page=1#15 To reproduce: Quote:
|
Oh, so that's the taint bug with InterfaceOptions_AddToCategory. Well, I guess I can stop telling myself I should get around to looking into why I get so many "omg an addon tainted the compact raid frames you're not even using!" errors in BugSack. :rolleyes:
|
Wish Blizzard didn't have optionphobia and added in an option to not load their raid frames.
|
I wonder if something like this would solve all the problems (for people not using the Blizzard raid frames)?
Code:
CompactRaidFrameContainer:UnregisterAllEvents() |
Quote:
Not sure why entering/leaving Interface Options causes the Raid Frames to load, but it's a good way to test code functionality. |
The only "solution" I found to deal with this abject stupidity was to code !BugGrabber to ignore blocked actions on CompactRaidFrame*
The upside of that is that when errors Fatality in BugSack, they're real problems; the downside is realizing how many addons have issues in 5.2, which are irregularly related to what appears to be timing issues with the server. I'm starting to expect the next expansion to be "Attack of the Interns" where our daily quest is to debug blizzard's code. |
Quote:
Code:
local function HideSafely(f) if not InCombatLockdown() then f:Hide() end Code:
local combatHider = CreateFrame("Frame") Quote:
|
Hmm, now that you mention that: somebody must have already coded a "hide and destroy/keep dead the raid frames" thing? I wonder how my unit frames do it...
Code:
--Disable the creation of blizz CompactRaidFrameX, theres an issue with taint due to dropdown with more 7 items |
Why you people hating on the blizzard raid frames so much their simply amazing. Never cause an issue or anything until you try to do something completely unrelated to the raid frames and then you spend the next 4 weeks debug perfectly fine code only to see what's really going on and then you go, "aww"
Quote:
|
Quote:
|
Quote:
218 addon Phanx? really? I only use..... 2 (yes there are more addon in my UI download than what I actually use, lmao) |
1 Attachment(s)
Quote:
Quote:
Quote:
(For anyone looking at this list and thinking "ooh, PhanxBorder sounds really neat", please don't PM me asking about any addons marked as PRIVATE. They're not published and I have no plans to publish them. PMing me isn't going to change my mind. Go write your own.) |
Quote:
Code:
1x Blizzard_CompactUnitFrameProfiles.lua:462: Usage: GetRaidProfileOption("profile", "optionName") So, as is the style of X-Perl, it appears to work, but isn't very refined. I've just been using it for so long now (Nymbia's Perl before X-) that I don't even want to bother with anything else. |
Hmm... what if you disabled the Raid Profiles panel in the Interface Options window so it couldn't be clicked?
Code:
local buttons = InterfaceOptionsFrameCategories.buttons |
Quote:
Do you want me to try that? |
The solution Leatrix posted is cleaner, but I've been running a mini-addon with your solution + that code I posted disabling the Raid Profiles panel from being clicked, and haven't seen any of the usual taint errors in BugSack.
Edit: Since Leatrix has deleted his entire forum posting history for some (annoying) reason, here is the code he had posted to resolve the issue discussed in this thread by removing the Cancel button from the Interface Options window: Code:
-- Remove the cancel button |
Quote:
|
Quote:
|
Quote:
|
Quote:
You could instead call the cancel handlers on other addons' configuration panels before you convert the cancel action into an okay one. Alternatively, replace the cancel handlers on just the Blizzard panels that are causing issues with null functions. |
Quote:
Code:
CompactUnitFrameProfiles.cancel = function() end |
Makes me wonder if a stand-alone mod, implementing both approaches on user choice, might be in order; though, with the pittance of threads I found on this problem, it may not be as impacting as I thought.
My hat's off to both of you, though. I disagree with Leatrix on the Cancel-button issue but I implemented it in my baseplate UI (sans-cancel->no-errors > blocking errors) and what a bloody difference. Not a single random "var comparator was nil" type error since I put it in, vs 3-5 per raid -- I had an odd moment of wondering if I'd broken Buggrabber since it didn't complain about anything for hours. Have to give Foxlit's approach a try -- feels a bit cleaner, and less chance of unintended effects -- but after having 4 headaches evaporate instantly, it might be worth a cancel button :) Edit: er, maybe I'll have to take that back. Instances and Scenarios both were chucking up issues this evening. Cancel was missing but the errors weren't. Odd. |
I'm with Leatrix on this one... the Cancel button does nothing for the majority of addons, and doesn't even do very much for the Blizzard panels it does apply to. Plus, it's really annoying to change a Blizzard option and then have it reverted because you hit Esc to close the window instead of clicking the Okay button. In the event you did accidentally click "Show action bar 4" and then change your mind, you can just click it again to go back to how it was. Users in WoW are used to options applying immediately when changed.
I added the button-removal code to my own UI and don't miss the button at all, or the tons of CRF-related taint errors in BugSack. |
I do have a "Reset" button in one of my addons, because users can't be expected to know the RGB values for the default class colors. Other than that, if they don't like the statusbar texture they picked, they can just pick a different one.
|
All times are GMT -6. The time now is 04:37 PM. |
vBulletin © 2024, Jelsoft Enterprises Ltd
© 2004 - 2022 MMOUI