WoWInterface

WoWInterface (https://www.wowinterface.com/forums/index.php)
-   General Authoring Discussion (https://www.wowinterface.com/forums/forumdisplay.php?f=20)
-   -   PTR 6.2 API changes? (https://www.wowinterface.com/forums/showthread.php?t=52328)

bsmorgan 05-21-15 07:05 AM

PTR 6.2 API changes?
 
In the past, I believe I've found an API changes thread on WoWInterface but I haven't found a 6.2 thread. Is there a better place to look?

humfras 05-21-15 12:32 PM

Apart from the new dungeon difficulties, there seems to be no API change so far.

http://wow.gamepedia.com/Patch_6.2.0/API_changes

bsmorgan 05-21-15 12:52 PM

Quote:

Originally Posted by humfras (Post 308915)
Apart from the new dungeon difficulties, there seems to be no API change so far.

http://wow.gamepedia.com/Patch_6.2.0/API_changes

Then perhaps all the Garrison addons (Master Plan, Garrison Mission Manager, Breeze, etc.) are using undocumented API features because none of them work on the PTR.

I did discover that you can hit space with the default Garrison Command Table interface to skip through all the animations. I don't know how long that's been possible as I've been one click completing all with Master Plan.

Gethe 05-21-15 01:30 PM

Quote:

Originally Posted by bsmorgan (Post 308917)
Then perhaps all the Garrison addons (Master Plan, Garrison Mission Manager, Breeze, etc.) are using undocumented API features because none of them work on the PTR.

I did discover that you can hit space with the default Garrison Command Table interface to skip through all the animations. I don't know how long that's been possible as I've been one click completing all with Master Plan.

Alot of the Garrison stuff is being redone in 6.2. The animation skip is also new in 6.2.

Fizzlemizz 05-21-15 01:42 PM

Quote:

Originally Posted by bsmorgan (Post 308917)
Then perhaps all the Garrison addons (Master Plan, Garrison Mission Manager, Breeze, etc.) are using undocumented API features because none of them work on the PTR.

I did discover that you can hit space with the default Garrison Command Table interface to skip through all the animations. I don't know how long that's been possible as I've been one click completing all with Master Plan.

These are changes to the Blizzard UI code, not the API itself.

sezz 05-21-15 05:03 PM

Quote:

Originally Posted by bsmorgan (Post 308917)
Then perhaps all the Garrison addons (Master Plan, Garrison Mission Manager, Breeze, etc.) are using undocumented API features because none of them work on the PTR.

Some C_Garrison functions now accept a follower type (LE_FOLLOWER_TYPE_SHIPYARD_6_2 or LE_FOLLOWER_TYPE_GARRISON_6_0), we got new shipyard mission table events (GARRISON_SHIPYARD_NPC_OPENED and GARRISON_SHIPYARD_NPC_CLOSED) and materialMultiplier returned by C_Garrison.GetPartyMissionInfo is now a table (currencyMultiplier[currencyID] = multiplier).

I'm not using any of the addons you mentioned, but they'll also have to update some hooks.

UnitAlternatePowerInfo was also changed:

local barType, minPower, startInset, endInset, smooth, hideFromOthers, showOnRaid, opaqueSpark, opaqueFlash, anchorTop, powerName, powerTooltip = UnitAlternatePowerInfo(unit);

Not sure if there's more, these are the changes I've encountered since 6.2 was on the PTR. (Oh and as of the latest build completing multiple missions is nearly instant, which is pretty awesome and propably the best 6.2 change if it stays like that when the patch goes live!)

Rythal 05-24-15 12:51 AM

Map Overlays seems to of changed.

The entire DBC file is gone now, and GetOverlayInfo returns nil if you haven't physically discovered it yet on the character.

semlar 05-24-15 05:10 AM

Quote:

Originally Posted by Rythal (Post 308939)
Get[Map]OverlayInfo returns nil if you haven't physically discovered it yet on the character.

How is that different from the current behavior?

Rythal 05-24-15 05:39 AM

It's not, I was actually just coming to edit that part... I've just never tried using it before when I hadn't explored and been a long while since I needed it over worldmapoverlay.dbc

I have found one API function however that's changed

6.2:
GetQuestObjectiveInfo(questID, index, displayComplete)

previously it was just (questID, index)

rowaasr13 06-21-15 06:38 PM

Garrison Mission Manager will support all the changes before 6.2 release (i.e. I'll upload full 6.2 and pre-6.2 compatible version later today) and will support ship mission assignments in one more or two days.

I finally had a chance to break from regular WoW since my subscription ran out and go to PTR to fix all the stuff. :)

SDPhantom 06-23-15 02:11 PM

Apparently, there's a new XML attribute called mixin. What this does is take in a list of global tables and copies their entries into the table of a UI widget.

gempir 06-23-15 02:18 PM

Quote:

Originally Posted by SDPhantom (Post 309304)
Apparently, there's a new XML attribute called mixin. What this does is take in a list of global tables and copies their entries into the table of a UI widget.

As a Sass developer this is raising my eyebrow.

Resike 06-23-15 02:59 PM

Quote:

Originally Posted by SDPhantom (Post 309304)
Apparently, there's a new XML attribute called mixin. What this does is take in a list of global tables and copies their entries into the table of a UI widget.

The dark xml rises again.

Gello 06-23-15 03:17 PM

The glorious XML!

This is an interesting tag. Thanks for pointing it out.

Resike 06-23-15 05:35 PM

The real question is it really worth to use xml besides the virtual tags? The time you gain with the faster executing is probably lost on the global calls.

SDPhantom 06-23-15 09:40 PM

I didn't say it was a good idea, but it might help people follow where some of the Blizzard methods are coming from. I've seen a bunch of it used in the Garrison UI.

rowaasr13 06-24-15 06:08 AM

GMM is updated some time ago to support 6.2 and is now uploaded to both Curse and WoWI.
Yeah, I noticed mixins while working on update too. They're convinient when you writing something, but make code somewhat harder to read for other people.

Gello 06-24-15 07:48 AM

Quote:

Originally Posted by Resike (Post 309334)
The real question is it really worth to use xml besides the virtual tags? The time you gain with the faster executing is probably lost on the global calls.

What time difference are you seeing on a local vs global call? In my tests the difference is negligible even across tens/hundreds of thousands of calls. The difference seems to diminish even more when you start dealing with API calls that dwarf the execution of our addon's calling code.

Locals are definitely more compelling because they don't clutter the namespace and they prevent tampering.

SDPhantom 06-24-15 01:07 PM

It's very miniscule, but they're referring to the difference between the indexing operation on the global table and grabbing some value from the local registers.

Resike 06-24-15 02:58 PM

Quote:

Originally Posted by Gello (Post 309347)
What time difference are you seeing on a local vs global call? In my tests the difference is negligible even across tens/hundreds of thousands of calls. The difference seems to diminish even more when you start dealing with API calls that dwarf the execution of our addon's calling code.

Locals are definitely more compelling because they don't clutter the namespace and they prevent tampering.

It can still matter, on no-fps lock animations or very spammy combat log events, you can easily get 200-300k calls under just a minute.


All times are GMT -6. The time now is 07:13 AM.

vBulletin © 2020, Jelsoft Enterprises Ltd
© 2004 - 2020 MMOUI