Clicking TradeSkillUI header items
When you shift-leftclick a header item in the TradeSkill window (without any addons enabled)
It will call C_TradeSkillUI.GetRecipeLink() and pass a nil value https://github.com/Gethe/wow-ui-sour....xml#L201-L211 Code:
Date: 2016-08-01 21:20:39 Would something like this work? Code:
<OnClick> |
I fixed it in BlizzBugsSuck by ignoring modifier keys on header rows, so if you shift-click a header, it acts like you clicked without the shift. Doing nothing when shift-clicking a header is a little confusing, because the button has visual feedback on mousedown/mouseup.
The Blizzard code is probably best fixed this way: Code:
<OnClick> |
Blizzard fixed this in patch 7.1, C_TradeSkillUI.GetRecipeLink() also won't throw an error when passed nil :)
https://www.townlong-yak.com/framexm...n.xml/diff#201 On another note:
When (shift-)clicking reagents/materials it would be nice to also jump to any tradeskill/recipe for that reagent |
I wonder why this was changed in Legion though, previously you could just shift-click anything into the search bar but now you need to have it focused first
https://www.townlong-yak.com/framexm....lua/diff#3816 Code:
@@ -3820,15 +3814,13 @@ function ChatEdit_InsertLink(text) This is what I'm using in FixTradeSkillSearch if anyone is interested Lua Code:
But the "jumping" to tradeskill part doesn't seem to work anymore in 7.1 when clicking reagents while shift is pressed, maybe have to hook something else now |
All times are GMT -6. The time now is 10:19 PM. |
vBulletin © 2024, Jelsoft Enterprises Ltd
© 2004 - 2022 MMOUI