WoWInterface

WoWInterface (https://www.wowinterface.com/forums/index.php)
-   nUI: Plugin Support (https://www.wowinterface.com/forums/forumdisplay.php?f=94)
-   -   InfoPanel_Stats pet issue (https://www.wowinterface.com/forums/showthread.php?t=40758)

Belechannas 07-06-11 03:33 AM

InfoPanel_Stats pet issue
 
It appears that the logic of InfoPanel_Stats plugin does not handle death of a pet correctly. When my pet dies in combat, the plugin gets stuck in Omen (combat) mode even after combat is over.

From debugging printout I added, it appears the plugin gets the events like this:

PET_ATTACK_START
PLAYER_REGEN_DISABLED
<plugin switches to Omen display>
<pet dies>
<combat ends>
PLAYER_REGEN_ENABLED
<plugin remains in Omen display>

The display continues to show Omen until you leave combat with a live pet, or reload the UI.

If the pet doesn't die, then PET_ATTACK_STOP is received at the same time as PLAYER_REGEN_ENABLED, and the display switches back to Recount.

I'm not very familiar with combat-related events; is there an easy way to handle this properly?

spiel2001 07-06-11 06:34 AM

It looks like there's a new taint. I'll have to figure out what it is an address it.

Belechannas 07-06-11 10:15 AM

You think this is due to taint? I could be wrong, of course, but it looked to me more like the code not anticipating an infrequently occurring corner case.

spiel2001 07-06-11 11:49 AM

PLAYER_REGEN_ENABLED should have triggered the change back regardless of pet status. So either a taint blocked it or I missed something. I'll look at it.


All times are GMT -6. The time now is 02:16 AM.

vBulletin © 2024, Jelsoft Enterprises Ltd
© 2004 - 2022 MMOUI