Thread: Twitter bug
View Single Post
03-20-15, 08:28 PM   #9
Torhal
A Pyroguard Emberseer
 
Torhal's Avatar
AddOn Author - Click to view addons
Join Date: Aug 2008
Posts: 1,196
I don't have the solution, because I didn't fully look at the code, but when you're iterating over things to set them up, terminating the iteration altogether instead of gracefully handling it will lead to a bad state. So, if "share" was found for "CHAT_MSG_PARTY" the others that came after would never have the filter applied, even if they should. That's not causing no harm at all, it is in fact making things worse. I'm not trying to pick a fight here; I was merely pointing out that there was a logic error in case you wanted to re-address.

I'll refrain from being helpful now.
__________________
Whenever someone says "pls" because it's shorter than "please", I say "no" because it's shorter than "yes".

Author of NPCScan and many other AddOns.
  Reply With Quote