View Single Post
02-18-23, 06:58 PM   #1
Nonamexxy
A Kobold Labourer
Join Date: Feb 2023
Posts: 1
Jax Classic Frames Taint Issue

hey,

I currently use the addon Jax Classic Frames which causes a lot of lua errors/actionbar taints lately.
The actionbar taints always occurs when switching between the talent loadouts.
LuaError:
Code:
AddOn 'ClassicFrames' tried to call the protected function 'UseAction()'.
[string "@!BugGrabber/BugGrabber.lua"]:480: in function <!BugGrabber/BugGrabber.lua:480>
[string "=[C]"]: in function `UseAction'
[string "@FrameXML/SecureTemplates.lua"]:364: in function `handler'
[string "@FrameXML/SecureTemplates.lua"]:690: in function <FrameXML/SecureTemplates.lua:672>
[string "@FrameXML/SecureTemplates.lua"]:704: in function <FrameXML/SecureTemplates.lua:697>
[string "@FrameXML/SecureTemplates.lua"]:746: in function `SecureActionButton_OnClick'
[string "@FrameXML/ActionButton.lua"]:89: in function `TryUseActionButton'
[string "@FrameXML/ActionButton.lua"]:124: in function `ActionButtonDown'
[string "ACTIONBUTTON2"]:2: in function <[string "ACTIONBUTTON2"]:1>
TaintLog:
Code:
Global variable ON_BAR_HIGHLIGHT_MARKS tainted by ClassicUI - Interface/FrameXML/ActionButton.lua:47 ClearOnBarHighlightMarks()
2/19 01:42:19.035      Interface/AddOns/Blizzard_ClassTalentUI/Blizzard_ClassTalentButtonTemplates.lua:30 Button:ShowActionBarHighlights()
2/19 01:42:19.035      Interface/AddOns/Blizzard_ClassTalentUI/Blizzard_ClassTalentButtonTemplates.lua:145 Button:OnEnter()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentButtonTemplates.lua:305 Button:UpdateMouseOverInfo()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentButtonTemplates.lua:170 UpdateVisualState()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentButtonTemplates.lua:495 Button:UpdateVisualState()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentButtonTemplates.lua:174 FullUpdate()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentButtonTemplates.lua:472 FullUpdate()
2/19 01:42:19.035      Interface/AddOns/Blizzard_ClassTalentUI/Blizzard_ClassTalentButtonTemplates.lua:125 Button:FullUpdate()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentFrame.lua:753 Frame:UpdateAllButtons()
2/19 01:42:19.035      Interface/AddOns/Blizzard_ClassTalentUI/Blizzard_ClassTalentTalentsTab.lua:319
2/19 01:42:19.035  Execution tainted by ClassicUI while reading ON_BAR_HIGHLIGHT_MARKS - Interface/FrameXML/ActionButton.lua:51 GetOnBarHighlightMark()
2/19 01:42:19.035      Interface/FrameXML/ActionButton.lua:466 ActionButton1:UpdateSpellHighlightMark()
2/19 01:42:19.035      Interface/FrameXML/ActionBarController.lua:167 ActionBarController_UpdateAllSpellHighlights()
2/19 01:42:19.035      Interface/AddOns/Blizzard_ClassTalentUI/Blizzard_ClassTalentButtonTemplates.lua:32 Button:ShowActionBarHighlights()
2/19 01:42:19.035      Interface/AddOns/Blizzard_ClassTalentUI/Blizzard_ClassTalentButtonTemplates.lua:145 Button:OnEnter()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentButtonTemplates.lua:305 Button:UpdateMouseOverInfo()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentButtonTemplates.lua:170 UpdateVisualState()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentButtonTemplates.lua:495 Button:UpdateVisualState()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentButtonTemplates.lua:174 FullUpdate()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentButtonTemplates.lua:472 FullUpdate()
2/19 01:42:19.035      Interface/AddOns/Blizzard_ClassTalentUI/Blizzard_ClassTalentButtonTemplates.lua:125 Button:FullUpdate()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentFrame.lua:753 Frame:UpdateAllButtons()
2/19 01:42:19.035      Interface/AddOns/Blizzard_ClassTalentUI/Blizzard_ClassTalentTalentsTab.lua:319
2/19 01:42:19.035  Execution tainted by ClassicUI while reading ON_BAR_HIGHLIGHT_MARKS - Interface/FrameXML/ActionButton.lua:51 GetOnBarHighlightMark()
2/19 01:42:19.035      Interface/FrameXML/ActionButton.lua:466 ActionButton2:UpdateSpellHighlightMark()
2/19 01:42:19.035      Interface/FrameXML/ActionBarController.lua:167 ActionBarController_UpdateAllSpellHighlights()
2/19 01:42:19.035      Interface/AddOns/Blizzard_ClassTalentUI/Blizzard_ClassTalentButtonTemplates.lua:32 Button:ShowActionBarHighlights()
2/19 01:42:19.035      Interface/AddOns/Blizzard_ClassTalentUI/Blizzard_ClassTalentButtonTemplates.lua:145 Button:OnEnter()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentButtonTemplates.lua:305 Button:UpdateMouseOverInfo()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentButtonTemplates.lua:170 UpdateVisualState()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentButtonTemplates.lua:495 Button:UpdateVisualState()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentButtonTemplates.lua:174 FullUpdate()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentButtonTemplates.lua:472 FullUpdate()
2/19 01:42:19.035      Interface/AddOns/Blizzard_ClassTalentUI/Blizzard_ClassTalentButtonTemplates.lua:125 Button:FullUpdate()
2/19 01:42:19.035      Interface/AddOns/Blizzard_SharedTalentUI/Blizzard_SharedTalentFrame.lua:753 Frame:UpdateAllButtons()
2/19 01:42:19.035      Interface/AddOns/Blizzard_ClassTalentUI/Blizzard_ClassTalentTalentsTab.lua:319
I did some testing and found the following function is causing the error respectively to be more precise the line: self.playCastFX = false;. Uncommenting/deleting this line fixes the error but the player castbar glow effect is not removed.
Code:
local function HookSetLook(self, look)
    self:SetStatusBarTexture("Interface\\TargetingFrame\\UI-StatusBar")
    if ( look == "CLASSIC" ) then
        self.playCastFX = false -- ERROR CAUSE
        self:SetSize(195, 13)
        self.Border:ClearAllPoints()
        self.Border:SetPoint("TOP", 0, 26)
        self.Border:SetTexture("Interface\\CastingBar\\UI-CastingBar-Border")
        self.Border:SetSize(256, 64)
        self.BorderShield:SetTexture("Interface\\CastingBar\\UI-CastingBar-Small-Shield")
        self.BorderShield:SetSize(256, 64)
        self.BorderShield:ClearAllPoints()
        self.BorderShield:SetPoint("TOP", 0, 28)
        self.Text:ClearAllPoints()
        self.Text:SetPoint("TOPLEFT", 0, 2)
        self.TextBorder:ClearAllPoints()
        self.TextBorder:SetPoint("TOPLEFT", 0, 0)
        self.TextBorder:SetPoint("BOTTOMRIGHT", 0, 0)

    elseif ( look == "UNITFRAME" ) then
        if (self == PlayerCastingBarFrame and PlayerCastingBarFrame.attachedToPlayerFrame) then
            HookOnEventTarget(PlayerCastingBarFrame)
        end
    end
end

hooksecurefunc(PlayerCastingBarFrame, "SetLook", HookSetLook)
PlayerCastingBarFrame.type = "player"
PlayerCastingBarFrame:HookScript("OnEvent", HookOnEventPlayer)
PermaHide2(PlayerCastingBarFrame.Background)
PermaHide2(PlayerCastingBarFrame.Flash)
Is their a safe way to disable the playCastFX/player castbar glow effect for PlayerCastingBarFrame without tainting my actionbars ?
Thank you in advance!
  Reply With Quote