Quantcast WoWInterface - View Single Post - BloodyScreen, Renovation for MoP
View Single Post
05-17-13, 12:41 PM   #8
ravagernl
Proceritate Corporis
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 1,176
Originally Posted by Phanx View Post
Okay, I couldn't help myself... I looked at the code. I think we have a strong contender for Worst Addon Code Ever Published. The original author apparently doesn't even know about "elseif" statements, and don't seem to realize that indices in Lua start at 1 instead of 0. Everything is a global, there are tons of "if X then if Y then Z end end" constructions that should be consolidated to "if X and Y then Z end", and basically it's just all bad.
I was thinking the same thing.

And even worse, those globals are prefixed with BS: BS_GeneralSettings_Trigger_Criticals_Swipes. CamelCase variables mixed with underscores? You'd think BS actually stands for bull**** :P. And if variables can be prefixed, then they can be collected in an array.

Originally Posted by Resike View Post
If i'm gonna have some time in the weekend i might be able to update it for 5.2.
Have "fun"!

Last edited by ravagernl : 05-17-13 at 12:45 PM.
  Reply With Quote