Normally it's a good idea to check the default implementation to see what events blizzard uses for setting up and updating. There are often some constants like WARLOCK_GREEN_FIRE, that you can use too and that are likely to remain usable if they change the spell id. It is also more descriptive when you read the code later. As for the green fire, yes, it is just a cosmetic change, not one regarding the power type or the way it works. It leads to a change though - you must keep SPELLS_CHANGED registered for the element for destro locks if you want to support it.
|