Quantcast
WoWInterface - View Single Post - Taint problem with SpellBookFrame
View Single Post
06-15-18, 02:29 AM   #6
lightspark
A Rage Talon Dragon Guard
 
lightspark's Avatar
AddOn Author - Click to view addons
Join Date: Sep 2012
Posts: 328
Originally Posted by Voxem View Post
That's the entire code right here. It's basically the same function as SpellBookFrame_OnMouseWheel, but applied to the pet spellbook.


Yeah that's the problem. I've also tried to hook both the script handler and the function, without success.
I don't really understand why it's tainting, seeing that I'm - correct me if I'm wrong - hooking securely. Am I missing something?
You use SpellBookPrevPageButton_OnClick, SpellBookNextPageButton_OnClick, which taint a lot of stuff because they're called from insecure environment.

Try commenting out both calls, and see if the taint persists You'll be surprised how easy it's to taint stuff >_>

For instance, here's my taint w/ your code

Code:
1x [ADDON_ACTION_BLOCKED] AddOn 'ls_UI' tried to call the protected function 'PetActionButton1:Show()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function `Show'
FrameXML\PetActionBarFrame.lua:198: in function `PetActionBar_Update'
FrameXML\SpellBookFrame.lua:499: in function `SpellButton_OnEnter'
[string "*:OnEnter"]:1: in function <[string "*:OnEnter"]:1>
__________________

Last edited by lightspark : 06-15-18 at 02:46 AM.
  Reply With Quote