[Grimsin]

hmmm, well im still confused then about one change or another. I get what appears to be the same value = nil error on a few different chunks of code. some of the chunks are as follows.

local function CreateBorders(frame, prefix)
    local border, start = { }, frame == CharacterFrame and 0 or 1
    for id = start, #slots do
        local frame = _G[prefix .. slots[id]]
        local region = GetNormalTexture(frame:GetRegions())
        local texture = frame:CreateTexture(nil, 'OVERLAY')
        texture:SetTexture([[Interface\Buttons\UI-ActionButton-Border]])
        texture:SetBlendMode('ADD')
        texture:SetAlpha(0.8)
        texture:SetPoint('TOPLEFT', region, -1, 3)
        texture:SetPoint('BOTTOMRIGHT', region, 1, 0)
        border[id] = texture
    end
    borders[frame] = border
end
 
local function OnHide(self)
    addon.UnregisterEvent(self, 'UNIT_INVENTORY_CHANGED')
end
 
local function OnShow(self)
    addon.RegisterEvent(self, 'UNIT_INVENTORY_CHANGED', UpdateItemQualityBorders)
    UpdateItemQualityBorders(self, nil, self.unit)
end
 
local function HookFrame(frame, prefix)
    CreateBorders(frame, prefix)
    frame:HookScript('OnHide', OnHide)
    frame:HookScript('OnShow', OnShow)
end
 
HookFrame(CharacterFrame, 'Character')
CharacterFrame.unit = 'player'
 
if InspectFrame then
    HookFrame(InspectFrame, 'Inspect')
else
    addon.RegisterEvent("Features-MonitorInspectUI", 'ADDON_LOADED', function(self, event, name)
        if name ~= 'Blizzard_InspectUI' then return end
        addon.UnregisterEvent(self, event)
 
        HookFrame(InspectFrame, 'Inspect')
        if InspectFrame:IsShown() then
            UpdateItemQualityBorders(InspectFrame, nil, InspectFrame.unit)
        end
    end)
end

or this chunk

hooksecurefunc('FriendsList_Update', function()
    local buttons, button = FriendsFrameFriendsScrollFrame.buttons
    local colors, CLASS = CUSTOM_CLASS_COLORS or RAID_CLASS_COLORS, addon.CLASS
    for index = 1, FriendsFrameFriendsScrollFrame.usedButtons do
        button = buttons[index]
        if button.buttonType == FRIENDS_BUTTON_TYPE_WOW then
            local _, _, class, _, connected = GetFriendInfo(button.id)
            if connected then
                local color = colors[CLASS[class]]
                button.name:SetTextColor(color.r, color.g, color.b)
            end
        end
    end
end)

and last but not least this chunk also

_G.SlashCmdList["GTIPNOTES_SHORTHAND"] = function(input)
    if not UnitExists("target") then
        DEFAULT_CHAT_FRAME:AddMessage(TARGET_ERROR)
        return
    end
    if type(input) ~= "string" or input:trim():len() == 0 then
        if not StaticPopupDialogs["GTipNotes"] then
            StaticPopupDialogs["GTipNotes"] = {
                text = nil,
                button1 = SET,
                button2 = CANCEL,
                whileDead = 1,
                hideOnEscape = 1,
                timeout = 0,
                OnShow = function()
                    -- We have to do this onshow to reset the previous text
                    local t = UnitExists("target") and UnitName("target") or ""
                    _G[this:GetName().."EditBox"]:SetText(_G.GTipNotesDB[t] or "")
                end,
                OnHide = function()
                    _G[this:GetName().."EditBox"]:SetText("")
                end,
                EditBoxOnEnterPressed = function()
                    addNoteFromPopup(_G[this:GetParent():GetName().."EditBox"]:GetText())
                    this:GetParent():Hide()
                end,
                EditBoxOnEscapePressed = function()
                    this:GetParent():Hide()
                end,
                OnAccept = function()
                    addNoteFromPopup(_G[this:GetParent():GetName().."EditBox"]:GetText())
                end,
                hasEditBox = 1,
            }
        end
        StaticPopupDialogs["GTipNotes"].text = POPUP_TEXT:format(UnitName("target"))
        StaticPopup_Show("GTipNotes")
    else
        local t = UnitName("target")
        _G.GTipNotesDB[t] = input
        DEFAULT_CHAT_FRAME:AddMessage(NOTE_SET:format(t, input))
    end
end

all works on live servers so it has to be the cata changes that caused this im just not sure which one or why.