Quantcast WoWInterface - View Single Post - Battle.Net Real ID Friends Watcher
View Single Post
09-24-15, 11:09 PM   #3
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
I'd suggest the following changes to your English strings:
  • You are now watching for: \"%s\" ==> You are now watching %s.
  • You've stopped watching for: \"%s\" ==> You are no longer watching %s.
  • %s (%s%s) has entered game world. ==> %s (%s%s) has logged into WoW.
  • %s has left game world. ==> %s has logged out of WoW.
Player, spell, and other names aren't typically quoted in English, though they are in some other languages. Entering and leaving the game world sound very technical (eg. addon authors talking about events like PLAYER_ENTERING_WORLD) and not like something ordinary users would say.

I'll add translations on CurseForge for Spanish and German later.

Edit: On a side note, you shouldn't leave lines in your TOC file like this:
Code:
## Title-deDE:
If you don't have a description for a language yet, just omit the line entirely; otherwise users in that language will see no description at all, instead of falling back to English.

Also, this:
Code:
## SavedVariables: Version, Current
SavedVariables are global, so they should follow all the usual rules about naming global variables --- they should be unique (to avoid conflicting with other intentional or accidental globals) and they should identify their owner (so if they show up in an error message the user has some hope of knowing which addon caused the error). Names like "AdvancedFriendsUI_Version" and "AdvancedFriendsUI_Current" would be much better.
__________________
Author/maintainer of Grid, PhanxChat, oUF_Phanx, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!

Last edited by Phanx : 09-24-15 at 11:12 PM.
  Reply With Quote