[zork]

I revised my code and found the final bug.

Reseting the camdistancescale vales etc is needed before reseting the model otherwise it will not reload properly if you change from a gnome to a dwarf etc.

I originally thought that clearing the model would wipe the model attributes but that is not the case. The attributes have to be set before the model rendering.

local Update = function(self, event, unit)
    if(not unit or not UnitIsUnit(self.unit, unit)) then return end
 
    local portrait = self.Portrait
    if(portrait.PreUpdate) then portrait:PreUpdate(unit) end
 
    if(portrait:IsObjectType'Model') then
        local guid = UnitGUID(unit)
        if(not UnitExists(unit) or not UnitIsConnected(unit) or not UnitIsVisible(unit)) then
            portrait:SetCamDistanceScale(0.25)
            portrait:SetPortraitZoom(0)
            portrait:SetPosition(0,0,0.5)
            portrait:ClearModel()
            portrait:SetModel('interface\\buttons\\talktomequestionmark.m2')
            portrait.guid = nil
        elseif(portrait.guid ~= guid or event == 'UNIT_MODEL_CHANGED') then
            portrait:SetCamDistanceScale(1)
            portrait:SetPortraitZoom(1)
            portrait:SetPosition(0,0,0)
            portrait:ClearModel()
            portrait:SetUnit(unit)
            portrait.guid = guid
        end
    else
        SetPortraitTexture(portrait, unit)
    end
 
    if(portrait.PostUpdate) then
        return portrait:PostUpdate(unit)
    end
end