View Single Post
05-11-09, 06:33 PM   #136
Seerah
Fishing Trainer
 
Seerah's Avatar
WoWInterface Super Mod
Featured
Join Date: Oct 2006
Posts: 10,860
Your third link has the code edit stuff. For example, if AlphaMap were installed, WM would find this bit of code
Code:
and ( Gatherer.Storage.HasDataOnZone(mapContinent, mapZone) ) ) then
and change this:
Code:
and ( setting(mainmap.enable) ) then
to this:
Code:
and ( setting(mainmap.enable) )
(taking out the then)

At least I think that's how it reads.



edit: Another example - BattlefieldCommander2:

change this:
Code:
if ( MouseIsOver(BFC_Map_Container, 45, -10, -5, 5) and not UIOptionsFrame:IsVisible()) then
to this:
Code:
if ( MouseIsOver(BFC_Map_Container, 45, -10, -5, 5)) then

But it's not their place to "fix" things in the addons. As has been stated, they have broken code when doing this. If the addon is abandoned and the license allows for someone else to pick it up, and the WM folks want to take care of it, then they should become a real maintainer of that addon. Do it "for realsies" and take care of the users. Working with the community, letting the users/community know that they are doing this and they are the new maintainer to go to with bugs, feature requests, etc.
__________________
"You'd be surprised how many people violate this simple principle every day of their lives and try to fit square pegs into round holes, ignoring the clear reality that Things Are As They Are." -Benjamin Hoff, The Tao of Pooh


Last edited by Seerah : 05-11-09 at 06:39 PM.
  Reply With Quote