View Single Post
08-24-15, 04:43 AM   #9
ircdirk
A Molten Giant
 
ircdirk's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2014
Posts: 823
Originally Posted by Nevcairiel View Post
At the very least, please ensure that the replacement SetMapByID actually matches the behaviour of the original - specifically, the original returns "true" when a map change was successfull, the Carbonite replacement never has any return value.
I was searching for it but nowhere is written that this funcition returns something, see here http://wowprogramming.com/docs/api/SetMapByID or here http://wowwiki.wikia.com/wiki/API_SetMapByID but ofcourse this can be outdated info...

Originally Posted by Nevcairiel View Post
Those are WoW functions, there is no source.
Many functions are available in FrameXML but i dont see SetMapByID there

As to SetMapByID which is replaced by Rythal: could we use hooksecurefunc here? And attach to SetMapByID rather then replacing it?
__________________
Carbonite and Carbonite Classic Developer

Last edited by ircdirk : 08-24-15 at 04:54 AM.
  Reply With Quote