Quantcast
WoWInterface - View Single Post - Carbonite Maps fails in Patch 7.3
View Single Post
08-30-17, 01:22 PM   #20
ircdirk
A Molten Giant
 
ircdirk's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2014
Posts: 814
Originally Posted by Vandalite View Post
Thanks for patching the endless error spam!

There is one other (easy enough to fix) issue that will cause carbonite to fail, even if you get the map issue straightened out:

PlaySound no longer accepts strings as arguments, and will need to be rewritten to either use the number or the SOUNDKIT static list to play them.

Carbonite has two instances of PlaySound, one on line 2120 of carbonite.lua, and another on line 729 of NxMapGuide.lua

The first one is easy enough: Change
Lua Code:
  1. PlaySound ("ReadyCheck")
to
Lua Code:
  1. PlaySound (SOUNDKIT.READY_CHECK)

The second one seems to need a bit more interpretation, since the sound it references isn't in the soundkit by the same name. My best guess is
Lua Code:
  1. PlaySound ("igPlayerInviteDecline")
should be changed to
Lua Code:
  1. PlaySound (SOUNDKIT.IG_QUEST_LOG_ABANDON_QUEST)

I had a bit of fun last night running through my mod list patching this all over the place...
U can propose changes on official Carbonite repo on Github: https://github.com/mikepauer/Carbonite. U can edit file this will make Pull Request and we can include that change in next alpha release.
  Reply With Quote