Change Value-Tag on Mouseover?

[Naisz]

So i was trying to change the Health-Value from percent to shortVal on Frame-Mouseover.
Sadly it doesn't work although i think the if returns a true.

if (MouseIsOver(health)) then
    if unit == "target" or unit == "targettarget" then
      local healthText = health:CreateFontString(nil, "OVERLAY", "GameFontNormal")
      healthText:SetPoint("RIGHT", health, "RIGHT")
      healthText:SetTextColor(1, 1, 1, 1)
      healthText:SetPoint("RIGHT", health, "RIGHT")
      healthText:SetFont(font, fontsize, "THINOUTLINE")
      self:Tag(healthText, "[shorthp]")
    end
  else
    if unit == "player" then
    local healthText = health:CreateFontString(nil, "OVERLAY", "GameFontNormal")
    healthText:SetPoint("RIGHT", health, "RIGHT")
    healthText:SetTextColor(1, 1, 1, 1)
    healthText:SetFont(font,fontsize, "THINOUTLINE")
    self:Tag(healthText, "[dead][shorthp]")
 
    elseif unit == "target" or unit == "targettarget" then
      local healthPer = health:CreateFontString(nil, "OVERLAY", "GameFontNormal")
      healthPer:SetPoint("RIGHT", health, 0, 0)
      healthPer:SetFont(font, fontsize, "THINOUTLINE")
      healthPer:SetTextColor(1, 1, 1, 1)
      self:Tag(healthPer, "[dead][perhp]%")
    end
  end

This is my code, Maybe someone can help

Thanks in advance!

[Phanx]

Well, your problem there is that you are checking to see if the health bar is being moused over just once, when the frame is first created, at which point nothing is being moused over yet.

I'd suggest just creating your own tag, like this:

oUF.Tags.Events["mouseoverhp"] = "UNIT_HEALTH UNIT_MAXHEALTH UPDATE_MOUSEOVER_UNIT"
oUF.Tags.Methods["mouseoverhp"] = function(unit)
    if UnitIsDead(unit) then
        return DEAD
    end
    local hp = UnitHealth(unit)
    if UnitIsUnit(unit, "mouseover") then
        return AbbreviateLargeNumbers(hp)
    else
        return format("%.0f%%", hp / UnitHealthMax(unit) * 100)
    end
end

Then just do this in your setup code:

    local healthText = health:CreateFontString(nil, "OVERLAY", "GameFontHighlight")
    healthText:SetPoint("RIGHT", health)
    healthText:SetFont(font, fontsize, "OUTLINE")
    if unit == "player" then
        self:Tag(healthText, "[dead][shorthp]")
    elseif unit == "target" or unit == "targettarget" then
        self:Tag(healthText, "[mouseoverhp]")
    end

Other changes I made in your setup code:

- Use GameFontHighlight instead of GameFontNormal. That way it's already white and you don't need the SetTextColor line. Other than the color it has exactly the same properties.

- Use "OUTLINE" instead of "THINOUTLINE", since that is the correct value. WoW will ignore the "THIN" part since it's meaningless, auto-correcting to "OUTLINE" for you, but you should just use the right value to begin with. Valid outline flags are "OUTLINE" and "THICKOUTLINE". The other possible flag is "MONOCHROME" which must be combined with an outline (by itself it will crash the client) and should generally only be used on pixel-style fonts, since it disables anti-aliasing and makes normal fonts look terrible.

- Don't duplicate code. Your healthText object was created with identical properties and position for any unit, so you should just create it once -- only apply the unit check to code that's actually different per unit.

[Naisz]

Thank you for your help!

One problem is there,
it works on targettarget, but i not on the target ..

Also thank you for the tips, my code looks better now, since i did something similar on the powertext.

[Phanx]

Originally Posted by Naisz it works on targettarget, but i not on the target ..

What exactly "doesn't work"? Is the fontstring created? Does it display any text?

[Naisz]

It displays the shortValue instead of perhp on the targetunit, but doesn't change on mouse-over
I also noticed that it triggers the change no matter which frame i target. But i think
thats because everything is created on on the style-func

Maybe i did something wrong, although i hope i'm doing stuff right

layout.lua