Quest tracker

[lynce]

Ok im looking for a way to automatically hide the tracker when joining a group/raid, and make it reappear upon leaving. Feel free to come with suggestions. Thanks

[Dridzt]

Who Framed Watcher Wabbit can - according to the feature list - "automatically collapse the tracker when entering an instance or during pet battles".

Maybe that's a suitable alternative?

[lynce]

Yes it has to be something like that. But I really don't want to use that addon, because I don't need that other stuff. Just as simple as possible. I looked through the code but didn't find anything. Suggestions?

[pelf]

Well, if that addon does what you want, you could just see how it does it and duplicate that portion into a small addon, no?

[lynce]

instance = {
			name = "Collapse in instance",
			desc = "Automatically collapses the watch frame when entering an instance.",
			type = "toggle",
			get = function() return db.instance end,
			set = function()
						db.instance = not db.instance
						if db.instance then
							WFContainer:RegisterEvent("PLAYER_ENTERING_WORLD")
						else
							WFContainer:UnregisterEvent("PLAYER_ENTERING_WORLD")
						end
					end,
			order = 15.2,

This was the only thing i could find in the addon that seems to have something to do with it. But i don't know how i can use this to make it work. And as it says, it only collapses the frame. I want it hidden completely. I would very much appreciate some help

[pelf]

This is the code block you're looking for:

function(_,event,...)
	if event == "PLAYER_ENTERING_WORLD" then
		if IsInInstance() and not WFWWPCDB.collapsed then
			--if you go in the instance and the WF isn't collapsed...
			WatchFrameCollapseExpandButton:Click()	--collapse
		end
	elseif event == "PET_BATTLE_OPENING_START" and not WFWWPCDB.collapsed then
		notCollapsed = true
		WatchFrameCollapseExpandButton:Click()
	elseif event == "PET_BATTLE_CLOSE" and notCollapsed then
		notCollapsed = false
		WatchFrameCollapseExpandButton:Click()
	elseif event == "CVAR_UPDATE" then
		local cvar,value = ...
		if cvar == "WATCH_FRAME_WIDTH_TEXT" then
			if not WatchFrame.userCollapsed then
				if value == "1" then
					WFContainer:SetWidth(350)
				else
					WFContainer:SetWidth(250)
				end
			end
			wideFrame = value
		end
	else
		local index = ...
		if event == "QUEST_AUTOCOMPLETE" or index == 0 then
			if WFWWPCDB.collapsed then
				WFContainer:SetHeight(db.height)
				if wideFrame == "1" then
					WFContainer:SetWidth(350)
				else
					WFContainer:SetWidth(250)
				end
				WFWWPCDB.collapsed = false
			end
		end
	end
end

Those are the events it responds to and what it does when they fire.

For the hiding the tracker while in an instance thing, it's two parts:

1. A flag indicating whether the watch frame is expanded.
2. Checking that and toggling the watch frame if IsInInstance().

In order to keep the frame in sync with the flag, the Expand function on the watch frame is hooked:

hooksecurefunc(
	"WatchFrame_Expand",
	function(self)
		if WFWWPCDB.collapsed and GetNumAutoQuestPopUps() == 0 then
			WatchFrame_Collapse(self)
		end
	end
)

The default OnClick script is replaced with one that wraps the existing function and toggles the flag when the frame is toggled.

[Seerah]

Originally Posted by nazrhyn Well, if that addon does what you want, you could just see how it does it and duplicate that portion into a small addon, no?

Except WFWW is All Rights Reserved. If someone wants to use my code, they need to ask, and I prefer that they use it for inspiration or a learning tool rather than just ripping it out.

[pelf]

I imagine there aren't too many ways to implement the collapse-watch-frame-when-zoning-into-instance thing. Anyone else writing that is probably going to end up with code pretty similar to what's in there.

I suppose, past the event handling, someone could've gone down the path of examining the watch frame to determine if it's collapsed or expanded rather than doing what you did to maintain a flag.

Ultimately, I guess I'm curious as to what amount of your implementation is enough to be violating the terms under which you released it. If someone: (1) handled PLAYER_ENTERING_WORLD and checked IsInInstance(), (2) hooked the Expand function on the WatchFrame, and (3) overrode OnClick for the button frame ... in another addon, would that be violating your terms?

[Seerah]

Originally Posted by Seerah use it for inspiration or a learning tool rather than just ripping it out.

This is what I said, and this doesn't refute what you just said.

[pelf]

Originally Posted by Seerah This is what I said, and this doesn't refute what you just said.

Well, forgive me, but, that doesn't answer my question.

[lynce]

Please, take that discussion in another thread. I made this post because I have limited lua experience, and I don't even know where to start to make this work. If I have to copy someone else's code, I will ask for permission.

[Phanx]

Originally Posted by nazrhyn Ultimately, I guess I'm curious as to what amount of your implementation is enough to be violating the terms under which you released it. If someone: (1) handled PLAYER_ENTERING_WORLD and checked IsInInstance(), (2) hooked the Expand function on the WatchFrame, and (3) overrode OnClick for the button frame ... in another addon, would that be violating your terms?

The answer to that is pretty obvious to anyone with any understanding of copyright law. Copyright protects only the implementation, not the idea or process.

For example, there are only so many ways you can make a chocolate chip cookie. Copyright protects the actual text you write in your version of the recipe (eg. "Crack the eggs into the bowl and whisk them until combined.") but anyone else is free to write their own recipe for chocolate chip cookies. Even though the ingredients and process are basically the same, as long as they write their own text, there is no copyright issue.

Similarly, copyright protects the actual text of Harry Potter and Twilight, but anyone is free to write stories about boys going to wizard school and sparkly vampires stalking high school girls.

Anyway, here is a simple way to unconditionally hide the quest tracker while you are in a group:

local f = CreateFrame("Frame")
f:RegisterEvent("GROUP_ROSTER_UPDATE")
f:SetScript("OnEvent", function()
    if IsInGroup() then
        WatchFrame:Hide()
        WatchFrame.Show = WatchFrame.Hide
    else
        WatchFrame.Show = nil
        WatchFrame:Show()
    end
end)

If you need help turning the above code into an addon, copy and paste it into this page:
http://addon.ziuo.net/

[pelf]

Originally Posted by Phanx The answer to that is pretty obvious to anyone with any understanding of copyright law. Copyright protects only the implementation, not the idea or process.

Then, what I'm not seeing is why it was necessary to even mention the terms under which the source was published. I assume it had something to do with my use of the word "duplicate"; but, from my perspective, I was just telling someone to check out how addon X does Y so they could figure out how to implement it.

[Phanx]

I wasn't part of the original discussion, but if you go back and read the posts, it does sound like the suggestion was basically "just copy and paste that part into a new addon", so I don't see any issue with Seerah -- the code's author -- pointing out that you can't do that.

[lynce]

Thanks again Phanx. It seems to do the trick=)

[Seerah]

Thanks for the explanations, Phanx. That is, indeed, how I took it and what I meant.

Glad you got what you needed, lynce!