More oUF troubles!

Wimpface · 10-06-13, 08:57 PM

I've been working on my raid frame layout recently, and I got it working fine until I wanted to make it do different things depending on size. Some quick google-fu led me to this thread, which while outdated still seemed fairly informative and solid.

So I tried to look at oUF_Diablo's current code, and the same method is still used. I tried to copy it over almost completely, with slight changes to values etc so it'd fit my layout. This is probably where it broke.

While I don't fully understand everything that goes on in zork's code, I do think I managed to port it over fairly well, but somewhere along the way it must've took a dark turn because they now spawn twice! I have two raidframes spawning, in both places I'd like, only they spawn no matter what. They spawn under my player frame even if I do 25man, and they spawn in the top left corner even if I'm in a 10man group. Nothing seems to change this.

This is the code I've shamelessly stolen and butchered.

lua Code:

oUF:RegisterStyle('opRaidDPS', Shared)
oUF:SetActiveStyle('opRaidDPS')
 
local playerClass = select(3, UnitClass('player'))
local raid, group, i, j
-- Single Frames    
 
local attr = {
    visibility1 = "custom [@raid11,exists] hide;[group:raid] show; hide",       --use "party,raid" to show this in party aswell
    visibility2 = "custom [@raid26,exists] hide; [@raid11,exists] show; hide",  --special display for raid > 20 players (lower scale)
    visibility3 = "custom [@raid26,exists] show; hide",                         --special display for raid > 30 players (lower scale)
}
 
local function getRaidVisibility(id)
    if id == 1 then
        return attr.visibility1
    elseif id == 2 then
        return attr.visibility2
    else
        return attr.visibility3
    end
end   
 
for i=1, 3 do
    raid = {}
    for j=1, NUM_RAID_GROUPS do
        local name = "oUF_OpieRaid"..i.."Group"..j
        group = oUF:SpawnHeader(
            name, 
            nil, 
            getRaidVisibility(i),
            'showPlayer', true,
            'showSolo', true,
            'showParty', false,
            'showRaid', true,
            'yOffset', -4,
            'maxColumns', 8,
            'unitsPerColumn', 5,
            "groupFilter", tostring(j),
            'groupBy', 'GROUP',
            'groupingOrder', "1,2,3,4,5,6,7,8",
            'columnSpacing', 3,
            'columnAnchorPoint', 'LEFT',
                'oUF-initialConfigFunction', ([[
                        self:SetHeight(24)
                        self:SetWidth(78)
                ]])
        )           
        if j == 1 then
            group:SetPoint('TOP', oUF_opUnitFramesPlayer, 'BOTTOM', 0, -10)
        else
            if playerClass == 9 or playerClass == 3 or playerClass == 6 then
                group:SetPoint('TOPLEFT', UIParent, 'TOPLEFT', 5, -28)
            else
                group:SetPoint('TOPLEFT', UIParent, 'TOPLEFT', 5, -5)
            end
        end
        raid[j] = group
    end
end

Here's my full layout: http://pastebin.com/NHTi6ePR
Here's Zork's layout: https://code.google.com/p/rothui/sou...s/raid.lua#365

Thanks in advance!

EDIT: I'd like to also point out that I tried to use this page for documentation on the header API, but I can't find any good documentation on the visibility stuff. If anyone's got a better page for it, I'd welcome it with open arms.

zork · 10-07-13, 01:17 AM

Why do you need 3 visibility handlers if you do not change the scale or size of each raidgroup per visibility handler? That's what I do and what I need 3 raid group spawns for.

You can have differnt type of raid frames spawning if the conditions match.

A) group:raid
B) raid11 noexists
C) raid26 exists
This will spawn raidframe 1 and 3.

If you can live with a single raid spawn the only visibility handler you need is this:

Lua Code:

--[group:raid] show; hide
 
  local raid = {}
  for j=1, NUM_RAID_GROUPS do
      local name = "oUF_OpieRaidHeader"..j
      group = oUF:SpawnHeader(
          name,
          nil,
          '[group:raid] show; hide',
          'showPlayer', true,
          'showSolo', true,
          'showParty', false,
          'showRaid', true,
          'yOffset', -4,
          'maxColumns', 8,
          'unitsPerColumn', 5,
          "groupFilter", tostring(j),
          'groupBy', 'GROUP',
          'groupingOrder', "1,2,3,4,5,6,7,8",
          'columnSpacing', 3,
          'columnAnchorPoint', 'LEFT',
              'oUF-initialConfigFunction', ([[
                      self:SetHeight(24)
                      self:SetWidth(78)
              ]])
      )          
      if j == 1 then
          group:SetPoint('TOP', oUF_opUnitFramesPlayer, 'BOTTOM', 0, -10)
      else
          if playerClass == 9 or playerClass == 3 or playerClass == 6 then
              group:SetPoint('TOPLEFT', UIParent, 'TOPLEFT', 5, -28)
          else
              group:SetPoint('TOPLEFT', UIParent, 'TOPLEFT', 5, -5)
          end
      end
      raid[j] = group
  end

Wimpface · 10-07-13, 09:50 AM

I was hoping to use different visibility states to change group direction and size of the frames if the raid was bigger than 2 groups. I'd like it to spawn under my player frame with the attributes I have set now, and if there's more than 10 people in the raid I want it to spawn in the top left instead and move downwards, much like oUF_Perfect in terms of looks. I also want to change the height of the frames from 24 to 20.

I tried using an event call with PARTY_MEMBERS_CHANGED, but the raidframes didn't spawn at all then.

Also, I don't think I quite fully understand what this line does in the header attribute table:

lua Code:

"groupFilter", tostring(j),

It was something I threw in there after my frames had already spawned twice, and it seemed to do nothing for me.

I'll try to grab a screenshot later of my problem if you'd like, if it still persists after making the changes you suggested.

Thanks!

EDIT:

You can have differnt type of raid frames spawning if the conditions match.

A) group:raid
B) raid11 noexists
C) raid26 exists
This will spawn raidframe 1 and 3.

If I wish to make changes to size of the frames, will I need to spawn different headers with these visibility conditions or should I go back to using a table like you did? I don't wish to change the scale, but rather the Height and Width independently (make the frames wider, but narrower)

EDIT2: With the changes you suggested, the raid frames don't spawn at all anymore. Odd.

Phanx · 10-07-13, 10:21 PM

Originally Posted by Wimpface

I was hoping to use different visibility states to change group direction and size of the frames if the raid was bigger than 2 groups. I'd like it to spawn under my player frame with the attributes I have set now, and if there's more than 10 people in the raid I want it to spawn in the top left instead and move downwards, much like oUF_Perfect in terms of looks. I also want to change the height of the frames from 24 to 20.

You can just use :SetAttribute(attr, val) on your already-existing header and unitframes when the group size changes; there's no need to create duplicate headers and frames. This applies to Zork, too.

Wimpface · 10-08-13, 01:02 AM

Originally Posted by Phanx

You can just use :SetAttribute(attr, val) on your already-existing header and unitframes when the group size changes; there's no need to create duplicate headers and frames. This applies to Zork, too.

So I could potentially do a check for PARTY_MEMBERS_CHANGED and when that fires, I can check for GetNumGroupMembers() and just SetAttributes then? Can I spawn a header without size settings only to modify them later?

What I mean would be something like this:

lua Code:

for j=1, NUM_RAID_GROUPS do
    raid = {}
    local name = "oUF_OpieRaidGroup"..j
    group = oUF:SpawnHeader(
        name, 
        nil, 
        '[group:raid] show; hide',
        'showPlayer', true,
        'showSolo', true,
        'showParty', false,
        'showRaid', true,
        'yOffset', -4,
        'maxColumns', 8,
        'unitsPerColumn', 5,
        "groupFilter", tostring(j),
        'groupBy', 'GROUP',
        'groupingOrder', "1,2,3,4,5,6,7,8",
        'columnSpacing', 3,
        'columnAnchorPoint', 'LEFT',
            'oUF-initialConfigFunction', ([[
                    self:SetHeight(24)
                    self:SetWidth(78)
            ]])
    )   
    raid[j] = group
end
 
local raidResize = function(self, event, ...)
    if not event or event ~= 'PARTY_MEMBERS_CHANGED' then return end
    
    local raidSize = GetNumGroupMembers() or 0
    
    if raidSize <= 10 then
        group:SetPoint('TOP', oUF_opUnitFramesPlayer, 'BOTTOM', 0, -10)
        group:SetAttribute('initial-width', 78)
        group:SetAttribute('initial-height', 24)
    elseif raidSize > 10 then
        if playerClass == 9 or playerClass == 3 or playerClass == 6 then
            group:SetPoint('TOPLEFT', UIParent, 'TOPLEFT', 5, -28)
        else
            group:SetPoint('TOPLEFT', UIParent, 'TOPLEFT', 5, -5)
        end
        group:SetAttribute('initial-width', 100)
        group:SetAttribute('initial-height', 20)
    end
end
 
local raidResizeFrame = CreateFrame('Frame')
raidResizeFrame:RegisterEvent('PARTY_MEMBERS_CHANGED')
raidResizeFrame:SetScript('OnEvent', raidResize)

Please note that I drycoded this (with some stuff from zorks code linked in the first post) and I'm not as talented at this as I should be after knocking my head against a wall for a few years.

EDIT: Tried it out, doesn't spawn frames at all!

zork · 10-08-13, 01:44 AM

Thanks Phanxs that is actually pretty interesting. Is changing of attributes allowed mid-combat?
Can you provide an example on how do change width of header children (group buttons) and scale of the header itself that works mid-combat?

That would be awesome indeed.

I'm not sure if you are able to just call header:SetAttribute(key,value)

Are you talking about sth like this?

Lua Code:

local stateFrame = CreateFrame("Frame", nil, nil, "SecureHandlerStateTemplate")
RegisterStateDriver(stateFrame , "raidsize", "[@raid26,exists] r26; [@raid11,exists] r11; [group:raid] r1")
stateFrame:SetAttribute("_onstate-raidsize", [[ -- arguments: self, stateid, newstate
    local ref = self:GetFrameRef("raidHeader")
    if newstate == "r26" then
      --raid unit 26 found
      ref:SetScale(0.8)
    elseif newstate == "r11" then
      --raid unit 11 found
      ref:SetScale(0.9)
    elseif newstate == "r1" then
      --other case
      ref:SetScale(1)
    end
]])
stateFrame:SetFrameRef("raidHeader", myRaidFrameHeader)

Secure handler documentation:
http://www.iriel.org/wow/docs/Secure...ide-4.0-r1.pdf
http://wowprogramming.com/docs/secur...ureStateHeader