Party frames in arena

[Grimsin]

Is there an obvious reason why my party frames do not show up in arenas?

[Seerah]

Do you have them set to hide when in raid?

[Grimsin]

i have party frames set to hide in raid. Well actually... my code checks to see what the blizzard option is set to to decide that... but i always have mine checked to hide them in raid. When you are in the arena it thinks you are in a raid?

My party frames have some issues with hiding and showing properly all the time in general. like for some reason when you queue for wintersgrasp it does not hide the party frames like its supposed to. You have to /reload to get it to register but yet if you are in a party and the party leader shifts it to a raid it changes up just fine. I have PLAYER_ENTERING_WORLD set as one of the events to check against so i would think it would fire when entering wintersgrasp and fix the party frames. But it does not...

I had a problem with the party frames not showing up after being in a raid and everyone dropping from a dungeon. I think i fixed that although im sure if you were to drop raid while in combat it would fire taint since my fix was not secure code.

Also have a funny issue with the party leader icons, if you go to a random with a friend and you finish the random if you both stay partied and everyone else drops and you leave the dungeon it for some reason thinks you are both the party leader and the leader icon gets stuck. Only does this for party member 1. The other ones seem to function right when this same scenario is recreated.

IE having 3 friends... its only partyframe 1 that gets the leader icon stuck. partyframe 2's leader icon functions proper.

I would post my partyframes code but..... i wouldnt expect anyone to look through it its almost 12000 lines... - edit: i take that back its about 6000 lines and thats with most of the 2nd layout missing and no petframes for either layout....

[Grimsin]

i weeded out the parts that deal with the hiding/showing

-----------------------------------------
---- hide party frames in raid Start ----
-----------------------------------------
 
local RaidPartyHandler = CreateFrame("Frame", "RaidPartyHandler", UIParent, "SecureHandlerStateTemplate");
SecureHandler_OnLoad(RaidPartyHandler);
GrimUI.RaidPartyHandler = RaidPartyHandler
 
GrimPartyMain = CreateFrame("Frame", nil, RaidPartyHandler);
GrimUI.GrimPartyMain = GrimPartyMain
 
 
RaidPartyHandler:SetFrameRef("GrimPartyMain", GrimPartyMain);
 
RaidPartyHandler:Execute([[
GrimPartyMain = self:GetFrameRef("GrimPartyMain");
]]);
 
RaidPartyHandler:Execute("raidhideparty = " .. tostring(GetCVar("hidePartyInRaid"))); -- hook to Blizzard option for party raid hide frames 
 
 
RaidPartyHandler:SetAttribute("_onstate-unitexists", [[
    if raidhideparty == 1 and newstate then
    GrimPartyMain:Hide()
    end
    if raidhideparty ~= 1 and newstate then
    GrimPartyMain:Show()
    end
]]);
 
RaidPartyHandler:SetAttribute("unit", "raid1");
RegisterUnitWatch(RaidPartyHandler, true);
 
 
 
RaidPartyHandler:SetAttribute("state-unitexists", UnitExists("raid1"));
 
-----------------------------------------
---- hide party frames in raid End   ----
-----------------------------------------
 
---------------------------------------
-- show them again when you leave it heh....
----------------------------------------------
local ReshowPartyFrames = CreateFrame("Frame", nil, UIParent)
ReshowPartyFrames:RegisterEvent("RAID_ROSTER_UPDATE")
ReshowPartyFrames:RegisterEvent("PLAYER_ENTERING_WORLD")
 
GrimUI.ReshowPartyFrames = ReshowPartyFrames
 
ReshowPartyFrames:SetScript("OnEvent", function(self)
    
    local StillInRaid = UnitExists("raid1")
    
    if event == "PLAYER_ENTERING_WORLD" and StillInRaid ~= 1 then
    GrimPartyMain:Show()
    end
    
    
    if StillInRaid ~= 1 then
    GrimPartyMain:Show()
    end
 
end)

[Shadowed]

There's a simpler way of doing it. You don't need to muck around with the secure system as much: partyFrame is the secure header that shows the party frame.

local stateMonitor = CreateFrame("Frame", nil, nil, "SecureHandlerBaseTemplate")
        stateMonitor:SetFrameRef("partyHeader", partyFrame)
        stateMonitor:WrapScript(stateMonitor, "OnAttributeChanged", [[
            if( name ~= "state-raidmonitor" ) then return end
            
            if( self:GetAttribute("state-raidmonitor") == "raid" ) then
                self:GetFrameRef("partyHeader"):Hide()
            else
                self:GetFrameRef("partyHeader"):Show()
            end
        ]])
        RegisterStateDriver(stateMonitor, "raidmonitor", "[target=raid1, exists] raid; none")

That is a simplified version of what Shadowed Unit Frames does, https://gist.github.com/6323ba8bb2a9a4365413 is the full version which let's me do things like modify the stateMonitors attributes to decide whether or not I want the feature enabled.

You have to WrapScript before you call RegisterStateDriver, because as soon as you call RegisterStateDriver it's going to check the state and it'll switch to raid (or none) before your attribute event is setup.

[Grimsin]

so wait what your saying is i can hook my party frames to partyFrame? and use that stateheader to control the party frames? and it will register the bliz option as well?

[Dayve]

Originally Posted by Shadowed There's a simpler way of doing it. You don't need to muck around with the secure system as much: partyFrame is the secure header that shows the party frame.

Both versions use secure code to respond to a state attribute change, but Grimsin's method (which is my old method that I told him about) uses UnitWatch to set the state while yours uses a state driver. What is simpler is this method which I started using recently:

RegisterStateDriver(partyFrame, "visibility", "[@raid1,exists]hide;show");

That will enable in-raid hiding on partyFrame, no other code required. And to disable it after having been enabled:

UnregisterStateDriver(partyFrame, "visibility");
partyFrame:Show();