Run secure code - Page 2

kurapica.igas · 07-12-16, 06:38 AM

That's right, I create a 25 unit frames for one raid panel when the addon is loaded, I don't need to force the group header to generate unit buttons, since I can bind them in the secure environment.

The performance is not bad if you build you secure snippets carefully, it don't change too much during a raid. I suffer a little freeze when entering a raid group, but works well during the rest time, it's sadly there is no GetTime api for us to avoid repeat operations.

Resike · 07-12-16, 06:40 AM

Originally Posted by kurapica.igas

Well, you can't call the GenerateUnitFrames during combat, the GenerateUnitFrames is used to replace the "refreshUnitChange" to "_onattributechanged", here is a simple version

Lua Code:

local _Task = {}
 
grpHeader:SetScript("OnUpdate", function(self, elapsed)
    if not InCombatLockdown() and #_Task > 0 then
        for _, cnt in ipairs(_Task) do
            GenerateUnitFrames(self, count)
        end
        wipe(_Task)
    end
end)
 
function grpHeader:UpdateUnitCount(count)
    tinsert(_Task, count)
end

If you don't create buttons based on the auto-generated unit buttons, the refreshUnitChange and _onattributechanged will do the same work, only the refreshUnitChange won't be fired when a unit is set to nil, so I replace it with a better one when out of combat.

Well that the issue, when i enter into combat in Ashran with 5 ppl in the raid and does't leave combat for the next 3 hours, then how are my frames gonna get updated properly when people join and leave the raid frequently? I also would like to keep the original header frames.

Resike · 07-12-16, 06:46 AM

Originally Posted by kurapica.igas

That's right, I create a 25 unit frames for one raid panel when the addon is loaded, I don't need to force the group header to generate unit buttons, since I can bind them in the secure environment.

The performance is not bad if you build you secure snippets carefully, it don't change too much during a raid. I suffer a little freeze when entering a raid group, but works well during the rest time, it's sadly there is no GetTime api for us to avoid repeat operations.

The real issue is with the secure headers, their "OnAttributeChanged" gets triggered for [maxColumns * unitsPerColumn] times even if only 1 ppl joins/leaves the raid. Same for aura headers. And this is so dumb.

While you can filter this properly in a real code, i'm not sure if you can do this in a secure snippet:
http://www.wowinterface.com/forums/s...ad.php?t=53132

kurapica.igas · 07-12-16, 08:19 AM

Originally Posted by Resike

Well that the issue, when i enter into combat in Ashran with 5 ppl in the raid and does't leave combat for the next 3 hours, then how are my frames gonna get updated properly when people join and leave the raid frequently? I also would like to keep the original header frames.

Well, it's not that bad, the refreshUnitChange would works well, also with UnitExists (works in secure) and other APIs, we can do much things, it's just not perfect.

The cooldown and etc are none secure elements, so there is no need to do it in the secure ways.

Resike · 07-12-16, 08:56 AM

Originally Posted by kurapica.igas

Well, it's not that bad, the refreshUnitChange would works well, also with UnitExists (works in secure) and other APIs, we can do much things, it's just not perfect.

The cooldown and etc are none secure elements, so there is no need to do it in the secure ways.

Yes but with secure headers it works perfectly even in combat. I would not like to lose that.

I wanna try one more thing when i get home, to run a predefinied attribute directly from the UnitFrame's filtered "OnAttributeChanged" SetScript, but i have a feeling that it will taint.