Thread Tools Display Modes
11-16-20, 09:23 PM   #1
Niketa
A Wyrmkin Dreamwalker
 
Niketa's Avatar
AddOn Author - Click to view addons
Join Date: Jul 2013
Posts: 54
Originally Posted by StormFX View Post
Looks like most of your problem is your tags line.

For your "stable" builds, try something like:

Code:
on:
  push:
    tags:
      - '*.*.*'
      - '!*.*.*-*'
For your developmental builds, try something like:

Code:
on:
  push:
    tags:
      - '*.*.*-*'
Note the '!*.*.*-*' bit for the stable file. The ! means to ignore tags that match expression that follows, so you're explicitly telling the stable file to ignore developmental builds.

You don't need your add-on's name in tags. The packager does that and it's kind of redundant. So keep them simple, like "v2.0.4" or "v2.0.4-beta". If you must do it, make sure you include it in your tag lines for your workflows. The tag lines match the name of tags (regex-ish), so you'd do something like:

Code:
      - 'GuildBankSnapshots-*.*.*'
      - '!GuildBankSnapshots-*.*.*-*'
Etc.
This seems to have fixed the issue.

Just for educational reasons, could you explain why the previous version I had may have behaved in the way they did? Such as why it was rerunning on old tags and releasing everything as an alpha?

Also, should I have my workflows only on my stable branch or should I have it on my development branch too? I'm thinking just stable because I think it was double uploading when I had it on both, but I want to be sure I understand it right.

Thanks!
  Reply With Quote
11-17-20, 12:38 PM   #2
StormFX
A Flamescale Wyrmkin
 
StormFX's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2006
Posts: 109
Originally Posted by Niketa View Post
Just for educational reasons, could you explain why the previous version I had may have behaved in the way they did? Such as why it was rerunning on old tags and releasing everything as an alpha?
For old tags, it was probably because they didn't exist on the GitHub repo (only locally). It was packaging all commits/tags because your previous tags line told it to. (** is a wildcard that matches all commits/tags). As for it packaging alphas, a non-tag commit is considered an alpha by the packager.

Originally Posted by Niketa View Post
Also, should I have my workflows only on my stable branch or should I have it on my development branch too? I'm thinking just stable because I think it was double uploading when I had it on both, but I want to be sure I understand it right.

Thanks!
By filtering your tags as I demonstrated above, tags should be properly packaged as release or alpha/beta, as long as they're tagged properly. You could theoretically leave workflows intact and synced on both branches.

If you want it more refined, you could add back in the branch filtering that you had previously. Alternatively, if your commits and tags are exclusive to their respective branch (ie, you only push alpha/beta to the development branch), you could simply remove the stable workflow from the development branch and remove the development workflow from the stable branch.
  Reply With Quote

WoWInterface » Developer Discussions » Tutorials & Other Helpful Info. » Guide: Automagically package and publish addons


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off