I need your help to combine two addons please

Yukka · 05-29-23, 05:50 AM

Hello, I tried to combine these two addons but it seems I cant get it right... Can someone create one addon with these two addons please?

First addon plays a sound when the pet dies and the second addon play a sound when the pet life is about 35%. If possible I prefer when the addon play the sounds from the addon folder just like in the second addon. Thanks.

First addon:

Lua Code:

local f = CreateFrame("Frame")
f:RegisterUnitEvent("UNIT_HEALTH", "pet")
f:SetScript("OnEvent", function()
  if not UnitExists("pet") or UnitHealth("pet") == 0 then
    PlaySound(6595)
  end
end)

Second addon:

Lua Code:

local _,PetHealthAlert=...
local Frame=CreateFrame("ScrollingMessageFrame","!PHA",UIParent)    
Frame.Threshold=35
Frame.Warned=false
-- Initialize
function PetHealthAlert:Initialize()    
    Frame:SetWidth(450)
    Frame:SetHeight(200)
    Frame:SetPoint("CENTER",UIParent,"CENTER",0,0)  
    Frame:SetFont("Interface\\AddOns\\!PHA\\Res\\PHA_.TTF",30,"THICKOUTLINE")
    Frame:SetShadowColor(0.00,0.00,0.00,0.75)
    Frame:SetShadowOffset(3.00,-3.00)
    Frame:SetJustifyH("CENTER")     
    Frame:SetMaxLines(2)
    --Frame:SetInsertMode("BOTTOM")
    Frame:SetTimeVisible(2)
    Frame:SetFadeDuration(1)        
    HealthWatch:Update()
end
-- Update health warning
function PetHealthAlert:Update()    
    if(floor((UnitHealth("pet")/UnitHealthMax("pet"))*100)<=Frame.Threshold and Frame.Warned==false)then
        PlaySoundFile("Interface\\AddOns\\!PHA\\Res\\PHA.ogg")  
        Frame:AddMessage("- CRITICAL PET HEALTH -", 1, 0, 0, nil, 3)
        Frame.Warned=true
        return
    end
    if(floor((UnitHealth("pet")/UnitHealthMax("pet"))*100)>Frame.Threshold)then
        Frame.Warned=false
        return
    end 
end
-- Handle events
function PetHealthAlert:OnEvent(Event,Arg1,...)
    if(Event=="PLAYER_LOGIN")then
        PetHealthAlert:Initialize()
        return
    end 
    if(Event=="UNIT_HEALTH" and Arg1=="pet")then
        PetHealthAlert:Update()
        return
    end 
end
Frame:SetScript("OnEvent",PetHealthAlert.OnEvent)
Frame:RegisterEvent("PLAYER_LOGIN")
Frame:RegisterEvent("UNIT_HEALTH")

SDPhantom · 05-29-23, 08:20 AM

Here's what I've come up with along with some tweaks and optimizations.

Lua Code:

local AddOnPath=("Interface\\AddOns\\%s\\"):format(...);--  Dynamically fetch our addon path
 
local Frame=CreateFrame("ScrollingMessageFrame",nil,UIParent)
Frame:SetSize(450,200)
Frame:SetPoint("CENTER")
Frame:SetFont(AddOnPath.."Res\\PHA_.TTF",30,"THICKOUTLINE")
Frame:SetShadowColor(0.00,0.00,0.00,0.75)
Frame:SetShadowOffset(3.00,-3.00)
Frame:SetJustifyH("CENTER")
Frame:SetMaxLines(2)
--Frame:SetInsertMode("BOTTOM")
Frame:SetTimeVisible(2)
Frame:SetFadeDuration(1)
 
Frame:RegisterEvent("PLAYER_LOGIN")
Frame:RegisterUnitEvent("UNIT_PET","player")
Frame:RegisterUnitEvent("UNIT_HEALTH","pet")
 
local LowHealthThreshold=0.35;
local LastHealthValue=0;
Frame:SetScript("OnEvent",function(self)
    if UnitExists("pet") then-- Check if pet exists
        local cur,max=UnitHealth("pet"),UnitHealthMax("pet");
        if cur and max and max>0 then-- Check if we have health data
            if cur<LastHealthValue then--   Has health decreased?
                if cur<=0 then--    Is pet dead?
                    PlaySoundFile(AddOnPath.."Res\\PHA.ogg")
                    self:AddMessage("- PET DEAD -", 1, 0, 0, nil, 3)
                elseif cur/max<=LowHealthThreshold then--   Is pet low health?
                    PlaySoundFile(AddOnPath.."Res\\PHA.ogg")
                    self:AddMessage("- CRITICAL PET HEALTH -", 1, 0.5, 0, nil, 3)
                end
            end
 
            LastHealthValue=cur;--  Update tracking value
        else LastHealthValue=0; end--   Reset to zero if health not available yet
    else LastHealthValue=0; end--   Reset to zero if no pet
end)

Yukka · 05-29-23, 09:15 AM

Nice, thanks

but it seems that the sound is playing everytime my pet takes a hit when its life is below 35%. What I wish is the sound playing just once when the life of my pet fall under 35%. Oh I forget to say that I dont need the text thing on the screen, I just need the sounds.

SDPhantom · 05-29-23, 04:33 PM

Lua Code:

local AddOnPath=("Interface\\AddOns\\%s\\"):format(...);--  Dynamically fetch our addon path
local EventFrame=CreateFrame("Frame");
 
EventFrame:RegisterEvent("PLAYER_LOGIN");
EventFrame:RegisterUnitEvent("UNIT_PET","player");
EventFrame:RegisterUnitEvent("UNIT_HEALTH","pet");
 
local LowHealthThreshold=0.35;
local LastHealthValue=0;
EventFrame:SetScript("OnEvent",function(self)
    if UnitExists("pet") then-- Check if pet exists
        local cur,max=UnitHealth("pet"),UnitHealthMax("pet");
        if cur and max and max>0 then-- Check if we have health data
            if cur<=0 and LastHealthValue>0 then--  Is pet dead?
                PlaySoundFile(AddOnPath.."Res\\PHA.ogg");
            elseif cur/max<=LowHealthThreshold and LastHealthValue/max>LowHealthThreshold then--    Is pet low health?
                PlaySoundFile(AddOnPath.."Res\\PHA.ogg");
            end
 
            LastHealthValue=cur;--  Update tracking value
        else LastHealthValue=0; end--   Reset to zero if health not available yet
    else LastHealthValue=0; end--   Reset to zero if no pet
end)

Yukka · 05-30-23, 06:43 AM

This time it play the low life sound once, thats nice, but the death sound doesnt play when my pet dies

SDPhantom · 05-31-23, 12:51 AM

I'll have to poke around. The one you had before would send a false positive if the pet despawned due to range or pathing issues. If this doesn't bother you, I could put that back in the logic.

Yukka · 06-01-23, 04:56 AM

Sure, no worry

SDPhantom · 06-06-23, 01:37 AM

Lua Code:

local AddOnPath=("Interface\\AddOns\\%s\\"):format(...);--  Dynamically fetch our addon path
local EventFrame=CreateFrame("Frame");
 
EventFrame:RegisterEvent("PLAYER_LOGIN");
EventFrame:RegisterUnitEvent("UNIT_PET","player");
EventFrame:RegisterUnitEvent("UNIT_HEALTH","pet");
 
local LowHealthThreshold=0.35;
local LastHealthValue=0;
EventFrame:SetScript("OnEvent",function(self)
    local cur,max; if UnitExists("pet") then--  Check if pet exists
        cur,max=UnitHealth("pet"),UnitHealthMax("pet");
    else cur,max=0,1; end-- Process no pet as dead
 
    if cur and max and max>0 then-- Check if we have health data
        if cur<=0 and LastHealthValue>0 then--  Is pet dead?
            PlaySoundFile(AddOnPath.."Res\\PHA.ogg");
        elseif cur/max<=LowHealthThreshold and LastHealthValue/max>LowHealthThreshold then--    Is pet low health?
            PlaySoundFile(AddOnPath.."Res\\PHA.ogg");
        end
 
        LastHealthValue=cur;--  Update tracking value
    else LastHealthValue=0; end--   Reset to zero if health not available yet
end);

Yukka · 06-06-23, 09:28 AM

It works perfect! A huge thanks to you

EDIT: posted the addon here.