Code isn't functioning in WoD zones

[myrroddin]

RepByZone's code should either set the watched faction to the combat ally/bodyguard or Stormwind/Orgrimmar if the player has no bodyguard.

With testing, I know that the variable bodyguardRepID contains data for the character with a bodyguard, and nil for characters without a bodyguard. However, the print statement on line 627 of Core-Retail.lua isn't doing anything when I am in my garrison or any WoD zone. Nothing gets printed. The entire line doesn't fire, and I don't know why.

It fires for every other location I've tested, just not any WoD zones.

Attached is the full zip, which contains non-retail files. Those are working, although I'll be streamlining them later. But the non-retail files aren't the issue.

I'd appreciate any bright ideas or insight into why WoD zones are different and what is (not) going on when I go to them.

Thank you.

EDIT: not only is line 627 not firing in WoD zones, the variable watchedFactionID is not a number, so the watched rep bar gets cleared, regardless of whether having a bodyguard or not. The watched faction isn't even Stormwind or Orgrimmar.

[myrroddin]

Okay, this is bizzare; I was wrong: it isn't WoD zones, it is the final check to assign world zone data. No matter if I use:

if type(watchedFactionID) ~= "number" then ...

Or if I use

if not watchedFactionID then ...

Both of these fail, or at least are somehow assigning a value of 0 or nil to watchedFactionID. I have no clue why either of those if statements are behaving like that.

Here is my updated function SwitchedZones() with the faulty if statement on line 82 below.

-- Player switched zones, subzones, or instances, set watched faction
function RepByZone:SwitchedZones(event)
    if not db.enabled then return end -- Exit if the addon is disabled
 
    -- Possible zoning issues, exit out unless we have valid map data
    local uiMapID = C_Map.GetBestMapForUnit("player")
    if not uiMapID then return end
 
    if isOnTaxi then
        if not db.watchOnTaxi then
            -- On taxi but don't switch
            return
        end
    end
 
    -- Some data may not be available because of the specialty zone functions, get something until a full data update refreshes things
    instancesAndFactions = instancesAndFactions or self:InstancesAndFactionList()
    zonesAndFactions = zonesAndFactions or self:ZoneAndFactionList()
    subZonesAndFactions = subZonesAndFactions or self:SubZonesAndFactionsList()
 
    if event == "BODYGUARD_UPDATED" then
        -- This is a custom event
        bodyguardRepID = self:GetActiveBodyguardRepID()
    else
        -- bodyguardRepID might still be nil if there is no bodyguard
        bodyguardRepID = bodyguardRepID or self:GetActiveBodyguardRepID()
    end
 
    -- Set up variables
    local _, watchedFactionID, factionName, isWatched
    local hasDungeonTabard = false
    local inInstance, instanceType = IsInInstance()
    local whichInstanceID = inInstance and select(8, GetInstanceInfo())
    local parentMapID = C_Map.GetMapInfo(uiMapID).parentMapID
    local subZone = GetMinimapZoneText()
    local isWoDZone = self.WoDFollowerZones[uiMapID] or (self.WoDFollowerZones[uiMapID] == nil and self.WoDFollowerZones[parentMapID])
 
    -- Apply instance reputations. Garrisons return false for inInstance and "party" for instanceType, which is good, we can filter them out
    if inInstance and instanceType == "party" then
        hasDungeonTabard = false
        -- Certain dungeons do not benefit from tabards
        if self.tabardExemptDungeons[whichInstanceID] then
            return
        end
        -- Process faction tabards
        if db.useFactionTabards then
            if tabardID then
                watchedFactionID = tabardID
                hasDungeonTabard = true
            end
        else
            -- We aren't watching faction tabards
            hasDungeonTabard = false
        end
    else
        -- We aren't in a party
        hasDungeonTabard = false
    end
 
    -- We aren't in an instance that supports tabards or we aren't watching tabards in the dungeon
    if inInstance and not hasDungeonTabard then
        watchedFactionID = instancesAndFactions[whichInstanceID]
    end
 
    -- Override in WoD zones only if a bodyguard exists
    if isWoDZone and bodyguardRepID then
        watchedFactionID = bodyguardRepID
    end
 
    -- Process subzones
    if db.watchSubZones then
        -- Don't loop through subzones if the player is watching a bodyguard rep
        if isWoDZone and bodyguardRepID then return end
 
        -- Battlegrounds and warfronts are the only instances with subzones
        if inInstance and instanceType ~= "pvp" then return end
 
        -- Get our subzone data
        if subZone then
            watchedFactionID = CitySubZonesAndFactions[subZone] or subZonesAndFactions[subZone]
        end
    elseif not watchedFactionID then
        if (isWoDZone and bodyguardRepID) or inInstance then return end
        -- Get world zone data or the character's default watched faction
        watchedFactionID = zonesAndFactions[uiMapID] or db.defaultRepID
 
        self:Print("DEBUG: watchedFactionID:", watchedFactionID)
    end
 
    -- WoW has a delay whenever the player changes instance/zone/subzone/tabard; factionName and isWatched aren't available immediately, so delay the lookup, then set the watched faction on the bar
    C_Timer.After(db.delayGetFactionInfoByID, function()
        if type(watchedFactionID) == "number" then
            -- We have a factionID for the instance/zone/subzone/tabard or we don't have a factionID and db.defaultRepID is a number
            factionName, _, _, _, _, _, _, _, _, _, _, isWatched = GetFactionInfoByID(watchedFactionID)
            if factionName and not isWatched then
                C_Reputation.SetWatchedFaction(watchedFactionID)
                if db.verbose then
                    self:Print(L["Now watching %s"]:format(factionName))
                end
            end
        else
            -- watchedFactionID is not valid because there is no factionID for the instance/zone/subzone/tabard or db.defaultRepID is not a number
            C_Reputation.SetWatchedFaction(0)
        end
    end)
end

[myrroddin]

More debugging. watchedFactionID is nil with the following code, at least for WoD zones and now subzones too, as "Dwarven District" in Stormwind stopped working. It is supposed to be 47 for Ironforge. It is 72 when I'm in other parts of Stormwind and 2510 in Valdrakken, so the major zones are working.

I also tested the addon settings and disabled Lunarfall (the Alliance Garrison) checking for a bodyguard, and suddenly the bar went from blank to Stormwind. This tells me something about isWoDZone and/or bodyguardRepID, and that I'm not handling one or both correctly. I'm not seeing the logic bomb.

As fast as I am getting answers, I am getting more confused about WoD and subzones. Besides anyone being helpful with debugging, I would love to learn why it isn't working, not just a fix.

-- Process subzones
if db.watchSubZones then
    -- Battlegrounds and warfronts are the only instances with subzones
    if inInstance and instanceType ~= "pvp" then return end
 
    -- Don't loop through subzones if the player is watching a bodyguard rep
    if isWoDZone and bodyguardRepID then
        watchedFactionID = bodyguardRepID
    else
        -- Get our subzone data
        watchedFactionID = CitySubZonesAndFactions[subZone] or subZonesAndFactions[subZone]
    end
end
 
-- Get world zone data or the character's default watched faction
watchedFactionID = (watchedFactionID == nil and zonesAndFactions[uiMapID]) or db.defaultRepID
 
self:Print("DEBUG: watchedFactionID:", watchedFactionID)

[myrroddin]

I solved it, yet even though I solved the issues, I can't explain why this was necessary or what my prior method was doing wrong.

-- Process subzones
if db.watchSubZones then
    -- Battlegrounds and warfronts are the only instances with subzones
    if inInstance and instanceType ~= "pvp" then return end
 
    -- Don't loop through subzones if the player is watching a bodyguard rep
    if isWoDZone and bodyguardRepID then
        watchedFactionID = bodyguardRepID
    else
        -- Get our subzone data
        watchedFactionID = CitySubZonesAndFactions[subZone] or subZonesAndFactions[subZone]
    end
end
 
-- Get world zone data or the character's default watched faction. For some unknown reason, watchedFactionID loses data from bodyguards and instances at this stage in the code, refresh
if watchedFactionID == nil then
    if isWoDZone and bodyguardRepID then
        watchedFactionID = bodyguardRepID
    elseif inInstance and hasDungeonTabard then
        watchedFactionID = tabardID
    elseif inInstance then
        watchedFactionID = instancesAndFactions[whichInstanceID] or db.defaultRepID
    else
        watchedFactionID = zonesAndFactions[uiMapID] or db.defaultRepID
    end
end