Making my own BossFrames with XML - Need help with show states

[tehmoku]

Since it seems I cannot move the default Boss1TargetFrame without running in to issues in combat, I've just decided to recreate the boss frames in XML with BossTargetFrameTemplate. XML is uncharted territory for me, so be gentle.

I have essentially gotten the frames to look how I want them to look, and function how I want them to function with the exception of their show state.

I can get them to hide when there's no bosses around, but I cannot get them to mirror the "normal" bossframes, especially when more than 1 boss gets pulled.

Here is my current code:

Basic XML

<Ui xmlns="http://www.blizzard.com/wow/ui/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.blizzard.com/wow/ui/
..\FrameXML\UI.xsd">
	<Script file="mBossframes.lua"/>
	<Button name="mBoss1TargetFrame" inherits="BossTargetFrameTemplate" id="1">
		<Anchors>
			<Anchor point="TOPRIGHT" x="-310" y="-510"/>
		</Anchors>
	</Button>
	<Button name="mBoss2TargetFrame" inherits="BossTargetFrameTemplate" id="2">
		<Anchors>
			<Anchor point="TOPLEFT" relativeTo="mBoss1TargetFrame" relativePoint="BOTTOMLEFT" x="0" y="-30"/>
		</Anchors>
	</Button>
	<Button name="mBoss3TargetFrame" inherits="BossTargetFrameTemplate" id="3">
		<Anchors>
			<Anchor point="TOPLEFT" relativeTo="mBoss2TargetFrame" relativePoint="BOTTOMLEFT" x="0" y="-30"/>
		</Anchors>
	</Button>
	<Button name="mBoss4TargetFrame" inherits="BossTargetFrameTemplate" id="4">
		<Anchors>
			<Anchor point="TOPLEFT" relativeTo="mBoss3TargetFrame" relativePoint="BOTTOMLEFT" x="0" y="-30"/>
		</Anchors>
	</Button>
	<Button name="mBoss5TargetFrame" inherits="BossTargetFrameTemplate" id="5">
		<Anchors>
			<Anchor point="TOPLEFT" relativeTo="mBoss4TargetFrame" relativePoint="BOTTOMLEFT" x="0" y="-30"/>
		</Anchors>
	</Button>
</Ui>

And Lua:

function IsBossFrameShown()
    for i = 1, MAX_BOSS_FRAMES do
    local b = _G["Boss"..i.."TargetFrame"]
        if b and b:IsShown() then
          return true
        end
    end
    return false
end
 
function UpdateView()
    for i = 1, MAX_BOSS_FRAMES do
        local t = _G["mBoss"..i.."TargetFrame"]
    if mBoss1TargetFrame:IsShown() and IsBossFrameShown() then
        return
    elseif not mBoss1TargetFrame:IsShown() and IsBossFrameShown() then
        mBoss1TargetFrame:Show()
    elseif (t) then
            t:Hide()
    end
    end
end
 
for i = 1, MAX_BOSS_FRAMES do
    local b = _G["Boss"..i.."TargetFrame"]
    b:HookScript("OnShow",function() UpdateView() end)
    b:HookScript("OnHide",function() UpdateView() end)
end

[Resike]

I think this is going to be a lot harder then i thought so since calling the default global boss loaders also taint shit, i'll create my boss frames later this week then i can share my insights if you can wait a bit.

[tehmoku]

Sounds good, look forward to it.

[Vrul]

You can run this after your XML:

for id = 1, MAX_BOSS_FRAMES do
	local frame = _G[("mBoss%uTargetFrame"):format(id)]
	if frame then
		RegisterStateDriver(frame, "visibility", ("[@boss%u,exists] show; hide"):format(id))
	end
end

[tehmoku]

Originally Posted by Vrul You can run this after your XML: for id = 1, MAX_BOSS_FRAMES do local frame = _G[("mBoss%uTargetFrame"):format(id)] if frame then RegisterStateDriver(frame, "visibility", ("[@boss%u,exists] show; hide"):format(id)) end end

Running this shows them okay but without a TargetFrame_Update() they look like this (the bottom ones)



Also, when two bosses are pulled at the same time it throws another error.

1x [ADDON_ACTION_BLOCKED] AddOn '!mUI' tried to call the protected function 'Boss1TargetFrame:Show()'.

[zork]

That is because you have altered the Blizzard frames in combat with your UpdateView?!

The state driver will do the show/hide for you securely.
Do not interact with the frames directly unless you have a InCombatLockdown check in place.

That being said you can write your own secure handler. Inside that handler you have access to a referenced frame if needed and have access to functions that are allowed in secure environment.

An example can be the secure page handling on actionbars I use: https://github.com/zorker/rothui/blo...r/bars.lua#L78

--state frame
local frame = CreateFrame("Frame",nil,nil,"SecureHandlerStateTemplate")
--_onstate-boss state driver
for id = 1, MAX_BOSS_FRAMES do
  local name = "Boss"..i.."TargetFrame"
  local unitFrame = _G[name]
  frame:SetFrameRef(name, unitFrame)
end
frame:Execute(([[
  unitFrames = table.new()
  for i=1, %d do
    table.insert(unitFrames , self:GetFrameRef("Boss"..i.."TargetFrame"))
  end
]]):format(MAX_BOSS_FRAMES))
frame:SetAttribute("_onstate-boss", [[
  print("_onstate-boss",newstate,unitFrames )
  for i, unitFrame in next, unitFrames do
    print(unitFrame:GetName(),unitFrame:IsShown())
  end
]])
RegisterStateDriver(frame, "boss", "[@boss5,exists,nodead]5;[@boss4,exists,nodead]4;[@boss3,exists,nodead]3;[@boss2,exists,nodead]2;[@boss1,exists,nodead]1;0")

[tehmoku]

Originally Posted by zork That is because you have altered the Blizzard frames in combat with your UpdateView?! The state driver will do the show/hide for you securely. Do not interact with the raid frames directly unless you have a InCombatLockdown check in place.

Will try out code posted and let you know.

[zork]

Forgot the first two lines. You need a state handler frame.
If you need additional references to your frame you need to add them.
Do not try to access frames inside the handler that you have no access to via getframeref.
Not sure if the state handler frame needs to be visible to work.

[Resike]

The problem is that the default Target/Boss global functions taints stuff when called from addons, so you can't just use the template and call it a day, you probably need to create everything from scratch.