Git testing required

[haste]

Hey

I've refactored oUF initObject function over at git, and it's quite possible that I've broken something for someone. The main reason for this was to remove deprecated code and fix issues such as the one reported in this topic (post #3 mainly).

The post report two issues:

Originally Posted by villiv - These party-targets have not 'partytarget' as 'oUF-guessUnit' attribute. - It seems 'enableTargetUpdate' function not works correctly. Though 'OnShow' update works.

Both of these are solved, but oUF-guessUnit will still be party in this case, as it's modified after we've left the secure env. The style function will be called correctly with partytarget however.

I don't really see a reason to update oUF-guessUnit after oUF-initialConfigFunction has been called. The attribute exists mainly to send information out of the secure env. to initObject and the style function.

There are also some other fixes since 1.5.8, but these should be pretty stable.

It would be nice if people could give their 1.5.x layouts a whirl with the git version and see if it breaks anything. I want to push 1.5.9 as soon as possible, but there's no way I can test most of the configurations you can throw at initObject myself .

Download of git head:
- as tar.gz
- as zip

changelog

[haste]

Guess I should mention that it's mainly any frame spawned through :SpawnHeader() that needs testing. The changes effecting frames spawned through :Spawn() should be working fine as it is.

[gagou]

I did not see your post earlier but I made some quick test yesterday evening and got this error:

Interface\\FrameXML\\RestrictedExecution.lua:397: Call failed: [string \"		local header = self:GetParent()...\"]:15: attempt to index local 'groupFilter' (a number value):
Interface\\FrameXML\\RestrictedExecution.lua:397: in function <Interface\\FrameXML\\RestrictedExecution.lua:390>:
(tail call): ?:
Interface\\FrameXML\\SecureGroupHeaders.lua:108: in function `SetupUnitButtonConfiguration':
Interface\\FrameXML\\SecureGroupHeaders.lua:158: in function <Interface\\FrameXML\\SecureGroupHeaders.lua:115>:
Interface\\FrameXML\\SecureGroupHeaders.lua:392: in function <Interface\\FrameXML\\SecureGroupHeaders.lua:381>:
<in C code>: in function `Show'
oUF_Bibi4-4\\oUF_Bibi4.lua:851: in function `spawnHeader'
oUF_Bibi4-4\\oUF_Bibi4.lua:857: in function `func'
   oUF_Bibi4-4\\oUF\\factory.lua:17: in function <Interface\\AddOns\\oUF_Bibi4\\oUF\\factory.lua:13>
   (tail call): ?:

workingEnv = <userdata>
ctrlHandle = <userdata>
pcallFlag = false
LOCAL_Function_Environment_Manager = <function> defined @Interface\\FrameXML\\RestrictedExecution.lua:209
error = <function> defined =[C]:-1
tostring = <function> defined =[C]:-1

here is my call to SpawnHeader:

	self:SetActiveStyle('oUF_Bibi4 - Raid')

	local function spawnHeader(point, xOffset, yOffset, name, template, visibility, ...)
		local header = oUF:SpawnHeader(
			name,
			template,
			visibility,
			'oUF-initialConfigFunction', ([[
				self:SetAttribute('*type1', 'target')
				self:SetAttribute('*type2', nil)
				self:SetWidth(%d)
				self:SetHeight(%d)]]):format(RAID_WIDTH, RAID_HEIGHT),
			...
		)
		header:SetPoint(point, xOffset, yOffset)
		header:Show()
	end

	--spawn raid frames
	for i = 1, 8 do
		local point, xOffset, yOffset = unpack(bibi4Config['raid'..i])
		spawnHeader(
			point,
			xOffset,
			yOffset,
			strformat('oUF_Bibi4_Raid%d', i),
			'SecureGroupHeaderTemplate',
			'custom [@raid6,noexists] hide;show',
			'point', 'BOTTOM',
			'yOffset', RAID_GAP,
			'sortMethod', 'INDEX',
			'groupFilter', i,
			'showRaid', true
		)
	end

I'm currently at work so I'm not able to do any more test before this evening.

[haste]

This should now be fixed on git.

[gagou]

I tested the fix yesterday evening during raid, and it was working fine

[haste]

Just want to say thanks to everyone who helped testing the changes.