Threat vs Border.

[Golle]

I want to start off by thanking the creators of oUF, thanks to you guys I get to have a really good time enjoying the thrill of "making" my own addon.

Doing the above I just ran into a problem. Working on my layout, which I use the oUF_Lily code, I've set my player frame to contain one big frame with a black color and I call it my Border. On top of it I have a Healthbar, Healthbackground, a Powerbar and a Powerbackground. The way the bars and backgrounds are positioned makes my background-frame, the Border, look like thin borders.

Lately I figured it would be cool to make that border switch to a red color whenever I'm close to taking aggro to alert me of this. Doing so I thought I'd use threat.lua to trigger a function to change the frames color, but apparently threat.lua requires me to have a frame called Threat so I figured I could just rename my Border frame to Threat.
But I can't.

If I rename the frame and its variables from Border to Threat the frame just doesn't seem to load, but the threat-function is called properly. If I reset everything to use the name Border instead the frame now appears but the function is never called. Here's the snippet's of code I'm configuring:

local PostUpdateThreat = function(status, unit)
	print("threat: ", status, unit)
end

local Player = function(self, unit, isSingle)

        -- Threat/Border frame
        local Threat = CreateFrame("Frame", "PlayerBorder", self)
        Threat:SetPoint("TOPLEFT",0,0)
	Threat:SetFrameStrata("BACKGROUND")
	Threat:SetHeight(50)
	Threat:SetWidth(360)
	local Threattexture = Threat:CreateTexture("THREATLOL")
	Threattexture:SetAllPoints(Threat)
	Threattexture:SetTexture(.0, .0, .0, 1)
	Threat.texture = Threattexture
	self.Threat = Threat

        Threat.PostUpdate = PostUpdateThreat
end

I found that commenting out the "self.Threat = Threat" line is what breaks the code. If I comment it the frame appears, but PostUpdateThreat is never called. If I uncomment it the frame disappears but PostUpdateThreat is called.

I'm confused.

[Mischback]

You're on the right way!

Create a Threat-element to use the oUF-module and then use a PostUpdate-function to alter your border color:

self.Threat = CreateFrame('Frame', nil, self)
self.Threat.PostUpdate = function(self)
    self.Border.tex:SetVertexColor(threatStatus)
end)

This is a raw, drycoded skeleton. You may want to look at my oUF_PredatorSimple, I use the exact same technique. Should be in layout.lua for the frame stuff and the actual function is in core.lua.

https://github.com/Mischback/oUF_Pre...layout.lua#L42 is where Threat is applied (function is here) and here is the ThreatUpdate-function: https://github.com/Mischback/oUF_Pre.../core.lua#L532

[Rainrider]

An easier solution would be to create your frame border as you do:

local Border = CreateFrame("Frame", "PlayerBorder", self)
Border:SetPoint("TOPLEFT",0,0)
Border:SetFrameStrata("BACKGROUND")
Border:SetHeight(50)
Border:SetWidth(360)
self.Border = Border

(btw you'll need to set a backdrop in order to see something)

Then create the the threat texture with it:

Threat = self.Border:CreateTexture(nil, "OVERLAY")
Threat:SetAllPoints()
Threat:SetTexture(yourTexture)
self.Threat = Threat

You don't need Pre/PostUpdate. oUF will hide the texture when you don't have a threat status and show and color it accordingly when you have.

[Rainrider]

And another tip (not topic related) if you allow

Don't use fixed sizes for the border as you might wish to add it to other frames too, which have different sizes. Just anchor it better:

Border:SetPoint("TOPLEFT", self, -2, 2)
Border:SetPoint("BOTTOMLEFT", self, 2, -2)

That way you just set the frame size per unit (self) and border and threat grow or shrink accordingly.

[Dawn]

Rainrider might have meant it already, but the easiest way is

      Border:SetPoint("TOPLEFT", self, -2, 2)
      Border:SetPoint("BOTTOMRIGHT", self, 2, -2)

Which will span the border around self. No width/height needed at all.

On a sidenote SetSize(width, height) is a little less code than SetWidth(x), SetHeight(y). Unless you only want to address just width or height on it's own, ofc.

[Rainrider]

Ah, shame on me, of course I meant BOTTOMRIGHT ^^ Thank you Dawn