Hi developers,
I'm looking to tweak a raid frame addon. The addon in question, PerfectRaid (written by Cladhaire) has reached the point of its life cycle where it's lightly supported by the author with feature additions largely contributed by the community. I've been using it since 2009/2010, and it still works great for 99% of what a raiding healer needs.
However, I'm running into issues with some of the newer mechanics. Specifically, on Chronomatic Anomaly, we're dealing with a healing absorb shield called Time Release that explodes unless it's healed through in time: whatever health remains on the Time Release will discharge for potentially wipe-worthy damage.
This spell, with the same name for all of them, is either:
http://www.wowhead.com/spell=219964/time-release (almost clear of the debuff)
http://www.wowhead.com/spell=219965/time-release (not safe)
http://www.wowhead.com/spell=219966/time-release (totally not clear of the debuff)
Default raid frames will show different colors for the different versions of the debuff, but because PerfectRaid calls (and caches) debuffs by the name it does not differentiate.
Step 1: Associate buffname with spellID
So I figure my first step is to associate the spell name ("buffname" in the PerfectRaid code) with the spell ID. I think I would do this in line 176, where I see:
Code:
for i=1,40 do
local name,rank,texture,count,dispelType,duration,expires,caster,stealable = UnitBuff(unit, i)
if not name then break end
if caster == "player" then
mybuffs[name] = true
mystacks[name] = (mystacks[name] or 0) + count
buffexpiry[name] = expires
end
buffcache[name] = (buffcache[name] or 0) + 1
buffstacks[name] = (buffstacks[name] or 0) + count
end
I think I can acquire the spellId just by adding the variable to the UnitBuff query (and the UnitDebuff query that follows in line 201).
Code:
for i=1,40 do
local name,rank,texture,count,dispelType,duration,expires,caster,stealable,spellID = UnitBuff(unit, i)
if not name then break end
if caster == "player" then
mybuffs[name] = true
mystacks[name] = (mystacks[name] or 0) + count
buffexpiry[name] = expires
end
buffcache[name] = (buffcache[name] or 0) + 1
buffstacks[name] = (buffstacks[name] or 0) + count
end
At this point, I have a few questions.
- Is this a valid query? Between stealable (isStealable I think is the new label) and spellID is another variable -- nameplateShowPersonal -- and I'm not sure if I'm allowed to just skip it in the query or not. I've seen some constructions where that blank variable is indicated with an underscore, but I'm not sure if that's required.
- Does this address the question of multiple spellIDs associated with one spell name? For example, will this request pull all three spellIDs for Time Release, or will something else need to be done to get that information?
- I know that if I were dealing with a database or a table, just tossing in a new variable would blow stuff up. But I think local cache spell information is saved as text? So it shouldn't be an issue? I'm a complete newbie to LUA so if I'm asking questions that make it sound like I'm missing really obvious things, that's probably because I am missing really obvious things.
I think if this was working, I could probably stop there for my purposes. I'd be able to add the specific spellIDs as default debuffs in the LUA file and move along. This would require editing the PerfectRaid files every time I wanted to add similar debuffs, but it would work. If I wanted to submit something more broadly useful though, I should probably also do Step 2.
Step 2: Allow either spellID or buffname entries
So, working on the assumption that the query for spellID is successful, I would then need to find a way to update the UI so that either the spell name or the spellID is a valid entry for setting up a buff check in PerfectRaid. I'm at much more of a loss on this one. I
think that happens around line 322...
Code:
function Buffs:CreateBuffEntry(buffname, entry)
local expires = buffexpiry[buffname]
local num = buffcache[buffname]
local stacks = buffstacks[buffname]
local mine = mybuffs[buffname]
-- show only my stacks
if entry.onlymine then
stacks = mystacks[buffname]
end
if ( ( num and num > 1 ) or ( stacks and stacks > 1 ) ) and not entry.onlymine then
local num = num
-- If the buff is mine, and it should be masked
-- A buff is masked when there is a "mine" filter set for it
if mine and not mymask[buffname] then
num = num - 1
end
if (expires and entry.showexpiry) and (stacks > 1 and entry.showstacks) then
work[#work + 1] = string.format("%s(%d,%d)", entry.colortext, stacks, -1 * (GetTime()-expires) )
elseif (stacks and stacks > 1 and entry.showstacks) then
work[#work + 1] = string.format("%s(%d)", entry.colortext, stacks )
elseif ( num and expires and entry.showexpiry) then
work[#work + 1] = string.format("%s(%d,%d)", entry.colortext, num, -1 * (GetTime() - expires))
elseif ( num and num > 1 ) then
work[#work + 1] = string.format("%s(%d)", entry.colortext, num)
else
work[#work + 1] = string.format("%s", entry.colortext)
end
else
if (entry.onlymine and not mine) or (not entry.onlymine and mymask[buffname]) then
-- Don't show
else
if (expires and entry.showexpiry) and (stacks > 1 and entry.showstacks) then
work[#work + 1] = string.format("%s(%d,%d)", entry.colortext, stacks, -1 * (GetTime()-expires) )
elseif (stacks and stacks > 1 and entry.showstacks) then
work[#work + 1] = string.format("%s(%d)", entry.colortext, stacks )
elseif (expires and entry.showexpiry) then
work[#work + 1] = string.format("%s(%d)", entry.colortext, -1 * (GetTime()-expires))
else
work[#work + 1] = entry.colortext
end
end
end
end
Or, it could happen at line 258?
Code:
-- Determine which spell name we matched
local buffname
if buffcache[entry.buffname] then
buffname = entry.buffname
elseif buffcache[entry.groupname or "nil"] then
buffname = entry.groupname
elseif buffcache[entry.groupname2 or "nil"] then
buffname = entry.groupname2
elseif buffcache[entry.groupname3 or "nil"] then
buffname = entry.groupname3
elseif buffcache[entry.groupname4 or "nil"] then
buffname = entry.groupname4
end
My questions are much more basic here, because I'm definitely at a loss in parsing this. Is there an obvious place here where I can incorporate a spellID? Or am I completely off base on this part?
I've attached the relevant LUA file (PerfectRaid_Buffs) as well as the full addon zip file.
Many, many thanks for anyone who helps out with this -- I realize my ignorance here, and know how much of a pain it can be helping someone with so little base knowledge to work with.
Linear Mode
