Hide Buffs/Debuffs on Target/Focus.

[Deadlyz]

Hello!

With release of the DF prepatch this nice piece of code doesn't work anymore
Maybe some bored addon author could help me a bit?

TargetFrame:UnregisterEvent("UNIT_AURA", unit)
FocusFrame:UnregisterEvent("UNIT_AURA", unit)

hooksecurefunc(TargetFrame, "UpdateAuras", function()
    if frame ~= TargetFrame and frame ~= FocusFrame then return end

    local frameName = frame:GetName()

    for index = 1, MAX_TARGET_BUFFS do
        local buff = _G[frameName .. "Buff" .. index]
        if buff then
            buff:Hide()
        end
    end

    for index = 1, MAX_TARGET_DEBUFFS do
        local debuff = _G[frameName .. "Debuff" .. index]
        if debuff then
            debuff:Hide()
        end
    end
end)

Thanks in advance!

[SDPhantom]

Surprisingly, it's simpler in Dragon Flight.

--  Doesn't need to be done, but saves some (not all) processing
TargetFrame:UnregisterEvent("UNIT_AURA");
FocusFrame:UnregisterEvent("UNIT_AURA");
 
local function ReleaseAllAuras(self)
    for obj in self.auraPools:EnumerateActive() do obj:Hide(); end
    self.auraPools:ReleaseAll()
end
 
hooksecurefunc(TargetFrame,"UpdateAuras",ReleaseAllAuras);
hooksecurefunc(FocusFrame,"UpdateAuras",ReleaseAllAuras);

Blizzard switched to using Mixins for most of TargetFrame's functions, meaning we can hook the Target and Focus frames directly without other inheriting frames triggering our hook. Secondly, buffs and debuffs are handled by frame pools now, which makes iterating through them easier as well.



Note: There's a bug in EditMode which throws taint errors if any addon touches any managed frame.

[Deadlyz]

Hello, and thanks for reply!

I'm getting a syntax error

3x FrameXML\Bindings.xml:1 Interface/AddOns/NoDebuffs/NoDebuffs.lua:1 Interface/AddOns/NoDebuffs/NoDebuffs.lua:5: syntax error near 'for'

[Xrystal]

Sounds like that line or the ones on either side have been worded wrong ..

Can you show us the for loop you have on line 1 or line 1 in total in case you have the word for by mistake

[Deadlyz]

Here's a fixed version version for anyone who needs it

TargetFrame:UnregisterEvent("UNIT_AURA")
FocusFrame:UnregisterEvent("UNIT_AURA")
 
local function ReleaseAllAuras(self)
    for obj in self.auraPools:EnumerateActive() do
        obj:Hide()
    end
 
    self.auraPools:ReleaseAll()
end
 
hooksecurefunc(TargetFrame, "UpdateAuras", ReleaseAllAuras)
hooksecurefunc(FocusFrame, "UpdateAuras", ReleaseAllAuras)

Thanks Lightspark for the fix.

Originally Posted by Lightspark I'd be careful with self.auraPools:ReleaseAll() tho, if you start getting weird errors related to UF auras while in combat, comment out that line. -- self.auraPools:ReleaseAll()

Thanks SDPhantom for the original code

[Deadlyz]

Aha, it seems the story isn't over yet. Turns out this code somehow hides the default castbars of the target and focus frames

UPDT: with -- self.auraPools:ReleaseAll() commented out it seems to work.

TargetFrame:UnregisterEvent("UNIT_AURA")
FocusFrame:UnregisterEvent("UNIT_AURA")
 
local function ReleaseAllAuras(self)
    for obj in self.auraPools:EnumerateActive() do
        obj:Hide()
    end
 
   -- self.auraPools:ReleaseAll()
end
 
hooksecurefunc(TargetFrame, "UpdateAuras", ReleaseAllAuras)
hooksecurefunc(FocusFrame, "UpdateAuras", ReleaseAllAuras)

[SDPhantom]

Originally Posted by Lightspark I'd be careful with self.auraPools:ReleaseAll() tho, if you start getting weird errors related to UF auras while in combat, comment out that line. -- self.auraPools:ReleaseAll()

I'm imagining they're referring to taint issues. Nothing running that should be susceptible to taint though.
Also figures I would leave something (the function keyword) out while dry-coding.



I neglected to put in anchor correction for the castbar, though it would add another taint vector.

--  Doesn't need to be done, but saves some (not all) processing
TargetFrame:UnregisterEvent("UNIT_AURA");
FocusFrame:UnregisterEvent("UNIT_AURA");
 
local function ReleaseAllAuras(self)
    for obj in self.auraPools:EnumerateActive() do obj:Hide(); end
    self.auraPools:ReleaseAll()--   Cleanup
 
    self.auraRows,self.spellbarAnchor=0,nil;--  Revert to initial values
    if self.spellbar then Target_Spellbar_AdjustPosition(self.spellbar); end--  Update anchor
end
 
hooksecurefunc(TargetFrame,"UpdateAuras",ReleaseAllAuras);
hooksecurefunc(FocusFrame,"UpdateAuras",ReleaseAllAuras);

Ideally, you'll always want to clean up after yourself. This is what self.auraPools:ReleaseAll() is for. Considering the original function already does this right before updating, it isn't as important in a practical sense.

The castbar reanchoring could be done with less taint, but if we can get away with reusing existing logic rather than recreating it, that would be better.

[Deadlyz]

SDPhantom, thanks! I've updated my file with your code

Maybe you should release this as an addon. I'm pretty sure many people using addons like Raven, ElkanoBuffBars (or similar addons that provide extra buff/debuff bars, but no means of hiding the default ones) would like to use it.

Originally Posted by SDPhantom The castbar reanchoring could be done with less taint, but if we can get away with reusing existing logic rather than recreating it, that would be better.

I wonder if it's possible to detach the default castbar and move it using screen coordinates. If it's possible would that require a lot of efforts?

[SDPhantom]

Originally Posted by Deadlyz I wonder if it's possible to detach the default castbar and move it using screen coordinates. If it's possible would that require a lot of efforts?

You can replace the anchor adjustment section with this.

if self.spellbar then
    self.spellbar:ClearAllPoints();
    self.spellbar:SetPoint("TOPLEFT",self,"BOTTOMLEFT",43,-46);--   Default anchor on large frame with ToT shown
end

Of course, you can change the anchor to whatever you want. This is just an example.

[Deadlyz]

Originally Posted by SDPhantom You can replace the anchor adjustment section with this. if self.spellbar then     self.spellbar:ClearAllPoints();     self.spellbar:SetPoint("TOPLEFT",self,"BOTTOMLEFT",43,-46);--   Default anchor on large frame with ToT shown end Of course, you can change the anchor to whatever you want. This is just an example.

Thank you! Does it work for both target and focus?

[SDPhantom]

It's one function that's hooked into both frames, that's why it's defined separately outside of the hooksecurefunc() calls instead of writing it twice.

I'd be wary of changing the anchor to something that isn't relative to self as you'd put both cast bars in the exact same spot overlapping each other. self points back to either TargetFrame or FocusFrame, whichever is currently calling the hook.

[Deadlyz]

I appreciate your help, but I don't seem to be able to make this work

--  Doesn't need to be done, but saves some (not all) processing
    TargetFrame:UnregisterEvent("UNIT_AURA");
    FocusFrame:UnregisterEvent("UNIT_AURA");
     
    local function ReleaseAllAuras(self)
        for obj in self.auraPools:EnumerateActive() do obj:Hide(); end
        self.auraPools:ReleaseAll()--   Cleanup
     
        self.auraRows,self.spellbarAnchor=0,nil;--  Revert to initial values
            if self.spellbar then
        self.spellbar:ClearAllPoints();
        self.spellbar:SetPoint("TOPLEFT",self,"BOTTOMLEFT",43,-100);--   Default anchor on large frame with ToT shown
    end--  Update anchor
    end
     
    hooksecurefunc(TargetFrame,"UpdateAuras",ReleaseAllAuras);
    hooksecurefunc(FocusFrame,"UpdateAuras",ReleaseAllAuras);

I change the coordiantes (e.g. 43,-100), then save the file and /reload ui but the castbars don't move. What am I doing wrong?

[Deadlyz]

The final version, that seems to be working:

TargetFrame:UnregisterEvent("UNIT_AURA")
FocusFrame:UnregisterEvent("UNIT_AURA")
 
local function ReleaseAllAuras(self)
    for obj in self.auraPools:EnumerateActive() do
        obj:Hide()
    end
 
    -- Cleanup
    self.auraPools:ReleaseAll()
 
    -- Revert to initial values
    self.auraRows, self.spellbarAnchor = 0, nil
 
    if self.spellbar then
        -- Reset anchor
        hooksecurefunc(self.spellbar, "SetPoint", function(spellBar, _, _, _, _, _, shouldIgnore)
            if not shouldIgnore then
                spellBar:ClearAllPoints()
 
                -- Default anchor on large frame with ToT shown
                spellBar:SetPoint("TOPLEFT", self, "BOTTOMLEFT", 43, -100, true)
            end
        end)
    end
end
 
hooksecurefunc(TargetFrame, "UpdateAuras", ReleaseAllAuras)
hooksecurefunc(FocusFrame, "UpdateAuras", ReleaseAllAuras)

UPDT: 43,-28 works the best for me.

[SDPhantom]

Originally Posted by Deadlyz hooksecurefunc(self.spellbar, "SetPoint", function(spellBar, _, _, _, _, _, shouldIgnore) if not shouldIgnore then spellBar:ClearAllPoints() -- Default anchor on large frame with ToT shown spellBar:SetPoint("TOPLEFT", self, "BOTTOMLEFT", 43, -100, true) end end)

You need to set this hook outside or it'll keep hooking itself indefinitely. Eventually, this will cause a stack overflow when the hook is called.



This is the alternative I came up with. It only applies the position hook once.

--  Doesn't need to be done, but saves some (not all) processing
TargetFrame:UnregisterEvent("UNIT_AURA");
FocusFrame:UnregisterEvent("UNIT_AURA");
 
local function ReleaseAllAuras(self)
    for obj in self.auraPools:EnumerateActive() do obj:Hide(); end
    self.auraPools:ReleaseAll()--   Cleanup
end
 
hooksecurefunc(TargetFrame,"UpdateAuras",ReleaseAllAuras);
hooksecurefunc(FocusFrame,"UpdateAuras",ReleaseAllAuras);
 
local function SpellBar_SetPoint(self)
    local meta=getmetatable(self).__index;--    Calls through self will trigger our hook, so we're making them through the metatable
    meta.ClearAllPoints(self);
    meta.SetPoint(self,"TOPLEFT",meta.GetParent(self),"BOTTOMLEFT",43,-28);
end
 
hooksecurefunc(TargetFrame.spellbar,"SetPoint",SpellBar_SetPoint);
hooksecurefunc(FocusFrame.spellbar,"SetPoint",SpellBar_SetPoint);

[Deadlyz]

Originally Posted by SDPhantom You need to set this hook outside or it'll keep hooking itself indefinitely. Eventually, this will cause a stack overflow when the hook is called. This is the alternative I came up with. It only applies the position hook once. --  Doesn't need to be done, but saves some (not all) processing TargetFrame:UnregisterEvent("UNIT_AURA"); FocusFrame:UnregisterEvent("UNIT_AURA");   local function ReleaseAllAuras(self)     for obj in self.auraPools:EnumerateActive() do obj:Hide(); end     self.auraPools:ReleaseAll()--   Cleanup end   hooksecurefunc(TargetFrame,"UpdateAuras",ReleaseAllAuras); hooksecurefunc(FocusFrame,"UpdateAuras",ReleaseAllAuras);   local function SpellBar_SetPoint(self)     local meta=getmetatable(self).__index;--    Calls through self will trigger our hook, so we're making them through the metatable     meta.ClearAllPoints(self);     meta.SetPoint(self,"TOPLEFT",meta.GetParent(self),"BOTTOMLEFT",43,-28); end   hooksecurefunc(TargetFrame.spellbar,"SetPoint",SpellBar_SetPoint); hooksecurefunc(FocusFrame.spellbar,"SetPoint",SpellBar_SetPoint);

Thanks a lot! I'm going to update my file with your code

[Keysunao]

Hey!

For some reason this code is not working for me.
I put it in the .lua file of my self-made addon. But the code prevents the addon from loading (also the other lines wont load).

Can you maybe help?
I basically only want to remove the debuffs/buffs on the Focus Frame.

Thanks a lot!

[Deadlyz]

Originally Posted by Keysunao Hey! For some reason this code is not working for me. I put it in the .lua file of my self-made addon. But the code prevents the addon from loading (also the other lines wont load). Can you maybe help? I basically only want to remove the debuffs/buffs on the Focus Frame. Thanks a lot!

Try hiding it with MoveIt

P.S.: the code works perfectly for me.

[Odjur]

Thought I'd comment because this may be a lower cost method:

FocusFrame:UnregisterEvent("UNIT_AURA")
 
hooksecurefunc(FocusFrame, "SetSmallSize", function(self)
    self.maxBuffs = 0
    self.maxDebuffs = 0
end)

I believe SetSmallSize is the function that establishes the buff/debuff limits, so this should be a one time setup.

[ironmoney]

Originally Posted by Odjur Thought I'd comment because this may be a lower cost method: FocusFrame:UnregisterEvent("UNIT_AURA")   hooksecurefunc(FocusFrame, "SetSmallSize", function(self)     self.maxBuffs = 0     self.maxDebuffs = 0 end) I believe SetSmallSize is the function that establishes the buff/debuff limits, so this should be a one time setup.

very nice, thanks. do you know how to make it work with large frames enables?

[Adaseth]

Hi guys, sorry for the noob question but where do you enter this code? I've been searching how to remove this forever but even with MoveIt i can't really get it right.

Thanks in advance!