Quantcast Missing Frames, Events and Functions in Battle For Azeroth - WoWInterface
Thread Tools Display Modes
04-20-18, 08:01 AM   #1
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,236
Missing Frames, Events and Functions in Battle For Azeroth

Granted this is from a quick nUI test, but I had got it working for Legion Beta, so assume these were changed in Battle For Azeroth. nUI on Login resulted in 33 unique error messages, some were these events, others what appeared to be Blizzard functions and the rest nUI functions.

Events:
>Attempt to register unknown event "PLAYER_AURAS_CHANGED"
>Attempt to register unknown event "UNIT_AURA_STATE"
>Attempt to register unknown event "UNIT_SPELLCAST_SPELLMISS"
>Attempt to register unknown event "PARTY_MEMBERS_CHANGED"
>Attempt to register unknown event "UNIT_COMBO_POINTS"
>Attempt to register unknown event "UNIT_PVP_UPDATE"
>Attempt to register unknown event "RUNE_TYPE_UPDATE"
>Attempt to register unknown event "UPDATE_WORLD_STATES"

Functions (assumed Blizzard Functions not nUI) :
>attempt to index global 'BattlefieldMinimap' (a nil value)
>attempt to call upvalue 'GetPlayerMapPosition' (a nil value)

Frames (assumed Blizzard Frames not nUI) :
>Couldn't find inherited node: SecureFrame


This is an event that flagged up as missing when testing my mage portals addon
>Attempt to register unknown event "PARTY_CONVERTED_TO_RAID"


These came up while logging in with Titan Panel ( and its built in modules activated ) so I could test my Alt ILevel Addon
>Attempt to register unknown event "MINIMAP_ZONE_CHANGED"
>Attempt to register unknown event "PARTY_MEMBERS_CHANGED" ---- Same as above
>attempt to index global 'WorldStateAlwaysUpFrame' (a nil value)

And my Alt ILevel addon came up with this one
>Attempt to register unknown event "PLAYER_AVG_ITEM_LEVEL_READY"
__________________

Last edited by Xrystal : 04-21-18 at 06:19 PM. Reason: Added more items
  Reply With Quote
04-20-18, 08:54 AM   #2
bsmorgan
A Flamescale Wyrmkin
AddOn Author - Click to view addons
Join Date: Mar 2005
Posts: 146
Add events that can't be registered for:
  • TRADE_SKILL_FILTER_UPDATE
  • SPELL_NAME_UPDATE (although this one never fired in a released version)
  Reply With Quote
04-20-18, 03:48 PM   #3
Fizzlemizz
I did that?
 
Fizzlemizz's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Dec 2011
Posts: 923
It looks like they've taken the rank returns out of functions like UnitBuff, UnitDebuff, UnitCastingInfo, UnitChannelInfo.
__________________
Fizzlemizz
Maintainer of Discord Unit Frames and Discord Art.
Author of FauxMazzle and Move Pad Plus.

Last edited by Fizzlemizz : 04-20-18 at 04:13 PM.
  Reply With Quote
04-20-18, 04:57 PM   #4
Aftermathhqt
A Molten Giant
 
Aftermathhqt's Avatar
AddOn Author - Click to view addons
Join Date: Dec 2009
Posts: 780
  • GetPetActionInfo -- 1 arg removed
  • KNOWN_CURRENCY_TYPES_UPDATE -- Removed?
  • PET_BAR_HIDE -- Removed?
  • UNIT_POWER > UNIT_POWER_UPDATE
  Reply With Quote
04-20-18, 08:15 PM   #5
Zensunim
A Defias Bandit
AddOn Author - Click to view addons
Join Date: Sep 2010
Posts: 3
COMBAT_LOG_EVENT_UNFILTERED seems to be returning nothing back.

Looks like you have to use CombatLogGetCurrentEventInfo() instead.

Last edited by Zensunim : 04-20-18 at 08:27 PM.
  Reply With Quote
04-20-18, 10:49 PM   #6
Fizzlemizz
I did that?
 
Fizzlemizz's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Dec 2011
Posts: 923
More information
__________________
Fizzlemizz
Maintainer of Discord Unit Frames and Discord Art.
Author of FauxMazzle and Move Pad Plus.
  Reply With Quote
04-21-18, 06:01 AM   #7
Voxxel
A Chromatic Dragonspawn
Join Date: Mar 2009
Posts: 169
Does anyone know what's the BfA replacement for "QuestLogQuests_GetTitleButton" function?
  Reply With Quote
04-21-18, 10:25 AM   #8
VincentSDSH
Non-Canadian Luzer!
 
VincentSDSH's Avatar
AddOn Author - Click to view addons
Join Date: Jun 2006
Posts: 345
Are the documentation .lua files up to date? I ask because they document several functions that, when called, don't seem to exist.

And anyone know of an up-to-date Removed/Name_Changed/Similar API comparison? The map/location related ones are killing me atm.
__________________
AddonsExecutive Assistant User Configurable To-Do ListLegible Mail Choose the Font for Your Mail
  Reply With Quote
04-21-18, 02:07 PM   #9
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,236
Originally Posted by VincentSDSH View Post
Are the documentation .lua files up to date? I ask because they document several functions that, when called, don't seem to exist.

And anyone know of an up-to-date Removed/Name_Changed/Similar API comparison? The map/location related ones are killing me atm.
I think Ellypse's wow-ui-source files on github have been updated 2 days ago, coinciding with the last update.

https://github.com/Ellypse/wow-ui-source/branches

And the link Fizzlemizz posted has some additional notes on what they have found to be changed.

Comparing the same files between versions will hopefully highlight event and function name changes.
__________________
  Reply With Quote
04-21-18, 02:27 PM   #10
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,236
Originally Posted by Voxxel View Post
Does anyone know what's the BfA replacement for "QuestLogQuests_GetTitleButton" function?
It appears they changed how the Quest Buttons are created. There is now the following function that looks to be the nearest to what the old one did and more.

Code:
function QuestLogQuests_AddQuestButton(prevButton, questLogIndex, poiTable, title, level, suggestedGroup, isHeader, isCollapsed, isComplete, frequency, questID, startEvent, displayQuestID, isOnMap, hasLocalPOI, isTask, isBounty, isStory, isHidden, isScaling, layoutIndex)
It takes up lines 488 to 660 and looks to be what you have to use now ..


Here is a portion of the Legion QuestMapFrame.lua file that has the function you are talking about.

Code:
	if (not headerCollapsed) then
		local totalHeight = 8;
		titleIndex = titleIndex + 1;
		button = QuestLogQuests_GetTitleButton(titleIndex);
		button.questID = questID;
                ....... A ton of lines setting the button up .... 
                prevButton = button;
       end
And this is the same part in the BfA version of the same file.

Code:
if (not headerCollapsed or C_CampaignInfo.IsCampaignQuest(questID)) then
	local layoutKey = "Other";
	if (C_CampaignInfo.IsCampaignQuest(questID)) then
		layoutKey = "Campaign";
	end
	prevButton = QuestLogQuests_AddQuestButton(prevButton, questLogIndex, poiTable, title, level, 
       suggestedGroup, isHeader, isCollapsed, isComplete, frequency, questID, startEvent, displayQuestID, 
       isOnMap, hasLocalPOI, isTask, isBounty, isStory, isHidden, isScaling, 
       QuestMapFrame:GetManagedLayoutIndex(layoutKey));
end
__________________
  Reply With Quote
04-22-18, 11:54 AM   #11
p3lim
A Pyroguard Emberseer
 
p3lim's Avatar
AddOn Author - Click to view addons
Join Date: Feb 2007
Posts: 1,669
oUF will have a PR dedicated to the expansion, containing unitframe-related changes:
https://github.com/oUF-wow/oUF/pull/434
  Reply With Quote
04-22-18, 03:40 PM   #12
Voxxel
A Chromatic Dragonspawn
Join Date: Mar 2009
Posts: 169
Thank you, Xrystal!
  Reply With Quote
04-24-18, 04:05 AM   #13
Ellypse
Storyline and TRP dev.
 
Ellypse's Avatar
AddOn Author - Click to view addons
Join Date: Aug 2014
Posts: 9
Thank you Fizzlemizz and Xrystal for linking to my observations and my GitHub

Please note that I have also started updating the API changes article on Wowpedia with the things I am able to test and confirm in-game. If you can, please consider participating in this article to gather all the changes.
  Reply With Quote
04-24-18, 02:12 PM   #14
thomasjohnshannon
A Theradrim Guardian
 
thomasjohnshannon's Avatar
AddOn Author - Click to view addons
Join Date: Sep 2009
Posts: 60
Blue post with changes went up today.
__________________
Thomas aka Urnn
  Reply With Quote
04-24-18, 03:58 PM   #15
JDoubleU00
An Onyxian Warder
 
JDoubleU00's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2008
Posts: 356
Originally Posted by thomasjohnshannon View Post
Blue post with changes went up today.
Wow (no pun intended), would it be easier to list what isn't changing?
__________________
Author of JWExpBar and JWRepBar.
  Reply With Quote
04-24-18, 05:03 PM   #16
Nevcairiel
Premium Member
Premium Member
AddOn Author - Click to view addons
Join Date: Aug 2006
Posts: 60
The changes are really not that bad. Most come down to removing the spell rank from all sorts of places and in some cases also going away from spell name in favor of spellID. All of those are relatively easy to fix.

The Map is the area which really breaks a lot, though.
  Reply With Quote
04-24-18, 06:33 PM   #17
Vrul
A Frostmaul Preserver
 
Vrul's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2007
Posts: 289
Originally Posted by Nevcairiel View Post
in some cases also going away from spell name in favor of spellID
Does anyone know if you can /cast a spell with a spellID instead of a spellName with Beta?

Also, could anyone tell me if IsHarmfulSpell and IsHelpfulSpell take spellID again or still just spellName?
  Reply With Quote
04-24-18, 08:58 PM   #18
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,236
Originally Posted by Vrul View Post
Does anyone know if you can /cast a spell with a spellID instead of a spellName with Beta?

Also, could anyone tell me if IsHarmfulSpell and IsHelpfulSpell take spellID again or still just spellName?
Looks like you still have to use SpellName to get access to that information at the moment. Just tested it.

What is interesting is that the following code block
Code:
    GameTooltip:AddLine(IsHarmfulSpell(spellName) or "Helpful",1.0,1.0,1.0)
    GameTooltip:AddLine(IsHelpfulSpell(spellName) or "Harmful",1.0,1.0,1.0)
Resulted in Helpful in all cases except for the spells I didn't know/have in my spellbook, or were party specific spells - AKA Portals. Those returned both settings.
__________________

Last edited by Xrystal : 04-24-18 at 09:01 PM.
  Reply With Quote
04-25-18, 08:33 AM   #19
sezz
A Flamescale Wyrmkin
AddOn Author - Click to view addons
Join Date: Apr 2008
Posts: 100
RegisterUnitEvent seems bugged, simple test code:

Lua Code:
  1. /run local f = CreateFrame("Frame");f:RegisterUnitEvent("UNIT_POWER_BAR_HIDE", "player");print(f:IsEventRegistered("UNIT_POWER_BAR_HIDE"));

IsEventRegistered return values on Live: true player
IsEventRegistered return values on Beta (26491): true

I don't know if it has been like this in the previous builds aswell, just stumbled upon it when updating some addons.
  Reply With Quote
04-25-18, 09:25 AM   #20
Rilgamon
Premium Member
 
Rilgamon's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Sep 2009
Posts: 716
Is an invite required? I just installed beta and logged in.
__________________
The cataclysm broke the world ... and the pandas could not fix it!
  Reply With Quote

WoWInterface » PTR » PTR API and Graphics Changes » Missing Frames, Events and Functions in Battle For Azeroth

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off