Making interactive Personal Resource Display

[Pubert]

Hiya complete beginner with addons as well as posting on forums so bear with me on this one!
I'd made a weakaura to display more information about my character than plater allows and match the nameplates I have installed visually and messed around trying to add Togglemenu functionality to it so I could do away with unit frames entirely and conserve UI space.

I realize it's bad practice to add secure actions to a weakaura so I wrote a lil' addon for that process instead

local function MoveStuff()
    local healthButton = CreateFrame("BUTTON","healthButton", YOUR_FRAME, "SecureActionButtonTemplate");
    healthButton:SetPoint("CENTER", C_NamePlate.GetNamePlateForUnit("player"), "CENTER", 0, 0)
    healthButton:SetSize(130, 40)
    healthButton:RegisterForClicks('AnyUp')
    healthButton:SetAttribute('unit', 'player')
    healthButton:SetAttribute('*type1', 'target')
    healthButton:SetAttribute('*type2', 'togglemenu')
end

local f = CreateFrame('Frame')
f:RegisterEvent('UPDATE_MOUSEOVER_UNIT')
f:SetScript('OnEvent', MoveStuff)

It works fine but has a quirk, I tried setting the Event it registers to PLAYER_ENTERING_WORLD but that seemed to be too early for the code to register the location of NamePlateForUnit("player"), therefore slapping it on the center of my screen instead. So I then tried putting it on SPELLS_CHANGED and I got it to work, I could right click my personal resource display and get the toggle menu, but it kept making two frames, one placed squarely at the center of my screen and the other on the desired nameplate so eventually I landed on UPDATE_MOUSEOVER_UNIT, which works! No frame at the center of my screen.

But if my character dies or seemingly at random points, the frame at the center reappears which I assume is down to the addon persisting to make these frames and the location of the nameplate not being available at all times, is there something I can do to fix this? A better event to check? I'm lost.

[SDPhantom]

Originally Posted by Pubert I realize it's bad practice to add secure actions to a weakaura so I wrote a lil' addon for that process instead

To be clear, there's a big difference between "bad practice" and "will not work" or "sometimes works with disastrous side effects". Dealing with secure/protected actions most often falls under the later categories.

Making this idea work isn't completely impossible, though we'll need to take advantage of a quirk with how NamePlates are set up.

local HookedUnitFrames={};
 
local function HookUnitFrame(unitframe)
    if InCombatLockdown() then return false; end--  Signal we can't create the frame now
 
    local clickframe=CreateFrame("Button",nil,unitframe,"SecureUnitButtonTemplate");
    clickframe:SetAllPoints(unitframe);
    clickframe:RegisterForClicks("AnyUp");
    clickframe:SetAttribute("useparent-unit",true);--   Defer to UnitFrame's unit attribute
    clickframe:SetAttribute("*type1","target");
    clickframe:SetAttribute("*type2","togglemenu");
    return true;--  We created the frame
end
 
hooksecurefunc(NamePlateDriverFrame,"AcquireUnitFrame",function(base)
--  Exit early if forbidden or we've already encountered the frame
    if base:IsForbidden() or HookedUnitFrames[base.UnitFrame]~=nil then return; end
    HookedUnitFrames[base.UnitFrame]=HookUnitFrame(base.UnitFrame);--   Attempt hook and store success flag (fail registers for retry)
end);
 
EventRegistry:RegisterFrameEventAndCallback("PLAYER_REGEN_ENABLED",function()
    for unitframe,hooked in pairs(HookedUnitFrames) do
--      Retry hook if failed and update flag
        if not hooked then HookedUnitFrames[unitframe]=HookUnitFrame(unitframe); end
    end
end);

First, we hook NamePlateDriverFrame:AcquireUnitFrame() to attach our "clickframe" to. What the original function does is grab a CompactUnitFrame from a frame pool and attach it to the NamePlate. Note while the code names it NamePlateDriverMixin, this table is already loaded into NamePlateDriverFrame by the time our code runs. Hooking the function from NamePlateDriverMixin will essentially do nothing useful.

What we do is access that CompactUnitFrame and attach our SecureUnitButton to it. This lets us access a feature of the secure templates to refer to their parent for one or more attributes. SecureUnitButton was swapped in for its special handling of spell target cursors. Notably, it cancels spell targeting if the action is to bring up a menu.

Coincidentally, CompactUnitFrames are set with their own unit attribute, so we point to that by setting our "useparent-unit" to true. Note "useparent-" is the keyword and the "unit" suffix tells it which attribute to act on. Similarly, you can define "useparent*" to defer all undefined attributes to the parent.

A side effect to this approach is we can't control which NamePlates get our "clickframes". They all will. I also created a fallback for NamePlates that are created while in combat. Since we can't manipulate them during lockdown, we delay it until we're no longer in combat.

Last to note is use of the new EventRegistry, extending CallbackRegistry.

[Pubert]

Can't seem to get your suggestion to work for me, only got it working once while keeping two units in my line of sight, entering combat with one and not the other but I haven't been able to recreate it and it ends up putting default blizzard nameplates visibly behind my plater nameplates, thanks anyway though, will incorporate a combatlockdown check.

Edit: Bashed my head at it some more and came up with something resembling what I'm going for, the only issue remaining is new entities running off with a click frame that belongs to me, but it doesn't get rid of my own which is good. I realize it lacks elegance, decorum and grace but yeah

personalRessourceDisplayFrame = CreateFrame("Frame", UIParent);
personalRessourceDisplayFrame:Hide();
personalRessourceDisplayFrame.attachedVisibleFrames = {};
personalRessourceDisplayFrame = personalRessourceDisplayFrame;
personalRessourceDisplayFrame:RegisterEvent("NAME_PLATE_UNIT_ADDED")
personalRessourceDisplayFrame:RegisterEvent("NAME_PLATE_UNIT_REMOVED")
 
local function MoveStuff()
    local frame = C_NamePlate.GetNamePlateForUnit("player");
    if InCombatLockdown() then return false; end
    if (frame) then
        if (Plater and frame.unitFrame.PlaterOnScreen) then
            local healthButton = CreateFrame("BUTTON","healthButton", YOUR_FRAME, "SecureActionButtonTemplate");
            ignoreFramePositionManager = true
            healthButton:SetPoint("CENTER", C_NamePlate.GetNamePlateForUnit("player"), "CENTER", 0, 0)
            healthButton:SetSize(130, 40)
            healthButton:RegisterForClicks('AnyUp')
            healthButton:SetAttribute('unit', 'player')
            healthButton:SetAttribute('*type1', 'target')
            healthButton:SetAttribute('*type2', 'togglemenu')
            healthButton:GetAttribute("parent-unit")
        end
    end
end
personalRessourceDisplayFrame.eventHandler = function(self, event, nameplate)
    StartProfileSystem("prd");
    if (event == "NAME_PLATE_UNIT_ADDED") then
        if (UnitIsUnit(nameplate, "player")) then
            local frame = C_NamePlate.GetNamePlateForUnit("player");
            if (frame) then 
                if (Plater and frame.unitFrame.PlaterOnScreen) then
                    healthButton:Attach(frame, frame.unitFrame.healthBar, frame.unitFrame.powerBar);
                else
                    heatlhButton:ClearAllPoints();
                    healthButton:Detach();
                    healthButton:Hide();
                end
            end
            
        elseif (event == "NAME_PLATE_UNIT_REMOVED") then
            if (UnitIsUnit(nameplate, "player")) then
                healthButton:ClearAllPoints();
                healthButton:Detach();
                healthButton:Hide();
            end
        end
    end
    StopProfileSystem("prd");
    
    
end
 
local f = CreateFrame('Frame')
f:RegisterEvent('UPDATE_MOUSEOVER_UNIT')
f:SetScript('OnEvent', MoveStuff)

The reason I set the unit attribute specifically to "Player" is because I am also tracking my target, pet and targettarget on the PRD but writing those in separate addons with nigh identical code save for X and Y values and the Unit attribute on healthButton.

[Pubert]

Double post, ceased to work. Was janky anyway