Thread Tools Display Modes
07-06-11, 03:33 AM   #1
Belechannas
A Warpwood Thunder Caller
Join Date: May 2010
Posts: 86
InfoPanel_Stats pet issue

It appears that the logic of InfoPanel_Stats plugin does not handle death of a pet correctly. When my pet dies in combat, the plugin gets stuck in Omen (combat) mode even after combat is over.

From debugging printout I added, it appears the plugin gets the events like this:

PET_ATTACK_START
PLAYER_REGEN_DISABLED
<plugin switches to Omen display>
<pet dies>
<combat ends>
PLAYER_REGEN_ENABLED
<plugin remains in Omen display>

The display continues to show Omen until you leave combat with a live pet, or reload the UI.

If the pet doesn't die, then PET_ATTACK_STOP is received at the same time as PLAYER_REGEN_ENABLED, and the display switches back to Recount.

I'm not very familiar with combat-related events; is there an easy way to handle this properly?
 
07-06-11, 06:34 AM   #2
spiel2001
nUI's Author
 
spiel2001's Avatar
AddOn Author - Click to view addons
Join Date: Jun 2008
Posts: 7,724
It looks like there's a new taint. I'll have to figure out what it is an address it.
__________________

What people don't get is that I am, ultimately, an artist at heart.
My brush has two colors, 1 and 0, and my canvas is made of silicon.



Official nUI Web Site: http://www.nUIaddon.com
Official nUI Support Forum: http://forums.nUIaddon.com
My day job: http://www.presidio.com/
 
07-06-11, 10:15 AM   #3
Belechannas
A Warpwood Thunder Caller
Join Date: May 2010
Posts: 86
You think this is due to taint? I could be wrong, of course, but it looked to me more like the code not anticipating an infrequently occurring corner case.
 
07-06-11, 11:49 AM   #4
spiel2001
nUI's Author
 
spiel2001's Avatar
AddOn Author - Click to view addons
Join Date: Jun 2008
Posts: 7,724
PLAYER_REGEN_ENABLED should have triggered the change back regardless of pet status. So either a taint blocked it or I missed something. I'll look at it.
__________________

What people don't get is that I am, ultimately, an artist at heart.
My brush has two colors, 1 and 0, and my canvas is made of silicon.



Official nUI Web Site: http://www.nUIaddon.com
Official nUI Support Forum: http://forums.nUIaddon.com
My day job: http://www.presidio.com/
 
 

WoWInterface » Featured Projects » nUI, MozzFullWorldMap and PartySpotter » Customization » nUI: Plugin Support » InfoPanel_Stats pet issue

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off