Some code not working

[Soeters]

I'm trying to make an addon that prints how many you need to be at the next reputation level and to be exalted.
I've written some code, using AceAddon, AceConsole, AceLocale and LibStub.

Here's my code

When I log in nothing seems to happen but the addon is marked as loaded when I print the addon list. The slash commands aren't working too.


I've tested many things but even the OnInitialize() doesn't seem to work.
If someone can help me with that problem that would be very kind.

[Mera]

first error I see is

local Thesaurus =

Thesaurus should be global for Ace3 to access it

you could write it

Thesaurus =

or

local Thesaurus = ..;
Thesaurus = Thesaurus -- define global Thesaurus to be local Thesaurus

[Soeters]

That's true but even when Thesaurus was a global that didn't worked.

[Slakah]

Originally Posted by Mera first error I see is local Thesaurus = Thesaurus should be global for Ace3 to access it you could write it Thesaurus = or local Thesaurus = ..; Thesaurus = Thesaurus -- define global Thesaurus to be local Thesaurus

I don't think thats it, iirc Ace3 wont require it to be global, as it will keep a reference to your addon object, and it wouldn't make any sense for it to require a global reference.


Anyway, back to your problem. If you are using that code you posted, then you should be getting an error about all your :Print() calls missing a ")".

[Soeters]

I use that coded (modified now) but I didn't get any error (maybe that a conflict with o****)

[Slakah]

Originally Posted by Soeters I use that coded (modified now) but I didn't get any error (maybe that a conflict with o****)

If you use OnEnable instead of OnInitialize you'll probably get the error report.

It'll be due to o**** being loaded before your mod.

[Mera]

well if you look at most of Ace2/Ace3 codes they all declare the global variables that is not for cosmetics because without how Ace3 could guess your mod:OnInitialize if mod is local..

[Slakah]

Originally Posted by Mera well if you look at most of Ace2/Ace3 codes they all declare the global variables that is not for cosmetics because without how Ace3 could guess your mod:OnInitialize if mod is local..

Because it stores the addon object it supplys you with when you do ":NewAddon()" in "AceAddon.addons"

[Torhal]

Originally Posted by Mera well if you look at most of Ace2/Ace3 codes they all declare the global variables that is not for cosmetics because without how Ace3 could guess your mod:OnInitialize if mod is local..

I notice you said most, which invalidates what you say afterward - if it were true, all Ace-based addons would require it. In Revelation, I do this:

local Revelation = LibStub("AceAddon-3.0"):NewAddon(NAME, "AceHook-3.0")

...and never do anything like this:

_G["Revelation"] = Revelation

...though that certainly wouldn't really hurt anything, unless another addon has done it before I did and would break because of it.

The reason it doesn't need to be global is that the addon object is defined as an AceAddon object, with all of the OnInitialize()/OnEnable()/OnDisable()/etc and the handling those entail built-in.

[Soeters]

Now I've fixed almost everything but there is still one error.

Everytime I do /ths faction kirin (ou other faction name but kirin is the easiest) I got this error

Interface/AddOns/Thesaurus:core.lua:140: attempt to concatenate global 'current' (a nil value)

And I don't know why but maybe I should use string.format instead of AceConsole's Print(...)

Edit: The current code

[Seerah]

I had to look for the variable current because it's no longer on 140 - it's on 142.

Anyway, you have problems with variable scope. You're looking for the variable current, but when you try to call it there, it is undefined. This is because you defined it as a local variable, local only to the if block it originally is declared in. Put:

local current

at the top of your file and remove the local from before it at line 84. That way, it will still be a local variable (instead of a global), but it will be local to your entire lua file, not just a specific block.

[Soeters]

Thanks a lot that works well now

[Mera]

indeed i tested global/local doesnt change so you can put back locla Thesaurus sorry, better to think local than global unless you need to call a Thesaurus:Function() from the chat command line for debugging purpose for example, when global is really needed