Frame positioning problem when using latest oUF

drakull · 10-13-10, 07:25 AM

I just updated to the latest oUF 1.4.3 from the github, and now all my frames are really screwed.

Before updating oUF:

After:

Here is the player's frame code:

Code:

if cfg.showplayer then
    oUF:RegisterStyle("oUF_DrkPlayer", CreatePlayerStyle)
    oUF:SetActiveStyle("oUF_DrkPlayer")
    oUF:Spawn("player", "oUF_Drk_PlayerFrame"):SetPoint("TOPRIGHT",UIParent,"BOTTOM", -210, 292)
  end

  local function CreatePlayerStyle(self)
    self.width = 250
    self.height = 60
    self.mystyle = "player"
    lib.init(self)
  end

  lib.init = function(f)
    f:SetAttribute("initial-height", f.height)
    f:SetAttribute("initial-width", f.width)
    f:SetAttribute("initial-scale", f.scale)
    f:SetPoint("CENTER",UIParent,"CENTER",0,0)
    f.menu = lib.menu
    f:RegisterForClicks("AnyUp")
    f:SetAttribute("*type2", "menu")
    f:SetScript("OnEnter", UnitFrame_OnEnter)
    f:SetScript("OnLeave", UnitFrame_OnLeave)
  end

I just noted that i use SetPoint twice for each frame (in oUF:Spawn and inside the init func), but it aways worked fine with previous versions of oUF.
I tried commenting the generic SetPoint inside the init function but it just got worse, now i have no visible frames at all.

Any insight would be very helpful, I'm kind of lost right now.

Rostok · 10-13-10, 01:00 PM

There's nothing in the code you posted that have sthg to do with the placement of the health bar/power bar/portrait bar.
You should pastey the whole code or tell us where we can find it if you want some help

drakull · 10-13-10, 01:18 PM

Originally Posted by Rostok

There's nothing in the code you posted that have sthg to do with the placement of the health bar/power bar/portrait bar.
You should pastey the whole code or tell us where we can find it if you want some help

Code:

oUF:Spawn("player", "oUF_Drk_PlayerFrame"):SetPoint("TOPRIGHT",UIParent,"BOTTOM", -210, 292)

Well, i'm no LUA expert but I'm pretty sure the code above sets the playerframe position. The "CreatePlayerStyle" function listed in the OP sets it's size and height.
This also defines the "clicable" and "hover" area of the frame and this area simply does not exists when using the last version of oUF. I moved my mouse the entire screen and did not find it... it should at least activate the player tooltip but i get nothing.
The Healthbar, the powerbar and the portrait are all placed using the frame's position and size. The following is the code for the healthbar:

Code:

  lib.gen_hpbar = function(f)
    -- healthbar
    local s = CreateFrame("StatusBar", nil, f)
    s:SetStatusBarTexture(cfg.statusbar_texture)
    s:GetStatusBarTexture():SetHorizTile(true)
    s:SetHeight(40)
    s:SetWidth(f.width)
    s:SetPoint("TOP",0,0)
    -- helper
    local h = CreateFrame("Frame", nil, s)
    h:SetFrameLevel(0)
    h:SetPoint("TOPLEFT",-5,5)
    h:SetPoint("BOTTOMRIGHT",5,-5)
    lib.gen_backdrop(h)
    --bg
    local b = s:CreateTexture(nil, "BACKGROUND")
    b:SetTexture(cfg.statusbar_texture)
    b:SetAllPoints(s)
	f.Health = s
    f.Health.bg = b
  end

"f" is the playerframe.

If you still want to see the whole code, you can download it here.

Rostok · 10-13-10, 05:09 PM

Like i said earlier, that's not the playerframe position the problem here, that's the different statusbars position.
I downloaded your layout, and first you shouldn't include oUF in your package.
oUF 1.4.3 is not fully compatible with the new patch, oUF 1.5.x is required here.
And with that, you must make your layout 1.5.x ready.

drakull · 10-13-10, 05:53 PM

Still i have no real clue about what's causing the frames behave like that... anyway, Haste just released oUF 1.5.2 and, as u said, i should (and will) start working with it now.

And oUF 1.4.3 was included in my layout because the version available at wowinteface at the time did not had support for HolyPower/SoulShards.

Thanks for your thoughts!

inopua · 10-13-10, 08:06 PM

I have the same issue with my layout even in 1.5.2 :/

drakull · 10-14-10, 04:20 AM

Originally Posted by inopua

I have the same issue with my layout even in 1.5.2 :/

I got it... oUF 1.4.3 from github was, in fact, oUF 1.5.X for quite some time. As I was unaware of it I never tried looking into that "API Version 5: changes..." topic. It covers this problem.