Trying my hand at ouf - Page 2

Phanx · 12-24-13, 01:03 AM

Originally Posted by 10leej

Awesome saves me the trouble of finding an arena partner and a raid group, lmao

It may not work for raid frames if you're using group headers.

Originally Posted by 10leej

Looks like eclipse bar is still a little bugged, shows on the focus and target frame using the script Phanx provided.

Check your code... you're adding the eclipse bar for all units, instead of only for the player unit.

10leej · 12-24-13, 01:17 AM

Check your code... you're adding the eclipse bar for all units, instead of only for the player unit.

Phanx · 12-24-13, 01:43 AM

I like how I've infected everyone with meme-based communication today.

10leej · 12-24-13, 01:50 AM

Originally Posted by Phanx

I like how I've infected everyone with meme-based communication today.

It was gonna come from me one way or another.

Anyways any idea on how to flip the target frame around? Or do I just have to make that one special?

Phanx · 12-24-13, 02:07 AM

There's no magic "flip this thing around" function. You just have to anchor everything to the opposite side for that frame.

You don't seem to have updated your SVN code (you're still creating the eclipse bar, druid mana bars, totem bars, and rune bars for all units) but in general you can simplify the "flipping" process like this:

Code:

local reverseUnits = {
	target = true,
	targettarget = true,
}

local function Shared(self, unit, isSingle)
	unit = gsub(unit, "%d+", "")

	local LEFT = reverseUnits[unit] and "RIGHT" or "LEFT"
	local RIGHT = reverseUnits[unit] and "LEFT" or "RIGHT"

	-- bla bla bla

	HealthText:SetPoint(RIGHT, Health, -5, 0)

	HealthText2:SetPoint(LEFT, Health, 5, 0)

	Debuffs:SetPoint("TOP", self, "BOTTOM"..LEFT, -height, 0)

Stuff in green is not directly related, but you will want to add it, otherwise your party/raid styles won't work, since "unit" will be something like "party3" which doesn't match the "party" key in your UnitSpecific table.

On a side note, I've never really understood the appeal of splitting things out into a shared function + unit specific functions. Other than player-specific elements like totem bars etc. almost everything is going to have some commonality between units, so you're either duplicating code for no reason (by having nearly identical code in each unit function that differs only in, say, how it anchors the buffs to the frame) or you're splitting code up for no reason (for example, having some of the buff code in the shared function, and some in the unit functions). "if" checks are not the end of the world!

MoonWitch · 12-24-13, 03:54 PM

Originally Posted by Phanx

I like how I've infected everyone with meme-based communication today.

MoonWitch · 12-24-13, 03:59 PM

Originally Posted by Phanx

Other than player-specific elements like totem bars etc. almost everything is going to have some commonality between units, so you're either duplicating code for no reason (by having nearly identical code in each unit function that differs only in, say, how it anchors the buffs to the frame) or you're splitting code up for no reason (for example, having some of the buff code in the shared function, and some in the unit functions). "if" checks are not the end of the world!

That's where I constantly fall into conflict... Do I put this into "Shared" or "UnitSpecific".

Phanx · 12-24-13, 10:35 PM

Neither. The entire concept of "shared" vs "unit specific"is not even found in oUF. it's just some random idea Haste came up with and used in his layout. Just use a single spawn function, and wrap conditional things in "if" statements.

MoonWitch · 12-25-13, 12:12 AM

Originally Posted by Phanx

Neither. The entire concept of "shared" vs "unit specific"is not even found in oUF. it's just some random idea Haste came up with and used in his layout. Just use a single spawn function, and wrap conditional things in "if" statements.

You're kidding right??? This was -- random? ...

Phanx · 12-25-13, 05:30 AM

10leej · 12-25-13, 01:10 PM

Well it is a good idea imho. I might just break it all up and just run unit specific stuff for a bit more flexibility in the config options.

Phanx · 12-25-13, 09:25 PM

My point was simply that the concept is not a required part of writing an oUF layout, and did not even come from oUF itself. As long as you understand that it's simply an optional paradigm, feel free to use it if you like it.

10leej · 12-26-13, 04:10 AM

Originally Posted by Phanx

My point was simply that the concept is not a required part of writing an oUF layout, and did not even come from oUF itself. As long as you understand that it's simply an optional paradigm, feel free to use it if you like it.

Well after fiddling around I probably won't bother with it.

10leej · 12-26-13, 10:49 PM

Looks like that when I toss the druid ecplipse and druidmana bars into the unit specific the bars don't load at all.

This includes runes and totems as well.

Also my svn isn't updating for some reason /cry

code:

Lua Code:

local _, cfg = ... --import config
local addon, ns = ... --get addon namespace
 
-----------------------------
-- Add custom functions (overrides)
 function CreateBackdrop(frame)
    frame:SetBackdrop({bgFile = "Interface\\Buttons\\WHITE8x8", edgeFile = "Interface\\Buttons\\WHITE8x8", edgeSize = 2, 
        insets = {top = 2, left = 2, bottom = 2, right = 2}})
    frame:SetBackdropColor(0,0,0,.5)
    frame:SetBackdropBorderColor(0,0,0,1)
    frame:CreateBorder(12,1,1,1)
    frame:SetBorderPadding(1)
end
 
------------------------------------------------------------------------
-- UnitSpecific settings
------------------------------------------------------------------------
local UnitSpecific = {
    player = function(self)
        -- player specific stuff
        self:SetSize(cfg.width,cfg.height)
        
        -- 3D Portrait
        -- Position and size
        local Portrait = CreateFrame('PlayerModel', nil, self)
        Portrait:SetSize(cfg.height, cfg.height)
        Portrait:SetPoint('RIGHT', self, 'LEFT', -2,0)
        CreateBackdrop(Portrait)
        -- Register it with oUF
        self.Portrait = Portrait
        
        -----------------------------
        -- Runes
        local Runes = {}
        for index = 1, 6 do
            -- Position and size of the rune bar indicators
            local Rune = CreateFrame('StatusBar', nil, Power)
            Rune:SetSize(120 / 6, 20)
            Rune:SetPoint('TOPLEFT', Power, 'BOTTOMLEFT', index * 120 / 6 - 20, 0)
            Rune:CreateBorder(10,1,1,1)
            Rune:SetBorderPadding(1)
            Rune:SetStatusBarTexture(cfg.statusbar_texture)
            CreateBackdrop(Rune)
    
            Runes[index] = Rune
        end
        -- Register with oUF
        self.Runes = Runes
        
        -----------------------------
        -- Eclipse Bar
        local EclipseBar = CreateFrame("Frame", nil, self)
        EclipseBar:SetPoint("TOP", Power, "BOTTOM", 0, -2) -- are you sure you want this overlapping your power bar by 2px?
        EclipseBar:SetSize(cfg.width, 15)
        self.EclipseBar = EclipseBar
        
        local LunarBar = CreateFrame("StatusBar", nil, EclipseBar)
        LunarBar:SetPoint("LEFT")
        LunarBar:SetSize(cfg.width, 15)
        LunarBar:SetStatusBarTexture(cfg.statusbar_texture)
        LunarBar:CreateBorder(12,1,1,1)
        LunarBar:SetBorderPadding(1)
        EclipseBar.LunarBar = LunarBar
        
        local SolarBar = CreateFrame("StatusBar", nil, EclipseBar)
        SolarBar:SetPoint("LEFT", LunarBar:GetStatusBarTexture(), "RIGHT")
        SolarBar:SetSize(cfg.width, 15)
        EclipseBar.SolarBar = SolarBar
        
        -----------------------------
        -- Druid Mana
        -- Position and size
        local DruidMana = CreateFrame('StatusBar', nil, Power)
        DruidMana:SetSize(20, 20)
        DruidMana:SetPoint('TOP',Power,'BOTTOM',0,-2)
        DruidMana:SetPoint('LEFT')
        DruidMana:SetPoint('RIGHT')
        DruidMana:CreateBorder(8,1,1,1)
        DruidMana:SetBorderPadding(1)
        -- Add a background
        local Background = DruidMana:CreateTexture(nil, 'BACKGROUND')
        Background:SetAllPoints(DruidMana)
        Background:SetTexture(0, 0, 0, .5)
        -- Register it with oUF
        self.DruidMana = DruidMana
        self.DruidMana.bg = Background
        
        -----------------------------
        -- Totems
        local Totems = {}
        for index = 1, MAX_TOTEMS do
            -- Position and size of the totem indicator
            local Totem = CreateFrame('Button', nil, self)
            Totem:SetSize(40, 40)
            Totem:SetPoint('TOPLEFT', Power, 'BOTTOMLEFT', index * Totem:GetWidth(), 0)
            local Icon = Totem:CreateTexture(nil, "OVERLAY")
            Icon:SetAllPoints()
            local Cooldown = CreateFrame("Cooldown", nil, Totem)
            Cooldown:SetAllPoints()
        
            Totem.Icon = Icon
            Totem.Cooldown = Cooldown
            Totems[index] = Totem
        end
   
        -- Register with oUF
        self.Totems = Totems
        
        -----------------------------
        -- Castbar
        -- Position and size
        local Castbar = CreateFrame("StatusBar", nil, self)
        Castbar:SetSize(200, 20)
        Castbar:SetStatusBarTexture(cfg.statusbar_texture)
        Castbar:SetPoint('CENTER',UIParent,0,-140)
        Castbar:CreateBorder(12,1,1,1)
        Castbar:SetBorderPadding(1)
   
        -- Add a background
        local Background = Castbar:CreateTexture(nil, 'BACKGROUND')
        Background:SetTexture(TEXTURE)
        Background:SetAllPoints(Castbar)
        Background:SetTexture(0, 0, 0, .5)
   
        -- Add a spark
        local Spark = Castbar:CreateTexture(nil, "OVERLAY")
        Spark:SetSize(20, 10)
        Spark:SetBlendMode("ADD")
   
        -- Add a timer
        local Time = Castbar:CreateFontString(nil, "OVERLAY", "GameFontNormalSmall")
        Time:SetPoint("RIGHT", Castbar, -3, 1)
   
        -- Add spell text
        local Text = Castbar:CreateFontString(nil, "OVERLAY", "GameFontNormalSmall")
        Text:SetPoint("LEFT", Castbar, 3, 1)
   
        -- Add Shield
        local Shield = Castbar:CreateTexture(nil, "OVERLAY")
        Shield:SetSize(20, 10)
        Shield:SetPoint("CENTER", Castbar)
   
        -- Add safezone
        local SafeZone = Castbar:CreateTexture(nil, "OVERLAY")
   
        -- Register it with oUF
        self.Castbar = Castbar
        self.Castbar.bg = Background
        self.Castbar.Spark = Spark
        self.Castbar.Time = Time
        self.Castbar.Text = Text
        self.Castbar.SafeZone = SafeZone
        
    end,
    target = function(self)
        -- target specific stuff
        self:SetSize(cfg.width,cfg.height)
        
        -- 3D Portrait
        -- Position and size
        local Portrait = CreateFrame('PlayerModel', nil, self)
        Portrait:SetSize(cfg.height, cfg.height)
        Portrait:SetPoint('LEFT', self, 'RIGHT', 2,0)
        CreateBackdrop(Portrait)
        -- Register it with oUF
        self.Portrait = Portrait
    
        -----------------------------
        -- Castbar
        -- Position and size
        local Castbar = CreateFrame("StatusBar", nil, self)
        Castbar:SetSize(200, 20)
        Castbar:SetStatusBarTexture(cfg.statusbar_texture)
        Castbar:SetPoint('CENTER',UIParent,0,-115)
        Castbar:CreateBorder(12,1,1,1)
        Castbar:SetBorderPadding(1)
   
        -- Add a background
        local Background = Castbar:CreateTexture(nil, 'BACKGROUND')
        Background:SetTexture(cfg.statusbar_texture)
        Background:SetAllPoints(Castbar)
        Background:SetTexture(0, 0, 0, .5)
   
        -- Add a spark
        local Spark = Castbar:CreateTexture(nil, "OVERLAY")
        Spark:SetSize(20, 10)
        Spark:SetBlendMode("ADD")
   
        -- Add a timer
        local Time = Castbar:CreateFontString(nil, "OVERLAY", "GameFontNormalSmall")
        Time:SetPoint("RIGHT", Castbar, -3, 1)
   
        -- Add spell text
        local Text = Castbar:CreateFontString(nil, "OVERLAY", "GameFontNormalSmall")
        Text:SetPoint("LEFT", Castbar, 3, 1)
   
        -- Add Shield
        local Shield = Castbar:CreateTexture(nil, "OVERLAY")
        Shield:SetSize(20, 10)
        Shield:SetPoint("CENTER", Castbar)
   
        -- Add safezone
        local SafeZone = Castbar:CreateTexture(nil, "OVERLAY")
   
        -- Register it with oUF
        self.Castbar = Castbar
        self.Castbar.bg = Background
        self.Castbar.Spark = Spark
        self.Castbar.Time = Time
        self.Castbar.Text = Text
        self.Castbar.SafeZone = SafeZone
    end,
    focus = function(self)
        -- target specific stuff
        self:SetSize(cfg.width,cfg.height)
        
        -- 3D Portrait
        -- Position and size
        local Portrait = CreateFrame('PlayerModel', nil, self)
        Portrait:SetSize(cfg.height, cfg.height)
        Portrait:SetPoint('RIGHT', self, 'LEFT', -2,0)
        CreateBackdrop(Portrait)
        -- Register it with oUF
        self.Portrait = Portrait
    
        -----------------------------
        -- Castbar
        -- Position and size
        local Castbar = CreateFrame("StatusBar", nil, self)
        Castbar:SetSize(200, 20)
        Castbar:SetStatusBarTexture(cfg.statusbar_texture)
        Castbar:SetPoint('CENTER',UIParent,0,-165)
        Castbar:CreateBorder(12,1,1,1)
        Castbar:SetBorderPadding(1)
   
        -- Add a background
        local Background = Castbar:CreateTexture(nil, 'BACKGROUND')
        Background:SetTexture(cfg.statusbar_texture)
        Background:SetAllPoints(Castbar)
        Background:SetTexture(0, 0, 0, .5)
   
        -- Add a spark
        local Spark = Castbar:CreateTexture(nil, "OVERLAY")
        Spark:SetSize(20, 10)
        Spark:SetBlendMode("ADD")
   
        -- Add a timer
        local Time = Castbar:CreateFontString(nil, "OVERLAY", "GameFontNormalSmall")
        Time:SetPoint("RIGHT", Castbar, -3, 1)
   
        -- Add spell text
        local Text = Castbar:CreateFontString(nil, "OVERLAY", "GameFontNormalSmall")
        Text:SetPoint("LEFT", Castbar, 3, 1)
   
        -- Add Shield
        local Shield = Castbar:CreateTexture(nil, "OVERLAY")
        Shield:SetSize(20, 10)
        Shield:SetPoint("CENTER", Castbar)
   
        -- Add safezone
        local SafeZone = Castbar:CreateTexture(nil, "OVERLAY")
   
        -- Register it with oUF
        self.Castbar = Castbar
        self.Castbar.bg = Background
        self.Castbar.Spark = Spark
        self.Castbar.Time = Time
        self.Castbar.Text = Text
        self.Castbar.SafeZone = SafeZone
    end,
    boss = function(self)
        -- boss frames
    end,
    arena = function(self)
        -- arena frames
    end,
    party = function(self)
        --party stuff
    end
}
UnitSpecific.raid = UnitSpecific.party  -- raid is equal to party
 
------------------------------------------------------------------------
-- Shared settings
------------------------------------------------------------------------
local function Shared(self, unit)
    self:SetScript("OnEnter", UnitFrame_OnEnter)
    self:SetScript("OnLeave", UnitFrame_OnLeave)
 
    self:RegisterForClicks"AnyUp"
 
    -- shared functions
    -----------------------------
    -- Health   
    -- Your Health Statusbar
    local Health = CreateFrame("StatusBar", nil, self)
    Health:SetHeight(cfg.height/2)
    Health:SetStatusBarTexture(cfg.statusbar_texture)
    Health:SetPoint('TOP')
    Health:SetPoint('LEFT')
    Health:SetPoint('RIGHT')
    Health:CreateBorder(12,1,1,1)
    Health:SetBorderPadding(1)
    CreateBackdrop(Health)
    -- Options
    Health.frequentUpdates = true
    Health.colorTapping = true
    Health.colorDisconnected = true
    Health.colorClass = true
    Health.colorReaction = true
    Health.colorHealth = true
    -- Register it with oUF
    self.Health = Health
    self.Health.bg = Healthbg
    --Text
    --Percent
    local HealthText = Health:CreateFontString(nil, "OVERLAY", "TextStatusBarText") -- parent to last child to make sure it's on top
    HealthText:SetPoint("RIGHT", Health, -5,0) -- but anchor to the base element so it doesn't wiggle
    self:Tag(HealthText, "[perhp]") -- oUF will automagically update it!
    Health.text = HealthText
    --Value
    local HealthText2 = Health:CreateFontString(nil, "OVERLAY", "TextStatusBarText") -- parent to last child to make sure it's on top
    HealthText2:SetPoint("LEFT", Health, 5,0) -- but anchor to the base element so it doesn't wiggle
    self:Tag(HealthText2, "[curhp]") -- oUF will automagically update it!
    Health.text = HealthText2
 
    -----------------------------
    -- Power
    -- Your Power Statusbar
    local Power = CreateFrame("StatusBar", nil, Health)
    Power:SetHeight(cfg.height/2-11)
    Power:SetStatusBarTexture(cfg.statusbar_texture)
    Power:SetPoint('TOP',Health,'BOTTOM',0,-2)
    Power:SetPoint('LEFT')
    Power:SetPoint('RIGHT')
    Power:CreateBorder(12,1,1,1)
    Power:SetBorderPadding(1)
    CreateBackdrop(Power)
    -- Options
    Power.frequentUpdates = true
    Power.colorPower = true -- powertype colored bar
    Power.colorClassNPC = false -- color power based on NPC 
    Power.colorClassPet = false -- color power based on pet type
    -- Register it with oUF
    self.Power = Power
    self.Power.bg = Powerbg
    --Text
    --Percent
    local PowerText = Power:CreateFontString(nil, "OVERLAY", "TextStatusBarText") -- parent to last child to make sure it's on top
    PowerText:SetPoint("RIGHT", Power, -5,0) -- but anchor to the base element so it doesn't wiggle
    self:Tag(PowerText, "[perpp]") -- oUF will automagically update it!
    Power.text = PowerText
    --Value
    local PowerText2 = Power:CreateFontString(nil, "OVERLAY", "TextStatusBarText") -- parent to last child to make sure it's on top
    PowerText2:SetPoint("LEFT", Power, 5,0) -- but anchor to the base element so it doesn't wiggle
    self:Tag(PowerText2, "[curpp]") -- oUF will automagically update it!
    Power.text = PowerText2
    
    -----------------------------
    -- Buffs
    local Buffs = CreateFrame("Frame", nil, self)
    Buffs:SetPoint("BOTTOM", self, "TOPLEFT", -cfg.height,0)
    Buffs:SetPoint'LEFT'
    Buffs:SetPoint'RIGHT'
    Buffs:SetHeight(17)
 
    Buffs.size = 17
 
    self.Buffs = Buffs
 
    -----------------------------
    -- Debuffs
    local Debuffs = CreateFrame("Frame", nil, self)
    Debuffs:SetPoint("TOP", self, "BOTTOMLEFT", -cfg.height,-30)
    Debuffs:SetPoint'LEFT'
    Debuffs:SetPoint'RIGHT'
    Debuffs:SetHeight(20)
 
    Debuffs.initialAnchor = "TOPLEFT"
    Debuffs.size = 20
    Debuffs.showDebuffType = true
 
    self.Debuffs = Debuffs
    
    -----------------------------
    -- Rez Icon
    -- Position and size
    local ResurrectIcon = self:CreateTexture(nil, 'OVERLAY')
    ResurrectIcon:SetSize(16, 16)
    ResurrectIcon:SetPoint('TOPRIGHT', self)
   
    -- Register it with oUF
    self.ResurrectIcon = ResurrectIcon
    
    -----------------------------
    -- Raid icons
    -- Position and size
    local RaidIcon = self:CreateTexture(nil, 'OVERLAY')
    RaidIcon:SetSize(16, 16)
    RaidIcon:SetPoint('TOPRIGHT', self)
    
    -- Register it with oUF
    self.RaidIcon = RaidIcon
    
    -----------------------------
    -- Raid Roles
    -- Position and size
    local RaidRole = self:CreateTexture(nil, 'OVERLAY')
    RaidRole:SetSize(16, 16)
    RaidRole:SetPoint('TOPLEFT')
   
    -- Register it with oUF
    self.RaidRole = RaidRole
    
    -----------------------------
    -- LFD Role
    -- Position and size
    local LFDRole = self:CreateTexture(nil, "OVERLAY")
    LFDRole:SetSize(16, 16)
    LFDRole:SetPoint("LEFT", self)
   
    -- Register it with oUF
    self.LFDRole = LFDRole
    
    -----------------------------
    -- Quest Icon
    -- Position and size
    local QuestIcon = self:CreateTexture(nil, 'OVERLAY')
    QuestIcon:SetSize(16, 16)
    QuestIcon:SetPoint('TOPRIGHT', self)
   
    -- Register it with oUF
    self.QuestIcon = QuestIcon
    
    -----------------------------
    -- Leader Icon
    -- Position and size
    local Leader = self:CreateTexture(nil, "OVERLAY")
    Leader:SetSize(16, 16)
    Leader:SetPoint("BOTTOM", self, "TOP")
   
    -- Register it with oUF
    self.Leader = Leadera
    
    -----------------------------
    -- Master looter
    -- Position and size
    local MasterLooter = self:CreateTexture(nil, 'OVERLAY')
    MasterLooter:SetSize(16, 16)
    MasterLooter:SetPoint('TOPRIGHT', self)
   
    -- Register it with oUF
    self.MasterLooter = MasterLooter
    
    -----------------------------
    -- Class Icons
    local ClassIcons = {}
    for index = 1, 5 do
        local Icon = self:CreateTexture(nil, 'BACKGROUND')
   
        -- Position and size.
        Icon:SetSize(16, 16)
        Icon:SetPoint('TOPLEFT', self, 'BOTTOMLEFT', index * Icon:GetWidth(), 0)
   
        ClassIcons[index] = Icon
    end
    
    -----------------------------
    -- Combat
    -- Position and size
    local Combat = self:CreateTexture(nil, "OVERLAY")
    Combat:SetSize(16, 16)
    Combat:SetPoint('TOP', self)
   
    -- Register it with oUF
    self.Combat = Combat
   
    -- leave this in!!
    if(UnitSpecific[unit]) then
        return UnitSpecific[unit](self)
    end
end
 
oUF:RegisterStyle('Bob', Shared)
oUF:Factory(function(self)
    self:SetActiveStyle('Bob')
    self:Spawn('player'):SetPoint(unpack(cfg.player_position))
    self:Spawn('target'):SetPoint(unpack(cfg.target_position))
    self:Spawn('focus'):SetPoint(unpack(cfg.focus_position))
end)

Phanx · 12-27-13, 12:53 AM

(1) Go install BugSack. Do it right now. Do it for this kitten. You can't say no to this kitten:
http://tinyurl.com/mht7hz6

Edit: ugh, broken forums, that link should go to youtube [slash] watch?v=hUe9HzNK-0w

(2) You have a scoping problem:

Code:

Rune:SetPoint('TOPLEFT', Power, 'BOTTOMLEFT', index * 120 / 6 - 20, 0)

In the context of that line, inside your UnitSpecific.player function, there is no Power variable defined. Either change it to self.Power and change any other element references similarly, or just move all that into your spawn function, and wrap it in a good old-fashioned if unit == "player" then ... end statement.

10leej · 12-27-13, 01:09 AM

Originally Posted by Phanx

(1) Go install BugSack. Do it right now. Do it for this kitten. You can't say no to this kitten:
http://tinyurl.com/mht7hz6

(2) You have a scoping problem:

Code:

Rune:SetPoint('TOPLEFT', Power, 'BOTTOMLEFT', index * 120 / 6 - 20, 0)

In the context of that line, inside your UnitSpecific.player function, there is no Power variable defined. Either change it to self.Power and change any other element references similarly, or just move all that into your spawn function, and wrap it in a good old-fashioned if unit == "player" then ... end statement.

the scoping problem fixed it actually. I shoulda noticed that >.>

Also already got BugSack

so now that I got runes, eclipse and totems working, guess it's time for chi, holy power, and lock stuff.

10leej · 12-28-13, 04:05 PM

Alright got everything but raid frames and unit names (some my code wont work but I don't get any errors) done. Now just gotta look at those. Probably gonna have to setup their own frames but how would sorting work out for them?

core (no name tags in there yet as I removed em gonna take a different shot later)
raid--poor attempt at raid/party frames
lib
config

Phanx · 12-29-13, 05:28 AM

At a glance:

(1) In lib.lua, you have a global function named CreateBackdrop. Global bad. Local good. Fix.

(2) Also in lib.lua you have local addonName = select(1, GetAddOnInfo('!Beautycase')) -- What is this, I don't even. You should absolutely never use select to select the first argument. (I would argue that you should pretty much never use select for anything except looping over varargs, but that's another story...)

(3) You don't need that local _ on line 14, either. Not only did you already define a local underscore on line 1, but you should not be leaking variables anywhere to need this declaration at the file level anyway.

(4) You may want to make your frame checks a bit more robust. if (not self:IsObjectType('Frame')) then will work in most cases, but if you start trying to skin things that are using metatables for prototyping, you may end up with errors when you try to CreateTexture on self. A better check would be:

if type(self) ~= "table" or type(rawget(self, 0)) ~= "userdata" then

Also, I don't really like the !Beautycase approach which injects a bunch of functions into the Frame object metatable. There's really no need for it, and it seems likely to conflict with other addons using the same unnecessary technique.

(5) In units.lua you have self.Leader = Leadera -- remove the trailing "a" to get it working.

(6) Your party and raid frames are still not getting their UnitSpecific functions called. See my previous post about this for the solution.

(7) You have an entry in UnitSpecific for "raid" in units.lua, and an entry for "party" in raid.lua. No point in having these entries when those units aren't handled in those files.

10leej · 12-29-13, 09:19 AM

I was eventually going to probably rewrite the CreateBorder function !Beautycase uses the current version works and I haven't found a suitable replacement probably can get away with making my own version nowadays though.

Phanx · 12-29-13, 09:54 AM

If you're using !Beautycase in the rest of your UI, just use it in your oUF layout instead of duplicating its functionality.