Nameplate addon after 7.2

[Joker119]

So with the changes in how nameplates are allowed to be accessed in 7.2 when you are in a dungeon or raid, my nameplate addon no longer functions, throwing a crapton of errors and screwing them over.

All my addon did was reskin the statusbar itself and use raid icons specially made to fit the rest of my UI, but, yknow, blizzard's too lazy to stop us from anchoring things to nameplates so they just make it so we can do nothing with them in dungeons. *shrug*

I need a way of determining if the player is in a dungeon or raid (or if the nameplates are turned into a protected object) so that my addon doesn't throw abunch of errors.

I do distinctly remembering blizz saying "these changes won't break existing addons, they will simple "stop working" when they enter a dungeon. Welp, it breaks my addon, not only causing LUA errors but also royally fucking over the default nameplates somehow. (not sure, don't ask *shrug*)

[Joker119]

I've tried registering the PLAYER_ENTERING_WORLD event and checking for the instanceType with IsInInstance() with this:

s:RegisterEvent("PLAYER_ENTERING_WORLD")
s:SetScript("OnEvent", function(s, event, ...)
	if select(2, IsInInstance()) == "party" then return end
end)

But it seems to do nothing. Obviously I'm missing something I just don't know what, I've never tried to stop an entire addon from a event script before

[Joker119]

I was able to solve this myself afterall.

in my addon I had

for i, group  in next, groups do
  for key, value in next, options do
    _G["DefaultCompactNamePlate"..group.."FrameOptions"][key] = value
end

and before that I had

local groups = {
"Enemy",
"Friendly",
}

I moved all of this into an event handler for the frame itself, and set the "groups" table to be determined by an if/then/else function that checks for the instanceType like so:

h:RegisterEvent("PLAYER_ENTERING_WORLD")
h:SetScript("OnEvent", function(h, event, ...)
	if select(2, IsInInstance()) == "party" or select(2, IsInInstance()) == "raid" then 
		local groups = { "Enemy",}
	else
		local groups = { "Enemy", "Friendly", }
	end
	for i, group  in next, groups do
		for key, value in next, options do
			_G["DefaultCompactNamePlate"..group.."FrameOptions"][key] = value
		end
	end
end)

And the addon seems to be working the way i need it to. Everything remains unchanged until the player enters a dungeon or raid instance, then the friendly nameplates are no longer handled by the addon until the player is no longer in an instance anymore.

[lightspark]

TBH, I didn't need to change anything to make nameplates work in oUF.

The only way to "stumble upon" so-called forbidden nameplates is to intentionally call `C_NamePlate.GetNamePlateForUnit` w/ necessary argument.

C_NamePlate.GetNamePlateForUnit(unitToken[, includeForbidden])

You probably should review the way you handle nameplates. I really hope that you don't do it by iterating through `WorldFrame`'s children, that's been unnecessary since 7.0.

[Joker119]

I don't use oUF for nameplates, and I don't iterate through world frame's children either, funny enough, the error is actually coming from the blizzard default nameplates xml, not my addon, but it refers to trying to access a forbidden function that "has been tainted by an addon"

-- rNamePlates: core
-- Galaxy 2016
 
-----------------------------
-- Variables
-----------------------------
 
local addon, ns = ...
local EliteTag = "+"
local RareTag = "^"
local BossTag = "*"
local cfg = ns.cfg
if not cfg.embeds.rNamePlates then return end
-----------------------------
-- SetCVar
-----------------------------
 
SetCVar("namePlateMinScale", 1)
SetCVar("namePlateMaxScale", 1)
 
-----------------------------
-- Options
-----------------------------
 
local options = {
  useClassColors = true,
  displayNameWhenSelected = true,
  displayNameByPlayerNameRules = true,
  playLoseAggroHighlight = false,
  displayAggroHighlight = true,
  displaySelectionHighlight = true,
  considerSelectionInCombatAsHostile = true,
  colorNameWithExtendedColors = true,
  colorHealthWithExtendedColors = true,
  selectedBorderColor = CreateColor(0, 0, 0, 1),
  tankBorderColor = false,
  defaultBorderColor = CreateColor(0, 0, 0, 1),
  showClassificationIndicator = true,
}
 
 
 
 
-----------------------------
-- Functions
-----------------------------
 
local function GetHexColorFromRGB(r, g, b)
    return string.format("%02x%02x%02x", r*255, g*255, b*255)
end
 
--SetupNamePlate
local h = CreateFrame("Frame")
h:RegisterEvent("PLAYER_ENTERING_WORLD")
h:SetScript("OnEvent", function(h, event, ...)
    if select(2, IsInInstance()) == "party" or select(2, IsInInstance()) == "raid" then 
        local groups = { "Enemy",}
    else
        local groups = { "Enemy", "Friendly", }
    end
    for i, group  in next, groups do
        for key, value in next, options do
            _G["DefaultCompactNamePlate"..group.."FrameOptions"][key] = value
        end
    end
end)
h:RegisterEvent("NAME_PLATE_CREATED")
h:SetScript("OnEvent", function(h, event, ...)
    if event == "NAME_PLATE_CREATED" then
        hooksecurefunc("DefaultCompactNamePlateFrameSetupInternal", function(frame, setupOptions, frameOptions, ...)
        local unit = ...
            --Health Bar
            frame.healthBar:SetStatusBarTexture(mediapath.."statusbar_fill")
            frame.healthBar:SetSize(256,32)
            frame.healthBar:SetScale(0.35)
            frame.RaidTargetFrame.RaidTargetIcon:SetTexture(mediapath.."raidicons")
            frame.RaidTargetFrame:SetPoint("RIGHT", frame.healthBar,"RIGHT",35,0)
            frame.ClassificationFrame:Hide()
  
            --Left Edge artwork
            if (not frame.healthBar.le) then
                frame.healthBar.le = frame.healthBar:CreateTexture(nil,"BACKGROUND",nil,-8)
                frame.healthBar.le:SetTexture(mediapath.."edge_left")
                frame.healthBar.le:SetSize(64,64)
                frame.healthBar.le:SetPoint("RIGHT",frame.healthBar,"LEFT",0,0)
            end
    
            --Right Edge artwork
            if (not frame.healthBar.re) then
                frame.healthBar.re = frame.healthBar:CreateTexture(nil,"BACKGROUND",nil,-8)
                frame.healthBar.re:SetTexture(mediapath.."edge_right")
                frame.healthBar.re:SetSize(64,64)
                frame.healthBar.re:SetPoint("LEFT",frame.healthBar,"RIGHT",0,0)
            end
            
            --Healthbar Background
            if (not frame.healthBar.bg) then
                frame.healthBar.bg = frame.healthBar:CreateTexture(nil,"BACKGROUND",nil,-8)
                frame.healthBar.bg:SetTexture(mediapath.."statusbar_bg")
                frame.healthBar.bg:SetAllPoints()
            end
            
            --Name shadow
            if (not frame.healthBar.shadow) then
                frame.healthBar.shadow = frame.healthBar:CreateTexture(nil,"BACKGROUND",nil,-8)
                frame.healthBar.shadow:SetTexture("Interface\\Common\\NameShadow")
                frame.healthBar.shadow:SetPoint("BOTTOM",frame.healthBar,"TOP",0,-20)
                frame.healthBar.shadow:SetSize(256,32)
                frame.healthBar.shadow:SetTexCoord(1,1,1,0,0,1,0,0)
                frame.healthBar.shadow:SetAlpha(0.5)
            end
  
            --Highlight Frame
            if (not frame.healthBar.hlf) then
                frame.healthBar.hlf = CreateFrame("Frame",nil,frame.healthBar)
                frame.healthBar.hlf:SetAllPoints(frame.healthBar)
                frame.healthBar.hlf = frame.healthBar.hlf
            end
  
            --Highlight
            if (not frame.healthBar.hl) then
                frame.healthBar.hl = frame.healthBar.hlf:CreateTexture(nil,"BACKGROUND",nil,-8)
                frame.healthBar.hl:SetTexture(mediapath.."statusbar_highlight")
                frame.healthBar.hl:SetPoint("TOP",50,0)
                frame.healthBar.hl:SetPoint("LEFT",-30,0)
                frame.healthBar.hl:SetPoint("RIGHT",30,0)
                frame.healthBar.hl:SetPoint("BOTTOM",40,0)
            end
  
            --Cast Bar
            frame.castBar:SetStatusBarTexture(mediapath.."statusbar_fill")
            if GetCVar("NamePlateVerticalScale") == "1" then
                frame.castBar:SetHeight(11)
                frame.castBar.Icon:SetTexCoord(0.1,0.9,0.1,0.9)
                frame.castBar.Icon:SetSize(17,17)
                frame.castBar.Icon:ClearAllPoints()
                frame.castBar.Icon:SetPoint("BOTTOMRIGHT",frame.castBar,"BOTTOMLEFT",-2,0)
            end
        end)
    end
end)
 
 
--Name
hooksecurefunc("CompactUnitFrame_UpdateName", function (frame)
   --Set the tag based on UnitClassification, can return "worldboss", "rare", "rareelite", "elite", "normal", "minus"
    local tag 
    local level = UnitLevel(frame.unit)
    local name = UnitName(frame.unit)
    local hexColor
   
    if level >= UnitLevel("player")+5 then
        hexColor = GetHexColorFromRGB(1,0,0)
    elseif level >= UnitLevel("player")+3 then
        hexColor = "ff6600"
    elseif level <= UnitLevel("player")-5 then
        hexColor = GetHexColorFromRGB(.5,.5,.5)
    elseif level <= UnitLevel("player")-3 then
        hexColor = GetHexColorFromRGB(0,1,0)
    else
        hexColor = GetHexColorFromRGB(1,1,0)
    end
 
    if UnitClassification(frame.unit) == "worldboss" or UnitLevel(frame.unit) == -1 then
        level = "??"
        hexColor = "ff6600"
    elseif UnitClassification(frame.unit) == "rare" then
        name = "*"..name.."*"
    elseif UnitClassification(frame.unit) == "rareelite" then
        name = "*"..name.."*"
        level = "+"..level
    elseif UnitClassification(frame.unit) == "elite" then
        level = "+"..level
    end
    --Set the nameplate name to include tag(if any), name and level
    frame.name:SetText("|cff"..hexColor.."("..level..")|r "..name)
    frame.name:SetFont(cfg.font, 12)
end)
 
 
 
local function IsTank()
  local assignedRole = UnitGroupRolesAssigned("player")
  if assignedRole == "TANK" then return true end
  local role = GetSpecializationRole(GetSpecialization())
  if role == "TANK" then return true end
  return false
end
 
 
--UpdateHealthBorder
local function UpdateHealthBorder(frame)
  if frame.displayedUnit:match("(nameplate)%d?$") ~= "nameplate" then return end
  if not IsTank() then return end
  local status = UnitThreatSituation("player", frame.displayedUnit)
  if status and status >= 3 then
    frame.healthBar.border:SetVertexColor(0, 1, 0, 0.8)
  end
end
hooksecurefunc("CompactUnitFrame_UpdateHealthBorder", UpdateHealthBorder)

[lightspark]

Almost no one uses oUF for nameplates atm, cuz it's in dev branch, future release, you know

As for your code, try adding `:IsForbidden()` checks to all your hooks.

local function UpdateHealthBorder(frame)
    if frame:IsForbidden() then return end -- <-- this one
 
    if frame.displayedUnit:match("(nameplate)%d?$") ~= "nameplate" then return end
    if not IsTank() then return end
    local status = UnitThreatSituation("player", frame.displayedUnit)
    if status and status >= 3 then
        frame.healthBar.border:SetVertexColor(0, 1, 0, 0.8)
    end
end

There are other issues w/ your code, but this thread isn't about them...

[Joker119]

Awesome thanks for that, and I would be interested in that the other issues would be.. >.>

[lightspark]

Originally Posted by Galaxy119 Awesome thanks for that, and I would be interested in that the other issues would be.. >.>

For instance this block:

h:RegisterEvent("NAME_PLATE_CREATED")
h:SetScript("OnEvent", function(h, event, ...)
    if event == "NAME_PLATE_CREATED" then
        hooksecurefunc("DefaultCompactNamePlateFrameSetupInternal", function(frame, setupOptions, frameOptions, ...)
            -- code here    
        end)
    end
end)

You hook the same function multiple times That's the most obvious one, sorry, I'm a bit busy atm to look through the rest T_T