Proper LUA?

unlimit · 03-15-12, 12:26 AM

So, I was making a new feature for my unitframes while my internet was down, but since I had no where to test it this is what I came up with. >.>

One of my problems is, though, I hate long lines of repeating crap. So when I was looking at the below, I thought, maybe it'd be better if I made a loop out of it.

lua Code:

local class = select(2, UnitClass("player"))
local mastery = GetPrimaryTalentTree()

lua Code:

if class == "DEATHKNIGHT" then
    if mastery == 1 then return data["deathknight_" .. mastery]; end        
    if mastery == 2 then return data["deathknight_" .. mastery]; end        
    if mastery == 3 then return data["deathknight_" .. mastery]; end
elseif class == "DRUID" then
    if mastery == 1 then return data["druid_" .. mastery]; end      
    if mastery == 2 then return data["druid_" .. mastery]; end      
    if mastery == 3 then return data["druid_" .. mastery]; end
elseif class == "HUNTER" then
    if mastery == 1 then return data["hunter_" .. mastery]; end     
    if mastery == 2 then return data["hunter_" .. mastery]; end     
    if mastery == 3 then return data["hunter_" .. mastery]; end
elseif class == "MAGE" then
    if mastery == 1 then return data["mage_" .. mastery]; end       
    if mastery == 2 then return data["mage_" .. mastery]; end       
    if mastery == 3 then return data["mage_" .. mastery]; end
elseif class == "PALADIN" then
    if mastery == 1 then return data["paladin_" .. mastery]; end        
    if mastery == 2 then return data["paladin_" .. mastery]; end        
    if mastery == 3 then return data["paladin_" .. mastery]; end
elseif class == "PRIEST" then
    if mastery == 1 then return data["priest_" .. mastery]; end     
    if mastery == 2 then return data["priest_" .. mastery]; end     
    if mastery == 3 then return data["priest_" .. mastery]; end
elseif class == "ROGUE" then
    if mastery == 1 then return data["rogue_" .. mastery]; end      
    if mastery == 2 then return data["rogue_" .. mastery]; end      
    if mastery == 3 then return data["rogue_" .. mastery]; end
elseif class == "SHAMAN" then
    if mastery == 1 then return data["shaman_" .. mastery]; end     
    if mastery == 2 then return data["shaman_" .. mastery]; end     
    if mastery == 3 then return data["shaman_" .. mastery]; end
elseif class == "WARLOCK" then
    if mastery == 1 then return data["warlock_" .. mastery]; end        
    if mastery == 2 then return data["warlock_" .. mastery]; end        
    if mastery == 3 then return data["warlock_" .. mastery]; end
elseif class == "WARRIOR" then
    if mastery == 1 then return data["warrior_" .. mastery]; end        
    if mastery == 2 then return data["warrior_" .. mastery]; end        
    if mastery == 3 then return data["warrior_" .. mastery]; end
else
    return data["all"];
end

So this was born. Unfortunately, I'm not certain this is valid LUA. I'm also under the impression that the "classlist" table is completely unnessisary.

lua Code:

classlist = {
    "DEATHKNIGHT",
    "DRUID",
    "HUNTER",
    "MAGE",
    "PALADIN",
    "PRIEST",
    "ROGUE",
    "SHAMAN",
    "WARLOCK",
    "WARRIOR"
}
 
for c = 1, #classlist do
    for m = 1, 3 do
        if class == classlist[c] then
            if mastery == m then return data[class .. "_" .. m]; end
        end
    end
end
 
if mastery ~= nil then
    return data["all"];
end

So my question to you awesome guys is, well, would what I made be pretty much the same as the above? Would there be a more efficent way to do it? And, are there things that I'm doing that might be unnessisary, like the classlist table?

Xrystal · 03-15-12, 12:50 AM

Looking at that little example you could break it down even easier as ...

Code:

local class = select(2, UnitClass("player"))
local mastery = GetPrimaryTalentTree()
return data[class.tolower().."_"..mastery]

unlimit · 03-15-12, 01:10 AM

xD I never imagined it'd be that easy. Thanks a lot Xrystal / Nib (even though you deleted yours xD!)

This one, on the other hand, CAN'T be that easy. I need to return all of them, all of the time.

For instance, for a mage it'd be...

lua Code:

local mage = RDXDB.ObjectFinder:new(parent, function(p,f,md) return (md and type(md) == "table"); end);
mage:SetLabel(VFLI.i18n("MAGE"));
if desc and desc.MAGE then mage:SetPath(desc.MAGE); end
mage:Show();
ui:InsertFrame(mage);

I know the below isn't correct, but it's kind of the only thing that ran through my head. <_<

If it isn't too much to ask here, what would be a MUCH better way of doing this, if I ALWAYS need these to show up?

lua Code:

function TRUESYS.classspec()
    local _, class = UnitClass("player")
    local mastery = GetPrimaryTalentTree()
 
    classlist = {
        "DEATHKNIGHT",
        "DRUID",
        "HUNTER",
        "MAGE",
        "PALADIN",
        "PRIEST",
        "ROGUE",
        "SHAMAN",
        "WARLOCK",
        "WARRIOR"
    }
 
    return class, mastery, classlist
end
 
local function testfunction()
    classlist = TRUESYS.classspec()
 
    for c = 1, #classlist do
        for m = 1, 3 do
            local classlist[c] .. "_" .. m = RDXDB.ObjectFinder:new(parent, function(p,f,md) return (md and type(md) == "table"); end);
            classlist[c] .. "_" .. m:SetLabel(VFLI.i18n(classlist[c] .. "_" .. m));
            if desc and desc.classlist[c] .. "_" .. m then classlist[c] .. "_" .. m:SetPath(desc.classlist[c] .. "_" .. m); end
            classlist[c] .. "_" .. m:Show();
            ui:InsertFrame(classlist[c] .. "_" .. m);
        end
    end
 
    local all = RDXDB.ObjectFinder:new(parent, function(p,f,md) return (md and type(md) == "table"); end);
    all:SetLabel(VFLI.i18n("ALL"));
    if desc and desc.ALL then all:SetPath(desc.ALL); end
    all:Show();
    ui:InsertFrame(all);
end
 
testfunction()

**Seerah** · 03-15-12, 08:45 PM

Unless you need that mastery variable later, you can even do

Code:

return data[class:lower().."_"..GetPrimaryTalentTree()]

This would be even leaner if the class names in your data table were all caps and you didn't need to make them lower case. (PS- your formatting and method name are wrong, Xrystal. I corrected it above.)

I would even get rid of that extra select function call and do

Code:

local _,class = UnitClass("player")

Xrystal · 03-15-12, 11:02 PM

Oops, thanks Seerah.

unlimit · 03-15-12, 11:28 PM

Thanks a lot Seerah, Xrystal, and Nib!

I changed the above again, kept calling mastery / class when I didn't need it. c.c
What I'm really looking for out of the rest of this is combining names, kind of like in a string you can just do:

lua Code:

print(test.."_"..tset);

If I wanted a variable in the same fashion, such as:

lua Code:

local classlist[c] .. "_" .. m = dostuff

how would I go about doing it?

lua Code:

function TRUESYS.classspec()
    local _, class = UnitClass("player")
    local mastery = GetPrimaryTalentTree()
 
    classlist = {
        "DEATHKNIGHT",
        "DRUID",
        "HUNTER",
        "MAGE",
        "PALADIN",
        "PRIEST",
        "ROGUE",
        "SHAMAN",
        "WARLOCK",
        "WARRIOR"
    }
 
    return class, mastery, classlist
end
 
local function testfunction()
    classlist = TRUESYS.classspec()
 
    for c = 1, #classlist do
        for m = 1, 3 do
            local classlist[c] .. "_" .. m = RDXDB.ObjectFinder:new(parent, function(p,f,md) return (md and type(md) == "table"); end);
            classlist[c] .. "_" .. m:SetLabel(VFLI.i18n(classlist[c] .. "_" .. m));
            if desc and desc.classlist[c] .. "_" .. m then classlist[c] .. "_" .. m:SetPath(desc.classlist[c] .. "_" .. m); end
            classlist[c] .. "_" .. m:Show();
            ui:InsertFrame(classlist[c] .. "_" .. m);
        end
    end
 
    local all = RDXDB.ObjectFinder:new(parent, function(p,f,md) return (md and type(md) == "table"); end);
    all:SetLabel(VFLI.i18n("ALL"));
    if desc and desc.ALL then all:SetPath(desc.ALL); end
    all:Show();
    ui:InsertFrame(all);
end
 
testfunction()

kaels · 03-16-12, 02:27 AM

I think if you want to access 'dostuff' through that concatenated string, the best way to do it would be to use it as a key in a table:

lua Code:

local sometable = {}
sometable[classlist[c] .. "_" .. m] = dostuff

Then you can access dostuff through e.g. sometable.DEATHKNIGHT_1 or sometable[DEATHKNIGHT_1] or sometable[classlist[c] .. "_" .. m] in a scope where c==1 and m==1.

Phanx · 03-16-12, 02:31 AM

Originally Posted by unlimit

If I wanted a variable in the same fashion, such as:

lua Code:

local classlist[c] .. "_" .. m = dostuff

how would I go about doing it?

You wouldn't. Lua variable names cannot be constructed that way. A variable is called a variable because its contents are variable; the whole point of assigning the value to a variable is so that you have a consistent name to refer to content that's not known ahead of time.

I'm actually not even sure what half your code was attempting to do, and I know nothing about the RDX API, but something like this is surely closer to valid Lua code:

Lua Code:

--  Define this once instead of making a new table
--  every time your call your function.
local classlist = {
    "DEATHKNIGHT",
    "DRUID",
    "HUNTER",
    "MAGE",
    "PALADIN",
    "PRIEST",
    "ROGUE",
    "SHAMAN",
    "WARLOCK",
    "WARRIOR"
}
 
function TRUESYS.classspec()
    local _, class = UnitClass("player")
    local mastery = GetPrimaryTalentTree()
 
    return class, mastery
    --  Don't bother returning the classlist table
    --  unless you're going to be calling this function
    --  from other files. Inside this file, you can
    --  simply refer to the table directly.
end
 
--  Define this once, instead of making a new duplicate function
--  30 times every time you run testfunction().
local function newfunc(p, f, md)
    --  You don't need to check for simple existence on "md" first,
    --  because "nil" is also a type, and "nil" ~= "table".
    return type(md) == "table"
end
 
local function testfunction()
--  classlist = TRUESYS.classspec()
--  for c = 1, #classlist do
--  ^ These lines from your original code don't even make sense.
--  The TRUESYS.classspec() function returns three values, not a table,
--  so by assigning its returns to a single variable, you're actually
--  only catching the first one, which is a string describing the
--  player's class. The # operator will also give you the length of a
--  string, so if you're on a DRUID, your loop will run from 1 to 5,
--  because the string "DRUID" is 5 characters long.
 
    local class, spec = TRUESYS.classpsec()
    for i = 1, #classlist do
        for j = 1, 3 do
            local iclass = classlist[i]
            --  I think you want to make a table for each class:
            classlist[iclass] = classlist[iclass] or {}
            --  ... and then make some kind of RDX object for each spec for that class:
            --      Probably this will trigger an error because "parent" is not defined.
            local specObject = RDXDB.ObjectFinder:new(parent, newfunc)
            -- ... and then add that object to the table for the class:
            classlist[iclass][j] = specObject
 
            specObject:SetLabel(VFLI.i18n(specObject))
 
            --  This line should actually trigger Lua errors, because
            --  1. the variable "desc" is not defined in this scope, and
            --  2. "desc" is not a table with the RDX object you just created
            --      as one of its keys.
            --  I know basically nothing about the RDX API, so you're on your own
            --  with fixing this section. I commented it out for now.
--          if desc and desc.specObject then
--              specObject:SetPath(desc.specObject)
--          end
 
            specObject:Show()
            ui:InsertFrame(specObject)
        end
    end
 
    --  Probably this will trigger an error because "parent" is not defined.
    local all = RDXDB.ObjectFinder:new(parent, newfunc)
    all:SetLabel(VFLI.i18n("ALL"))
    --  Probably this will trigger an error because "desc" is not defined.
    if desc and desc.ALL then
        all:SetPath(desc.ALL)
    end
    all:Show()
    ui:InsertFrame(all)
end
 
testfunction()

unlimit · 03-16-12, 06:46 AM

Thanks so much Phanx.

Your posts are always so incredibly educational, and I really do appreciate it. Every time I see you reply to someone it's so in depth. >.< I was sitting here wracking my brain on what the hell to do, and you come in and do this

Ketho · 03-16-12, 07:41 AM

Originally Posted by unlimit

Thanks so much Phanx.

Your posts are always so incredibly educational, and I really do appreciate it. every time I see you reply to someone it's so in depth. >.< I was sitting here wracking my brain on what the hell to do, and you come in and do this

Time to revive the Phanx admiration thread

unlimit · 03-16-12, 09:38 AM

Originally Posted by Ketho

Time to revive the Phanx admiration thread

Here here!

Well, at this point, I'll just post the entire feature.

lua Code:

function TRUESYS.classspec()
    local _, class = UnitClass("player")
    local mastery = GetPrimaryTalentTree()
 
    return class, mastery
end
 
local classlist = {
    "DEATHKNIGHT",
    "DRUID",
    "HUNTER",
    "MAGE",
    "PALADIN",
    "PRIEST",
    "ROGUE",
    "SHAMAN",
    "WARLOCK",
    "WARRIOR"
}
 
local function newfunc(p, f, md)
    return type(md) == "table"
end
 
RDXDB.RegisterSymLinkClass({
    name = "class/spec";
    title = "class/spec";
    GetTargetPath = function(data)
        class, mastery = TRUESYS.classspec()
        if mastery == nil then
            return data["all"]
        else
            return data[class .. mastery]
        end
    end;
    Register = function(path)
        VFLEvents:Bind("PLAYER_TALENT_UPDATE", nil, function() RDXDB.NotifyUpdate(path); end, "symlink_" .. path);
    end;
    Unregister = function(path)
        VFLEvents:Unbind("symlink_" .. path);
    end;
    GetUI = function(parent, desc)
        local ui = VFLUI.CompoundFrame:new(parent);
        
        for i = 1, #classlist do
            for j = 1, 3 do
                local cl = classlist[i]
                classlist[cl] = classlist[cl] or {}
                local specObject = RDXDB.ObjectFinder:new(parent, newfunc)
                classlist[cl][j] = specObject
                specObject:SetLabel(VFLI.i18n(cl .. " " .. j))
                if desc and desc.specObject then
                    specObject:SetPath(desc.specObject)
                end
 
                specObject:Show()
                ui:InsertFrame(specObject)
            end
        end
 
        local all = RDXDB.ObjectFinder:new(parent, newfunc)
        all:SetLabel(VFLI.i18n("ALL"))
        if desc and desc.ALL then
            all:SetPath(desc.ALL)
        end
        all:Show()
        ui:InsertFrame(all)
 
        ui.GetDescriptor = function(x)
            return {
                class = "class/talent",
                mage3 = classlist.MAGE[3]:GetPath(),
                all = all:GetPath(),
            };
        end;
 
        ui.Destroy = VFL.hook(function(s) s.GetDescriptor = nil; end, ui.Destroy);
 
        return ui;
    end;
});

The only two things I'm having a problem with now are, in the ui.GetDescriptor function, creating a loop for all classes / specs (i.e. mage3 = classlist.MAGE[3]:GetPath()) instead of just posting it all. It's probably not worth the trouble (to be honest, none of it really was, I just can't stand seeing long repetitious lines. c.c) And the problem of the new table only populating on-open.

Using the code Phanx wrote, it works great! All of the data for the object is stored in classlist.<class>[3], it JUST doesn't work on reloadui (and login/logoff), unless I open the frame again. x3

Waky · 03-16-12, 10:56 AM

Originally Posted by Ketho

Time to revive the Phanx admiration thread

I laughed when I saw this post :P