New addon pseudocode - need feedback please

[elviso]

Greetings all,

Some priests in my guild know that I'm handy with scripting, but I've never actually coded any addons from scratch, so what they're requesting of me is quite the chore. I've got some pseudocode drawn up, and I'll be the 1st to admit that it's ugly, nasty, terrible, has gaping holes in the logic, and is pretty much just bad....however....if any of you wouldn't mind taking a look at it, and posting any relevant feedback, I'd love to hear it. Hopefully you can read my half-pseudo, half-lua mess:

http://wow.pastebin.com/654829

The jist of it is, "Automagically finds a PI target, i.e. either a warlock or mage, with mana > x, in-range, in-raid or in-party, and able to cast (not seduced, etc). Has a favorites list and a skip list."

EDIT: the favorite & skip lists (tables) are going to be saved in saved vars, sorry if that's not evident in the pseudocode.

[elviso]

Ok, looks like a few people read the post, but I can only guess why there's no replies

Anyways, I've converted the really-messy-pseudocode into not-quite-as-messy code (I hope).....anyways, obviously a work in progress, but still any feedback would be cool

http://wow.pastebin.com/655150

[Maia]

Elviso, I can't really comment on the code as it looks pretty streamlined to me - but I wouldnt call myself an expert at all. But I'd like to thank you for linking pastebin - I love it.

[elviso]

Hrmm, thanks

I'll just use this post as a historical record of my pastebins then, and I'll let others comment as they see fit...

http://wow.pastebin.com/656701

[elviso]

I suprised myself and got a working (somewhat) version going, and I think as soon as I get some /commands added (tomorrow hopefully) that it'll be ready for some in-guild alpha testing.

http://wow.pastebin.com/657373

Stay tuned for the next exciting chapter of n00bish programming!

[elviso]

Latest incarnation can be found here:

http://www.wowinterface.com/download...fo.php?id=4841