Request: Crowd control icon on default raid frames

[llerelol]

I'm really surprised there's no such an addon.

Here's an example:


And no, I don't wanna use grid or vuhdo or their alternative, i like default raid frames a lot, they just lack this one very important feature.

[Wildbreath]

Originally Posted by llerelol I'm really surprised there's no such an addon. Here's an example: And no, I don't wanna use grid or vuhdo or their alternative, i like default raid frames a lot, they just lack this one very important feature.

http://www.wowinterface.com/download...aidFrames.html but i not update this alot time ago

[llerelol]

well yeah i know about those, the bad thing it doest display regular buffs\debuffs in the corners as default frames do.

btw i was using your superclassic ui back in S9 and i was loving it, too bad you stopped maintaining it.

[ckaotik]

I have something along these lines in a custom addon ... here are the parts that you would probably need. However, I have not tested this code (as standalone). It assumes that any CC effect is on a diminishing return and only shows those.

P.S. Please tell me if this worked for you

Requirements:

1) a place to put the code: If you don't happen to have a dummy addon to stuff code into already, you can create one here: http://addon.bool.no
2) DRData-1.0 library, which can be found here: http://www.wowace.com/addons/drdata-1-0/
3) put this in your lua file (or the lua input box on addon.bool.no)

local DRData = LibStub('DRData-1.0')
local hideDRType = {
    ["ctrlroot"] = true,
    ["shortroot"] = true,
    ["disarm"] = true,
    ["taunt"] = true,
    ["knockback"] = true,
}
 
local isDisabled = nil
local _FRAMES = {}
 
local function UpdateOverlay(self)
    if not self.Overlay then return end
    local display, drType = nil, nil
    for i = 1, 40 do
        local _, _, icon, count, dispelType, _, expires, caster, _, _, spellID, canApplyAura, isBoss = UnitDebuff(self.displayedUnit or self.unit, i)
        local drType = DRData:GetSpellCategory(spellID)
        if drType and not hideDRType[drType] then
            display = true
            break
        end
    end
 
    if display then
        self.Overlay.icon:SetTexture(icon)
        self.Overlay.icon:SetDesaturated( caster == "player" )
        self.Overlay.count:SetText(count == 1 and '' or count)
        local now = GetTime()
        self.Overlay.cooldown:SetCooldown(now, expires - now)
 
        self.Overlay:Show()
    else
        self.Overlay:Hide()
    end
end
 
local isHooked = nil
local Disable = function(self)
    local overlay = self.Overlay
    if overlay then
        for k, frame in ipairs(_FRAMES) do
            if frame == self then
                tremove(_FRAMES, k)
                overlay:Hide()
                break
            end
        end
 
        if #_FRAMES == 0 and isHooked then
            isDisabled = true
        end
    end
end
 
local Enable = function(self)
    local overlay = self.Overlay
    if overlay then
        tinsert(_FRAMES, self)
        isDisabled = nil
        if not isHooked then
            hooksecurefunc("CompactUnitFrame_UpdateDebuffs", UpdateOverlay)
            isHooked = true
        end
    end
end
 
hooksecurefunc("CompactUnitFrame_UpdateVisible", function(frame)
    if not frame.Overlay and frame.unit and not frame.unit:find('pet') then
        local overlay = CreateFrame("Button", "$parentCUFOverlay", frame, "CompactAuraTemplate")
              overlay:SetPoint('CENTER', 0, 0)
              overlay:SetSize(20, 20)
              overlay:EnableMouse(false)
              overlay:EnableMouseWheel(false)
              overlay:Hide()
        frame.Overlay = overlay
        Enable(frame)
    end
end)

4) put this in your toc file (or click 'Show advanced (TOC) options' and add this line to the toc box):

## Dependencies: DRData-1.0

[Phanx]

Just FYI there is no reason to define variables outside of a loop when they will only be used inside of the loop, and doing it anyway can have unintended consequences depending on what you're using the variables for.

Don't:

    local icon, count, dispelType, expires, caster, spellID, canApplyAura, isBoss
    for i = 1, 40 do
        _, _, icon, count, dispelType, _, expires, caster, _, _, spellID, canApplyAura, isBoss = UnitDebuff(self.displayedUnit or self.unit, i)

Do:

    for i = 1, 40 do
       local  _, _, icon, count, dispelType, _, expires, caster, _, _, spellID, canApplyAura, isBoss = UnitDebuff(self.displayedUnit or self.unit, i)

(Also, your code was leaking a global _ variable, which in the past has caused UI-wide breakage. Be careful about any global leakage, but especially _ and other common variable names.)

[llerelol]

i'm currently taking a break from wow, but as soon as i return i will test it, thank you.

[ckaotik]

Originally Posted by Phanx (Also, your code was leaking a global _ variable, which in the past has caused UI-wide breakage. Be careful about any global leakage, but especially _ and other common variable names.)

I updated the snippet above, thanks. Mostly I just "ignore" _ as my files usally start with the line

local addonName, addon, _ = ...

as I'm sure to miss it somewhere. I'm also a big fan of findglobals.lua This code suffered a bit as I ripped it right out of it's "natural environment"...

[10leej]

So figured i'd give this a shot. Get this error solo out of combat.

Message: Interface\AddOns\Test\modules\test1.lua:73: attempt to index global 'frame' (a nil value)
Time: 12/08/13 13:22:00
Count: 1
Stack: Interface\AddOns\Test\modules\test1.lua:73: in function <Interface\AddOns\Test\modules\test1.lua:72>
[C]: in function `CompactUnitFrame_UpdateVisible'
Interface\FrameXML\CompactUnitFrame.lua:243: in function `CompactUnitFrame_UpdateAll'
Interface\FrameXML\CompactUnitFrame.lua:166: in function `CompactUnitFrame_SetUpFrame'
...actRaidFrames\Blizzard_CompactRaidFrameContainer.lua:347: in function `CompactRaidFrameContainer_GetUnitFrame'
...actRaidFrames\Blizzard_CompactRaidFrameContainer.lua:317: in function `CompactRaidFrameContainer_AddUnitFrame'
...actRaidFrames\Blizzard_CompactRaidFrameContainer.lua:254: in function `CompactRaidFrameContainer_AddPlayers'
...actRaidFrames\Blizzard_CompactRaidFrameContainer.lua:176: in function `CompactRaidFrameContainer_LayoutFrames'
...actRaidFrames\Blizzard_CompactRaidFrameContainer.lua:130: in function `CompactRaidFrameContainer_TryUpdate'
...actRaidFrames\Blizzard_CompactRaidFrameContainer.lua:95: in function `CompactRaidFrameContainer_SetFlowSortFunction'
...mpactRaidFrames\Blizzard_CompactRaidFrameManager.lua:407: in function <...mpactRaidFrames\Blizzard_CompactRaidFrameManager.lua:402>
...mpactRaidFrames\Blizzard_CompactRaidFrameManager.lua:491: in function `CompactRaidFrameManager_SetSetting'
...rd_CUFProfiles\Blizzard_CompactUnitFrameProfiles.lua:572: in function `func'
...rd_CUFProfiles\Blizzard_CompactUnitFrameProfiles.lua:549: in function `CompactUnitFrameProfiles_ApplyProfile'
...rd_CUFProfiles\Blizzard_CompactUnitFrameProfiles.lua:176: in function `CompactUnitFrameProfiles_ApplyCurrentSettings'
...rd_CUFProfiles\Blizzard_CompactUnitFrameProfiles.lua:172: in function `CompactUnitFrameProfiles_ActivateRaidProfile'
...rd_CUFProfiles\Blizzard_CompactUnitFrameProfiles.lua:45: in function `CompactUnitFrameProfiles_ValidateProfilesLoaded'
...rd_CUFProfiles\Blizzard_CompactUnitFrameProfiles.lua:25: in function <...rd_CUFProfiles\Blizzard_CompactUnitFrameProfiles.lua:18>

Locals: (*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index global 'frame' (a nil value)"
Enable = <function> defined @Interface\AddOns\Test\modules\test1.lua:60

[ckaotik]

Message: Interface\AddOns\Test\modules\test1.lua:73: attempt to index global 'frame' (a nil value)

Oops, forgot the argument to the function call. Please add the "frame" argument:

hooksecurefunc("CompactUnitFrame_UpdateVisible", function(frame)

(I also corrected the snippet in my first post)