Disable the Heirloom Journal

[Walkerbo]

Hi all

I want to disable the Heirlooms tab button on the Collections Journal.

I have tried a number of different methods all without success.

I have tried;

-- hook character equipment manager button
    hooksecurefunc(
        "HeirloomsJournalSpellButton_OnClick",
        function()
            ToggleCharacter("PaperDollFrame")
        end
    )

and get the following error;

5x IronMan\IronMan-1.0.9.15.lua:601: hooksecurefunc(): HeirloomsJournalSpellButton_OnClick is not a function
        [string "=[C]"]: in function `hooksecurefunc'
        [string "@IronMan\IronMan-1.0.9.15.lua"]:601: in function <IronMan\IronMan.lua:579>
        [string "@IronMan\IronMan-1.0.9.15.lua"]:654: in function <IronMan\IronMan.lua:643>
        
        Locals:

I have also tried;

local functionIWantToDisable, isFunctionStillRelevant = HeirloomsJournalSpellButton_OnClick, false
    function PVEFrame_ToggleFrame()
        if isFunctionStillRelevant then
            return functionIWantToDisable()
        end
    end

This throws no errors.

I have also tried to hide the HeirloomsJournal frame on show, and track the HEIRLOOMS_UPDATED event as well.
The event does not trigger on show so I can only guess it fires when we update a heirloom.

Is there a way I can achieve my goal?

[Kanegasi]

The first error is because the collections window is not loaded immediately. You need to load the Blizzard_Collections addon first before dealing with any part of the collections.

[Walkerbo]

Hi Kanegasi

I thought that addons are installed in alphabetical order, so my addon would not be loaded before the blizzard addons.

How do I ensure that my addon is loaded after the blizzard collections addon?

[Walkerbo]

Hi Kanegasi

After some reading it seems that all I have to do is add the following to my toc;

## Dependencies: Blizzard_Collections

I will test this out to see if it does fix my issue.

[Kanegasi]

You are correct. When the UI loads, the addon list is loaded alphabetically.

However, all immediate Blizzard "addons" are loaded first and then the user addons are loaded after. Blizzard_Collections is not loaded. It is not active when you see your character after logging in or reloading. So, no matter what you name your addon, Blizzard's "addons" will either be loaded already or not there.

You have two options. You found one, which is to put it as a dependency. The other is to simply use LoadAddOn().

[Walkerbo]

Hi Kanegasi

I have tried both methods without success.

I have probably made a bonehead mistake somewhere, but I just can't see it.

Here is my toc and lua on Pastebin.

Would it be possible for you to have a look at the files and see if anything jumps out at you?

The secure hook is at line 594, and I have added the load addon call at line 574.

[Xrystal]

I might be wrong, but at first glance, I see you are loading the addon and then utilising the journal in the same function. I would personally monitor ADDON_LOADED and use the journal after the addon has been confirmed as loaded.

[Walkerbo]

Hi Xrystal

Thanks for your suggestion.

I removed the load from the function that contained my securehooks, and moved outside.
I then registered the "ADDON_LOADED";

elseif event == "ADDON_LOADED" then
            local addonName = ...
            print(addonName) -- debug --
        end

When I login it only prints my addonName, the Blizzard_TimeManager and the Blizzard_CombatLog addons.

So it seems that even though I added Blizzard_Collections to my toc and specifically added the

LoadAddOn("Blizzard_Collections")

the Blizzard_Collections addon is not loaded.

[Kanegasi]

Blizzard_Collections is loaded before your addon. That's how the dependency thing works. There may be something else going on. I haven't reviewed anything too deep to figure it out though.

[Xrystal]

I just rigged up a quick and simple addon to see how it loads ..

Print Output is as follows:
ADDON_LOADED (XCollections)
ADDON_LOADED Blizzard_Collections
CollectionsSystem
ADDON_LOADED Blizzard_BattlefieldMap
ADDON_LOADED Blizzard_TimeManager
ADDON_LOADED Blizzard_CombatLog
PLAYER_ENTERING_WORLD false true

I then opened the collections window and selected the heirloom tab and ... nothing.. the secure hook print statements don't print. Maybe this particular set of frames are unhookable or is it not working because of the mixin part of the heirloomjournal. As you can see I even tried the main CollectionsJournal frame and that didn't work either.

However the Updating of SelectedTab did get triggered. So, maybe that is where you can make your changes.

local addon, addonData = ...
 
--[[ Handle Collection System Stuff ]]--
local function CollectionsSystem()
    print("CollectionsSystem")
 
    -- Select Heirloom Tab ? -- Didn't work
    hooksecurefunc(
        "HeirloomsJournal_OnShow",
        function(self)
            print("Showing HeirloomJournal")
        end
    )
    
    -- Open Collections Journal ? -- Didn't work
    hooksecurefunc(
        "CollectionsJournal_OnShow",
        function(self)
            print("Showing CollectionsJournal")
        end
    )
    
    -- Changing to Selected Tab ? -- Works
    hooksecurefunc(
        "CollectionsJournal_UpdateSelectedTab",
        function(self)
            print("Updating Selected Tab ")
        end
    )    
    
end
 
 
--[[ Monitor for Events ]]--
local function EventWatcher(self,event,...)
    print(event,...)
    if event == "PLAYER_ENTERING_WORLD" then
    elseif event == "ADDON_LOADED" then  
        local addonName = ...
        if addonName == addon then
            LoadAddOn("Blizzard_Collections")            
        elseif addonName == "Blizzard_Collections" then
            CollectionsSystem()
        end
    end
end
 
local f = CreateFrame("Frame")
f:RegisterEvent("PLAYER_ENTERING_WORLD")
f:RegisterEvent("ADDON_LOADED")
f:SetScript("OnEvent", EventWatcher)

[Walkerbo]

Hi Xrystal

Thanks for testing different methods, the fact that your testing resulted in the same issues I had is good in a way as it shows my failed attempts were not just boneheaded mistakes that I had made.

Hooking the CollectionsJournal_UpdateSelectedTab is a great suggestion and I will play with that.

Cheers for your help.

[Walkerbo]

Hi Xrystal

You cracked it.

-- hook heirloom tab button
    hooksecurefunc(
        "CollectionsJournal_UpdateSelectedTab",
        function()
            if HeirloomsJournal:IsVisible() then
                ToggleCollectionsJournal(1)
            end
        end
    )

Thanks to all for your help.