Troubles checking debuff on raid members

[fatrog]

Hello,

I have made a custom tiny addon just for my personal use. (It helps me getting better with addon making)
My goal is to put a symbol on the 4 players who got the debuff "Controlled Burn" (used by the first boss of the new raid)

But despite what I tried, I can't get it working...

Here is my actual code so far:

local raidTargetIcons = {1, 2, 3, 4}
 
local function UpdateRaidDebuffList()
    for i = 1, GetNumGroupMembers() do
        local unit = "raid" .. i
        for j = 1, 40 do
            local _, _, _, _, _, _, _, _, _, _, spellId, _, _, _, _, _, castSuccess = UnitDebuff(unit, j)
            if not spellId then
                break
            end
 
            if spellId == 421972 and castSuccess then
                local icon = table.remove(raidTargetIcons)
                if icon then
                    print(GetUnitName(unit, true) .. " has successfully cast Controlled Burn.")
                    ApplyRaidTargetIcon(unit, icon)
                end
                break 
            end
        end
    end
end
 
local function ApplyRaidTargetIcon(unit, icon)
    SetRaidTarget(unit, icon)
end
 
local function ClearRaidTargetIcon(unit)
    SetRaidTarget(unit, 0)
end
 
local function OnEvent(_, event, _, sourceGUID, _, _, _, _, _, destGUID, _, _, spellId)
    if event == "COMBAT_LOG_EVENT_UNFILTERED" then
    elseif event == "SPELL_AURA_REMOVED" and spellId == 421972 then
        local destName = GetUnitName(destGUID, true)
        if destName then
            local icon = GetRaidTargetIndex(destName)
            if icon then
                table.insert(raidTargetIcons, icon)
                ClearRaidTargetIcon(destName)
                print(destName .. "'s Controlled Burn debuff has been removed.")
            end
        end
    end
end
 
local frame = CreateFrame("Frame")
frame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
frame:SetScript("OnEvent", OnEvent)

[myrroddin]

You assume people are in a raid, yet you aren't checking for that. Before line 4, you need a check for IsInRaid(). If that returns true, then you can iterate your group members.

[wardz]

You need to call CombatLogGetCurrentEventInfo() inside CLEU event to get the combat log payload nowadays. (You can also get the destName from here instead of using unit GUID, which doesnt work for unit ID functions, but destName/srcName does aslong as they're in your raid.)
Idk if its a typo with the elseif event, but "SPELL_AURA_REMOVED" is the sub event from CombatLogGetCurrentEventInfo(), not main event just incase.

Also unless im too tired, spellID is the 10th argument not 11th for UnitDebuff.

Where do you call UpdateRaidDebuffList?

See https://warcraft.wiki.gg/ for latest up to date API documentation. Other sites are outdated.

[fatrog]

Oh, maybe it's not the right spot for spellId, where can I get the info? because on the combatlog events page on wiki I can't find it or it shown as first.. idk why

Yes, It was a bad pasta, my bad:

local function OnEvent(_, event, _, sourceGUID, _, _, _, _, _, destGUID, _, _, spellId)
    if event == "COMBAT_LOG_EVENT_UNFILTERED" then
        if event == "SPELL_AURA_APPLIED" and spellId == 421972 then
            UpdateRaidDebuffList()
        elseif event == "SPELL_AURA_REMOVED" and spellId == 421972 then
            local destName = GetUnitName(destGUID, true)
            if destName then
                local icon = GetRaidTargetIndex(destName)
                if icon then
                    table.insert(raidTargetIcons, icon)
                    ClearRaidTargetIcon(destName)
                    print(destName .. "'s Controlled Burn debuff has been removed.")
                end
            end
        end
    end
end

[wardz]

Combat log event handling looks like this now:

local function OnEvent(self, event)
    if event == "COMBAT_LOG_EVENT_UNFILTERED" then
        local _, subEvent, _, srcGUID, srcName, _, _, dstGUID, destName, _, _, spellId = CombatLogGetCurrentEventInfo()
 
 
        if subEvent == "SPELL_AURA_APPLIED" and spellId == 421972 then
            UpdateRaidDebuffList()
        elseif subEvent == "SPELL_AURA_REMOVED" and spellId == 421972 then
            local icon = GetRaidTargetIndex(destName)
            if icon then
                table.insert(raidTargetIcons, icon)
                ClearRaidTargetIcon(destName)
                print(destName .. "'s Controlled Burn debuff has been removed.")
            end
        end
    end
end

The spellId I were refering to earlier is the one inside your UpdateRaidDebuffList function, but not in the combat log event, that one is correct.
Is 'castSuccess' a special variable return thats required for Controlled Burn? If you don't need it, the script can be simplified a lot. (Arguments for table.remove also seems incorrect, its missing the index you want to remove) Let me know and I can post a full example later.


For future cases, you might also want to look into the UNIT_AURA event. This is generally the event you want for these kind of things unless you need to track units that are not in your group or not currently targetted.