Quantcast
Edit Mode taints easily - WoWInterface
Thread Tools Display Modes
10-03-22, 08:47 AM   #1
sirpucna
A Fallenroot Satyr
Join Date: Nov 2016
Posts: 27
Edit Mode taints easily

I do something as simple as
CHAT_TAB_HIDE_DELAY = 0

soon as i hit "Edit Mode" in the 10.x client it taints.
Code:
[ADDON_ACTION_FORBIDDEN] AddOn 'Test' tried to call the protected function 'ClearTarget()
  Reply With Quote
10-03-22, 09:27 AM   #2
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,744
Yeah, most of my addons have that problem. So far only one addon doesn't do it ( or didn't a few patches back on PTR.

I think as long as you do not change any of the Blizzard frames and it seems variables there is no error.

The Options frame also has issues with certain addons being active. I haven't tied it down to anything specific yet, but thought it was linked to a custom option frame that bugsack has or just the simple use of saved variables.

*runs off to check that one addon that doesn't break*

Yep, it still doesn't break the edit mode or options access.
Here is a link to it : https://drive.google.com/drive/folde...28?usp=sharing

The only thing it doesn't do that nUI does ( which causes the issues ) are reparenting Blizzard frames.

Once I get nUI working reasonable well ( other than these error messages ) I'll be starting on my other addons so I am sure I'll find a mixture of ones that may work or not work without those errors.
__________________

Last edited by Xrystal : 10-03-22 at 10:30 AM.
  Reply With Quote
10-03-22, 09:39 AM   #3
prof17
A Murloc Raider
AddOn Author - Click to view addons
Join Date: Oct 2015
Posts: 5
Similar issue used to be on Classic for a long time - the "Enter Battleground" and "Leave Guild" buttons wouldn't work if you had any addon installed. They even added an arrow pointing to the minimap icon captioned "Use this if they try to blame addons" to one of the common libraries, it'd pop out when you were ready to enter BG.
  Reply With Quote
10-03-22, 04:46 PM   #4
Gello
A Molten Giant
AddOn Author - Click to view addons
Join Date: Jan 2005
Posts: 516
I'm finding just using the new settings panel causes taint.

1. Make an addon with this one line: Settings.RegisterAddOnCategory(Settings.RegisterCanvasLayoutCategory(CreateFrame("Frame"), "OptionsTest"))
2. Disable all addons but the addon with this one line.
3. Go into options.
4. Turn on or off Sticky Targeting or make any change to a default setting.
5. Close options to get the following:



It's kinda frustrating.
  Reply With Quote
10-03-22, 05:43 PM   #5
Fizzlemizz
I did that?
 
Fizzlemizz's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Dec 2011
Posts: 1,579
But they've got three maybe four weeks to get it all sorted. What could possibly go wrong

I can't get a Paladin character to generate any Holy power icons at all except by changing specs then woohoo, full set of runes that I can't expend.
__________________
Fizzlemizz
Maintainer of Discord Unit Frames and Discord Art.
Author of FauxMazzle, FauxMazzleHUD and Move Pad Plus.

Last edited by Fizzlemizz : 10-03-22 at 05:46 PM.
  Reply With Quote
10-03-22, 08:48 PM   #6
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,744
Originally Posted by Gello View Post
I'm finding just using the new settings panel causes taint.

1. Make an addon with this one line: Settings.RegisterAddOnCategory(Settings.RegisterCanvasLayoutCategory(CreateFrame("Frame"), "OptionsTest"))
2. Disable all addons but the addon with this one line.
3. Go into options.
4. Turn on or off Sticky Targeting or make any change to a default setting.
5. Close options to get the following:



It's kinda frustrating.
Yeah, that is one my mage portal addon is making a fuss about. So it's another one to figure out.
__________________
  Reply With Quote
10-07-22, 07:15 PM   #7
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,744
Originally Posted by Fizzlemizz View Post
But they've got three maybe four weeks to get it all sorted. What could possibly go wrong

I can't get a Paladin character to generate any Holy power icons at all except by changing specs then woohoo, full set of runes that I can't expend.
Looks like those changes have hit the PTR now .. Having problems getting the power bars to show in nUI.
__________________
  Reply With Quote
10-07-22, 08:54 PM   #8
Fizzlemizz
I did that?
 
Fizzlemizz's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Dec 2011
Posts: 1,579
The class bars for Beta seem to be working yesterday after the update both stock UI and in DUF.

Unsure about the PTR but I suspect it will catch up for these at least.
__________________
Fizzlemizz
Maintainer of Discord Unit Frames and Discord Art.
Author of FauxMazzle, FauxMazzleHUD and Move Pad Plus.
  Reply With Quote
10-07-22, 09:17 PM   #9
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,744
nah it's an nUI thing. What worked before the update no longer works due to the PlayerContainerFrame which I wasn't aware of and nUI didn't know about, before I could just reparent to my frame and move that but now I have to do two reparents. I've got it pretty much working now but doing some testing on each of my classes to make sure there aren't additional frames added into the mix.
__________________
  Reply With Quote
10-09-22, 11:05 PM   #10
clicket
A Deviate Faerie Dragon
 
clicket's Avatar
AddOn Author - Click to view addons
Join Date: Jun 2018
Posts: 12
Yeah, frustrating is an understatement. I'm not sure it's worth trying to develop for 10.0 atm. I'm certainly holding off. The taintLog is pretty funny though.
  Reply With Quote
10-15-22, 08:24 AM   #11
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,744
I've finally managed to tie down the taint between nUI and EditMode

2 files nUI has seem to trigger the error message.
nUI_InfoPanel.CombatLog.lua
nUI_InfoPanel.BattlefieldMiniMap.lua

Both of these files reparent the Blizzard frame into an infopanel on nUI's dashboard frame.

When I have bugsack/buggrabber active I get the following error whenever I go into edit mode and entering editmode. Removing these frames from nUI's file collection the error goes away. Now, whether the issue is with the Blizzard frames being still in flux for the expansion or if there is a problem with nUI's code for the particular files I can't say as there is no trail back to a line in any file in nUI itself.

Lua Code:
  1. ["message"] = "[ADDON_ACTION_FORBIDDEN] AddOn 'nUI' tried to call the protected function 'ClearTarget()'.",
  2.             ["time"] = "2022/10/15 11:56:14",
  3.             ["stack"] = "[string \"@Interface/AddOns/!BugGrabber/BugGrabber.lua\"]:519: in function <Interface/AddOns/!BugGrabber/BugGrabber.lua:519>\n[string \"=[C]\"]: in function `ClearTarget'\n[string \"@Interface/FrameXML/EditModeManager.lua\"]:1479: in function `ResetTargetAndFocus'\n[string \"@Interface/FrameXML/EditModeManager.lua\"]:1514: in function `RefreshTargetAndFocus'\n[string \"@Interface/FrameXML/EditModeManager.lua\"]:1432: in function `OnEditModeEnter'\n[string \"@Interface/FrameXML/EditModeManager.lua\"]:171: in function `EnterEditMode'\n[string \"@Interface/FrameXML/EditModeManager.lua\"]:193: in function <Interface/FrameXML/EditModeManager.lua:191>\n[string \"=[C]\"]: in function `Show'\n[string \"@Interface/FrameXML/UIParent.lua\"]:2828: in function `SetUIPanel'\n[string \"@Interface/FrameXML/UIParent.lua\"]:2632: in function `ShowUIPanel'\n[string \"@Interface/FrameXML/UIParent.lua\"]:2536: in function <Interface/FrameXML/UIParent.lua:2532>\n[string \"=[C]\"]: in function `SetAttribute'\n[string \"@Interface/FrameXML/UIParent.lua\"]:3134: in function `ShowUIPanel'\n[string \"*GameMenuFrame.xml:94_OnClick\"]:2: in function <[string \"*GameMenuFrame.xml:94_OnClick\"]:1>",
__________________
  Reply With Quote
10-15-22, 09:15 AM   #12
Fizzlemizz
I did that?
 
Fizzlemizz's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Dec 2011
Posts: 1,579
There are several reports here and Blizz. are aware of the problems. Maybe it will be fixed for pre-patch, then again...
__________________
Fizzlemizz
Maintainer of Discord Unit Frames and Discord Art.
Author of FauxMazzle, FauxMazzleHUD and Move Pad Plus.
  Reply With Quote
10-16-22, 06:11 PM   #13
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,744
Talk about inconsistent.

Just logged in with the addon again with those files commented out .. and I'm getting the error again.

Log Out to character selection
Edit the files back in
Log In - error
Log Out to character selection
Edit the files back out
Log In - no error
Log Out to character selection
Log In - no error
Log Out to character selection
Log In - no error
Log all the way out
Log In - no error

Hmm
The only thing different before the error started again was that I had my settings test addon activated.
Maybe a reload after removing the addon is not enough to remove the taint.

No Error on Edit Mode
Activate tainted addon and reload
Cause taint to happen
Deactivate addon and reload
No Error on Edit Mode

Nope that isn't the reason

Log out to character selection
Activate tainted addon and log in
Cause taint to happen
Deactivate addon and reload
No Error on Edit Mode

Nope not that .. weird

The plot thickens
__________________
  Reply With Quote
10-16-22, 06:34 PM   #14
sirpucna
A Fallenroot Satyr
Join Date: Nov 2016
Posts: 27
i had similar problems, inconsistency in taints.

i've found that any manipulation of the chat frame, no matter how small always leads to Edit Mode causing taints, if it doesn't right away, interacting with the chat frame using the mouse scroll usually does the trick.
  Reply With Quote

WoWInterface » PTR » PTR General Discussion » Edit Mode taints easily

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off