SecureActionButtonTemplate for bag slot prefers wearing over selling

GnomeIndustries · 09-17-22, 10:03 AM

I'm trying to create some custom bag slot buttons, but trying to avoid all the hassle of using ItemButton and stripping out everything Blizzard have done and replace it with what I actually want.

So I have something like:

Code:

local button = CreateFrame("Button", "GiTestButton", UIParent, "SecureActionButtonTemplate")
button:SetAttribute("type2", "item")
button:SetAttribute("item", "4_2")

-- Make it look pretty and put it somewhere, etc

Now if I have the merchant frame open and an item in slot 2 of bag 4 that cannot be worn by any class (e.g. junk item) then right clicking the button sells the item.

If, however, I have the merchant frame open and a piece of armour or a weapon in that slot then right clicking the button equips it! Which I dont want (it should behave like the standard Blizzard UI)

Note: This will sell potions and other items with an "On Use" that can't be equipped rather than trying to use them.

Has anyone else experienced this before? and is there any way around it to get the behaviour I want?

Or am I going to have to fall back to ItemButton and fighting off all the default stuff I don't want?

SDPhantom · 09-17-22, 01:30 PM

This is what the SecureActionButtonTemplate is doing.

Lua Code:

SECURE_ACTIONS.item =
    function (self, unit, button)
        local item = SecureButton_GetModifiedAttribute(self, "item", button);
        if ( not item ) then
            -- Backwards compatibility code, deprecated but still handled for now.
            local bag = SecureButton_GetModifiedAttribute(self, "bag", button);
            local slot = SecureButton_GetModifiedAttribute(self, "slot", button);
            if ( bag and slot ) then
                item = bag.." "..slot;
            else
                item = slot;
            end
        end
        if ( item ) then
            local name, bag, slot = SecureCmdItemParse(item);
            if ( IsEquippableItem(name) and not IsEquippedItem(name) ) then
                EquipItemByName(name);
            else
                SecureCmdUseItem(name, bag, slot, unit);
            end
        end
    end;

-FrameXML\SecureTemplates.lua:416

Lua Code:

function SecureCmdUseItem(name, bag, slot, target)
    if ( bag ) then
        UseContainerItem(bag, slot, target);
    elseif ( slot ) then
        UseInventoryItem(slot, target);
    else
        UseItemByName(name, target);
    end
end

-FrameXML\ChatFrame.lua:1164

Both SecureActionButtonTemplate and ContainerFrameItemButton_OnClick() run UseContainerItem(), which is a protected function. Note SecureActionButtonTemplate does explicitly check and try to equip items.

To get around this protection, we have to manipulate the cursor instead:

Lua Code:

function SellContainerItem(bag,slot)
    ClearCursor();--    Make sure cursor isn't already holding anything
    PickupContainerItem(bag,slot);--    Pickup Item
    PickupMerchantItem(0);--    "Click" Merchant Slot (any will do, but zero is commonly used to sell items)
end

GnomeIndustries · 09-23-22, 03:34 AM

Thanks for the reply.. can only get it to work for non-soulbound items. So figure I'm still doing something slightly wrong when hooking the script...

I'm doing (where self._view = CreateFrame("Button", "GiTestButton", UIParent, "SecureActionButtonTemplate")):

Code:

self._view:HookScript("OnClick", function(b, button, down) self:onClick(button) end)

onClick = function(self, button)
        print(button, MerchantFrame:IsShown(), MerchantFrame.selectedTab)
        if (button == "RightButton" and MerchantFrame:IsShown() and MerchantFrame.selectedTab ~= 2) then
            ClearCursor();--    Make sure cursor isn't already holding anything
            PickupContainerItem(self._slot.bagId, self._slot.slotId);--    Pickup Item
            PickupMerchantItem(0);--    "Click" Merchant Slot (any will do, but zero is commonly used to sell items)
            return
        end

        if (button ~= "LeftButton") then
            return
        end

        PickupContainerItem(self._slot.bagId, self._slot.slotId)
    end,

Any help would be appreciated

SDPhantom · 09-23-22, 05:11 PM

One of my personal bag management addons still calls UseContainerItem(). I had forgotten the list of exceptions to its protected status and selling to merchants was one of them.