Class coloring panels

[Othgar]

I wrote this little addon a while ago to add some panels to my UI just to pretty things up a little, I've been trying to get them class colored off and on for a while now and can't figure out what I'm doing wrong. I'd really appreciate any help I can get here, for some reason today it's driving me a little nuts.

Here's the code:

--Functions
local _, class = UnitClass("player")
local r,g,b = RAID_CLASS_COLORS[class].r, RAID_CLASS_COLORS[class].g, RAID_CLASS_COLORS[class].b
local UnitAffectingCombat = UnitAffectingCombat
local UnitExists = UnitExists
 
 
 
--Panels of Lustiness
 
--MiniMap Panel
 
local m = CreateFrame("frame","mpanel",UIParent)
m:SetWidth(256);
m:SetHeight(256);
m:SetPoint("TOPRIGHT", UIParent, "TOPRIGHT", 0, 0);
m:SetFrameStrata("LOW");    
m:SetClampedToScreen(1);
m:SetBackdrop({bgFile="Interface\\Addons\\Lust Panels\\media\\corner"});
m:SetBackdropColor(r,g,b,.5);
 
--Actionbar Panel
 
 
--[[if IsAddOnLoaded("Bartender4") then
    local a = CreateFrame("frame","apanel",UIParent);
    a:SetWidth(575);
    a:SetHeight(100);
    a:SetPoint("CENTER", UIParent, "TOP", 0, -80);
    a:SetFrameStrata("MEDIUM"); 
    a:SetClampedToScreen(1);
    a:SetBackdrop({bgFile="Interface\\Addons\\Lust Panels\\media\\bpanel"});
    a:SetScript("OnUpdate", function(self, elapsed) 
        if UnitAffectingCombat(1) then
            a:SetAlpha(.5)
        elseif UnitExists("target") then
            a:SetAlpha(.5)
        else
            a:SetAlpha(.1)
            
        end
    end)
else return
end]]--
 
--Guild Chat
 
local g = CreateFrame("frame","mpanel",UIParent)
g:SetWidth(256);
g:SetHeight(350);
g:SetPoint("BOTTOMLEFT", UIParent, "BOTTOMLEFT", 0, 0);
g:SetFrameStrata("BACKGROUND"); 
g:SetClampedToScreen(1);
g:SetBackdrop({bgFile="Interface\\Addons\\Lust Panels\\media\\lchat"});
g:SetBackdropColor(r,g,b,.5);
 
--Trade Chat
 
local t = CreateFrame("frame","mpanel",UIParent)
t:SetWidth(256);
t:SetHeight(350);
t:SetPoint("BOTTOMRIGHT", UIParent, "BOTTOMRIGHT", 0, 0);
t:SetFrameStrata("BACKGROUND"); 
t:SetClampedToScreen(1);
t:SetBackdrop({bgFile="Interface\\Addons\\Lust Panels\\media\\rchat"});
t:SetBackdropColor(r,g,b, .5);
 
 
--Top left panel
 
local q = CreateFrame("frame","mpanel",UIParent)
q:SetWidth(256);
q:SetHeight(256);
q:SetPoint("TOPLEFT", UIParent, "TOPLEFT", 0, 0);
q:SetFrameStrata("MEDIUM"); 
q:SetClampedToScreen(1);
q:SetBackdrop({bgFile="Interface\\Addons\\Lust Panels\\media\\tlcorner"});
q:SetBackdropColor(r,g,b,.5);

[Aftermathhqt]

Originally Posted by Othgar I wrote this little addon a while ago to add some panels to my UI just to pretty things up a little, I've been trying to get them class colored off and on for a while now and can't figure out what I'm doing wrong. I'd really appreciate any help I can get here, for some reason today it's driving me a little nuts. Here's the code: --Functions local _, class = UnitClass("player") local r,g,b = RAID_CLASS_COLORS[class].r, RAID_CLASS_COLORS[class].g, RAID_CLASS_COLORS[class].b local UnitAffectingCombat = UnitAffectingCombat local UnitExists = UnitExists       --Panels of Lustiness   --MiniMap Panel   local m = CreateFrame("frame","mpanel",UIParent) m:SetWidth(256); m:SetHeight(256); m:SetPoint("TOPRIGHT", UIParent, "TOPRIGHT", 0, 0); m:SetFrameStrata("LOW");    m:SetClampedToScreen(1); m:SetBackdrop({bgFile="Interface\\Addons\\Lust Panels\\media\\corner"}); m:SetBackdropColor(r,g,b,.5);   --Actionbar Panel     --[[if IsAddOnLoaded("Bartender4") then     local a = CreateFrame("frame","apanel",UIParent);     a:SetWidth(575);     a:SetHeight(100);     a:SetPoint("CENTER", UIParent, "TOP", 0, -80);     a:SetFrameStrata("MEDIUM");     a:SetClampedToScreen(1);     a:SetBackdrop({bgFile="Interface\\Addons\\Lust Panels\\media\\bpanel"});     a:SetScript("OnUpdate", function(self, elapsed)         if UnitAffectingCombat(1) then             a:SetAlpha(.5)         elseif UnitExists("target") then             a:SetAlpha(.5)         else             a:SetAlpha(.1)                     end     end) else return end]]--   --Guild Chat   local g = CreateFrame("frame","mpanel",UIParent) g:SetWidth(256); g:SetHeight(350); g:SetPoint("BOTTOMLEFT", UIParent, "BOTTOMLEFT", 0, 0); g:SetFrameStrata("BACKGROUND"); g:SetClampedToScreen(1); g:SetBackdrop({bgFile="Interface\\Addons\\Lust Panels\\media\\lchat"}); g:SetBackdropColor(r,g,b,.5);   --Trade Chat   local t = CreateFrame("frame","mpanel",UIParent) t:SetWidth(256); t:SetHeight(350); t:SetPoint("BOTTOMRIGHT", UIParent, "BOTTOMRIGHT", 0, 0); t:SetFrameStrata("BACKGROUND"); t:SetClampedToScreen(1); t:SetBackdrop({bgFile="Interface\\Addons\\Lust Panels\\media\\rchat"}); t:SetBackdropColor(r,g,b, .5);     --Top left panel   local q = CreateFrame("frame","mpanel",UIParent) q:SetWidth(256); q:SetHeight(256); q:SetPoint("TOPLEFT", UIParent, "TOPLEFT", 0, 0); q:SetFrameStrata("MEDIUM"); q:SetClampedToScreen(1); q:SetBackdrop({bgFile="Interface\\Addons\\Lust Panels\\media\\tlcorner"}); q:SetBackdropColor(r,g,b,.5);

AftermathhUI.Class = select(2, UnitClass('player'))
AftermathhUI.Classcolor = RAID_CLASS_COLORS[AftermathhUI.Class]

This what i use

[Haleth]

Actually your code should work... not sure what's wrong with it.

Try printing it and see what it returns.

Are you getting any lua errors? Maybe the texture is invalid. I'm not sure if textures with spaces in them are allowed.

[Aftermathhqt]

Originally Posted by Haleth Actually your code should work... not sure what's wrong with it. Try printing it and see what it returns. Are you getting any lua errors? Maybe the texture is invalid.

local r,g,b = RAID_CLASS_COLORS[class].r, RAID_CLASS_COLORS[class].g, RAID_CLASS_COLORS[class].b

is wrong

should be

RAID_CLASS_COLORS[AftermathhUI.Class]

only

[Haleth]

You shouldn't assume that everyone uses your UI.

[Aftermathhqt]

Originally Posted by Haleth You shouldn't assume that everyone uses your UI.

It's an example.. how i am using it..

[Haleth]

The thing is that his code works so there is no reason to change it. Your code is actually exactly the same, just written in a different way.

[Othgar]

I tried printing it and got nothing. I'm lost here lol I use the same method to class color my XP bar addon and it works fine for that.

This is the relevant code from my XP Bar addon:

local ThousandSeparator = ","
local TipTitle = "Tribal XP"
local _, class = UnitClass("player")
local r,g,b = RAID_CLASS_COLORS[class].r, RAID_CLASS_COLORS[class].g, RAID_CLASS_COLORS[class].b
 
 
local function FmtBigNum(n)
        local left, num, right = string.match(n .. "", '^([^%d]*%d)(%d*)(.-)')
        return left..(num:reverse():gsub('(%d%d%d)', '%1'.. ","):reverse())..right
end
 
local TribalExperienceBar = CreateFrame("StatusBar","TribalExperienceBar",UIParent)
TribalExperienceBar:SetWidth(95);
TribalExperienceBar:SetHeight(50);
TribalExperienceBar:SetPoint("CENTER", UIParent, "CENTER", 0, 0);
TribalExperienceBar:SetFrameStrata("MEDIUM");   
TribalExperienceBar:SetClampedToScreen(1);
TribalExperienceBar:SetBackdrop({bgFile="Interface\\Tooltips\\UI-Tooltip-Background", edgeFile="", tile=1, tileSize=10, edgeSize=10, insets={left=2, right=2, top=2, bottom=2}});
TribalExperienceBar:SetBackdropColor(r,g,b,0)
TribalExperienceBar:SetMovable(1);
TribalExperienceBar:EnableMouse(1);
 
TribalExperienceBar:SetStatusBarTexture("Interface\\AddOns\\TXP\\media\\xptexture_rentaire")
TribalExperienceBar:SetStatusBarColor(r,g,b)
TribalExperienceBar:SetAlpha(.5)

[Phanx]

Originally Posted by Game92 local r,g,b = RAID_CLASS_COLORS[class].r, RAID_CLASS_COLORS[class].g, RAID_CLASS_COLORS[class].b is wrong should be RAID_CLASS_COLORS[AftermathhUI.Class] only

It's not wrong, actually.

1. He clearly defined the variable class on the line before the one you're claiming is wrong.

2. Later in the code, he is clearly using three separate variables r, g, and b, instead of looking them up every time he wants to use them (eg. color.r and so forth) which would be a pointless waste of CPU time anyway. The only reason to look up the values "on demand" instead of upvaluing them at runtime is if you expect them to change at unpredictable times while you are logged in, or if they change at predictable times (eg. an event fires to indicate that they've changed) but change more often than you need to use them (so it's more efficient to just look them up on use instead of every time they change).

I don't even know how you looked at any of the code he posted and picked out that one, obviously-correct line and decided it was wrong...

[Haleth]

Othgar; Try using a texture without a space in its name, I'm fairly convinced that's the problem because the code in your OP works for me (using a different texture though ofc).

[Othgar]

Originally Posted by Phanx It's not wrong, actually. 1. He clearly defined the variable class on the line before the one you're claiming is wrong. 2. Later in the code, he is clearly using three separate variables r, g, and b, instead of looking them up every time he wants to use them (eg. color.r and so forth) which would be a pointless waste of CPU time anyway. The only reason to look up the values "on demand" instead of upvaluing them at runtime is if you expect them to change at unpredictable times while you are logged in, or if they change at predictable times (eg. an event fires to indicate that they've changed) but change more often than you need to use them (so it's more efficient to just look them up on use instead of every time they change). I don't even know how you looked at any of the code he posted and picked out that one, obviously-correct line and decided it was wrong...

So then I guess it's right (?)... but it still doesn't work.

[Othgar]

Originally Posted by Haleth Othgar; Try using a texture without a space in its name, I'm fairly convinced that's the problem because the code in your OP works for me (using a different texture though ofc).

OK I'll rename the textures and see if that does the trick. Thanks Haleth.

Wait none of the textures have names with spaces... corner, lchat, rchat and tlcorner are the texture names.

[Haleth]

"Lust Panels" has a space.

[Phanx]

On the other hand, there are several actual issues with your code. In no particular order:

#1 - I can't see your actual textures, but in your code, you specify something like "width = 256, height = 350". If the actual pixel dimensions of your texture are 256 x 350, this is why it does not work. WoW will only recognize texture files whose pixel dimensions are powers of 8. To get a different size in-game, you can either resize the texture with SetSize (or SetWidth and SetHeight if you don't like shortcuts), or you can use multiple textures and position them adjacent to each other if you see too much distortion through resizing.

#2 - You give every panel frame the same global name, "mpanel". If you want the panels to be accessible from outside the file, you need to give them unique names, and I'd suggest something more descriptive, like "LustMinimapPanel" or "LustGuildChatPanel". If you don't need them to be accessible from outside, don't give them global names at all.

#3 - Using an OnUpdate script to watch for changes which have an associated event is hugely inefficient. Instead, use an OnEvent script, and register the frame for the relevant events (eg. PLAYER_TARGET_CHANGED fires when your target changes, including when you no longer have one, and PLAYER_REGEN_DISABLED and PLAYER_REGEN_ENABLED fire when you enter or leave combat, respectively).

#4 - Using a space in your addon's folder name is not recommended, due to the way operating systems handle spaces in file paths. I can't say for sure that this will cause any problems, but you should just stick to convention and rename your addon folder and TOC from "Lust Panels" to "LustPanels".

#5 - You should probably just parent some of these panels to the frame they're relevant to. The minimap panel, for example, should probably be parented to the minimap. This way, if someone moves the minimap, the panel will move with it.

#6 - For panels that do not need any scripts or mouse interactivity, you should just use a texture instead of a frame.

[Othgar]

Originally Posted by Haleth "Lust Panels" has a space.

Ok so rename the main folder and TOC then got it.

Originally Posted by Phanx On the other hand, there are several actual issues with your code. In no particular order: #1 - I can't see your actual textures, but in your code, you specify something like "width = 256, height = 350". If the actual pixel dimensions of your texture are 256 x 350, this is why it does not work. WoW will only recognize texture files whose pixel dimensions are powers of 8. To get a different size in-game, you can either resize the texture with SetSize (or SetWidth and SetHeight if you don't like shortcuts), or you can use multiple textures and position them adjacent to each other if you see too much distortion through resizing. #2 - You give every panel frame the same global name, "mpanel". If you want the panels to be accessible from outside the file, you need to give them unique names, and I'd suggest something more descriptive, like "LustMinimapPanel" or "LustGuildChatPanel". If you don't need them to be accessible from outside, don't give them global names at all. #3 - Using an OnUpdate script to watch for changes which have an associated event is hugely inefficient. Instead, use an OnEvent script, and register the frame for the relevant events (eg. PLAYER_TARGET_CHANGED fires when your target changes, including when you no longer have one, and PLAYER_REGEN_DISABLED and PLAYER_REGEN_ENABLED fire when you enter or leave combat, respectively). #4 - Using a space in your addon's folder name is not recommended, due to the way operating systems handle spaces in file paths. I can't say for sure that this will cause any problems, but you should just stick to convention and rename your addon folder and TOC from "Lust Panels" to "LustPanels". #5 - You should probably just parent some of these panels to the frame they're relevant to. The minimap panel, for example, should probably be parented to the minimap. This way, if someone moves the minimap, the panel will move with it. #6 - For panels that do not need any scripts or mouse interactivity, you should just use a texture instead of a frame.

#1 The panels all work and the sizes are set to make them fit my UI. The only problem I am having is Class coloring the textures, they show up fine as they are just not colored.

#2 Honestly didn't even notice that I did that but I'll take a look at fixing it when I get them class colored.

#3 The on update script was the only way I could get the alpha to change with my Bartender4 bars. It is commented out because I have since moved the bars and that texture is no longer used. I tried to find a better method of doing this but was unable to do so See here

#4 Will be fixing this after I finish this post.

#5 I'm not really worried about anyone else moving the panels since I will probably never release this addon unless I include it as part of a full UI. And these textures won't look very good anywhere but where they are anyways.

#6 This is probably true, but since I'm pretty new to Lua and was a lot newer when I wrote it, this was the only way I knew how to do it. It works so I'm not worried about changing it unless I decide to release it as a complete UI.

[Othgar]

I changed the addon name to LustPanels, changed the name of its folder to LustPanels, and Changed the TOC to LustPanels, gave each frame a unique name, and disabled everything but LustPanels and ACP and still no dice. all I get when I print the r, g, b is 0.96 ...grrr.. so here's the TOC and the Lua for the whole addon.

Lua:

-- Lust Panels, and some other neat UI stuff gathered from various sources to make my life easier.
 
--Functions
local _, class = UnitClass("player")
local r,g,b = RAID_CLASS_COLORS[class].r, RAID_CLASS_COLORS[class].g, RAID_CLASS_COLORS[class].b
local UnitAffectingCombat = UnitAffectingCombat
local UnitExists = UnitExists
 
 
 
 
--Panels of Lustiness
 
--MiniMap Panel
 
local m = CreateFrame("frame","LustMinimapPanel",UIParent)
m:SetWidth(256);
m:SetHeight(256);
m:SetPoint("TOPRIGHT", UIParent, "TOPRIGHT", 0, 0);
m:SetFrameStrata("LOW");    
m:SetClampedToScreen(1);
m:SetBackdrop({bgFile="Interface\\Addons\\LustPanels\\media\\corner"});
m:SetBackdropColor(r,g,b);
m:SetAlpha(.5);
 
--Actionbar Panel
 
 
--[[if IsAddOnLoaded("Bartender4") then
    local a = CreateFrame("frame","LustBT4Panel",UIParent);
    a:SetWidth(575);
    a:SetHeight(100);
    a:SetPoint("CENTER", UIParent, "TOP", 0, -80);
    a:SetFrameStrata("MEDIUM"); 
    a:SetClampedToScreen(1);
    a:SetBackdrop({bgFile="Interface\\Addons\\LustPanels\\media\\bpanel"});
    a:SetScript("OnUpdate", function(self, elapsed) 
        if UnitAffectingCombat(1) then
            a:SetAlpha(.5)
        elseif UnitExists("target") then
            a:SetAlpha(.5)
        else
            a:SetAlpha(.1)
            
        end
    end)
else return
end]]--
 
--Guild Chat
 
local g = CreateFrame("frame","LustGChatPanel",UIParent)
g:SetWidth(256);
g:SetHeight(350);
g:SetPoint("BOTTOMLEFT", UIParent, "BOTTOMLEFT", 0, 0);
g:SetFrameStrata("BACKGROUND"); 
g:SetClampedToScreen(1);
g:SetBackdrop({bgFile="Interface\\Addons\\LustPanels\\media\\lchat"});
g:SetBackdropColor(r,g,b);
g:SetAlpha(.5);
 
--Trade Chat
 
local t = CreateFrame("frame","LustTChatPanel",UIParent)
t:SetWidth(256);
t:SetHeight(350);
t:SetPoint("BOTTOMRIGHT", UIParent, "BOTTOMRIGHT", 0, 0);
t:SetFrameStrata("BACKGROUND"); 
t:SetClampedToScreen(1);
t:SetBackdrop({bgFile="Interface\\Addons\\LustPanels\\media\\rchat"});
t:SetBackdropColor(r,g,b);
t:SetAlpha(.5);
 
 
--Top left panel
 
local q = CreateFrame("frame","LustTopLeftPanel",UIParent)
q:SetWidth(256);
q:SetHeight(256);
q:SetPoint("TOPLEFT", UIParent, "TOPLEFT", 0, 0);
q:SetFrameStrata("MEDIUM"); 
q:SetClampedToScreen(1);
q:SetBackdrop({bgFile="Interface\\Addons\\LustPanels\\media\\tlcorner"});
q:SetBackdropColor(r,g,b);
q:SetAlpha(.5);
 
-- Hides ALL error messages
 
UIErrorsFrame:Clear()
 
--More responsive chat tabs
 
CHAT_FRAME_TAB_SELECTED_MOUSEOVER_ALPHA = 1
CHAT_FRAME_TAB_SELECTED_NOMOUSE_ALPHA = 0
CHAT_TAB_HIDE_DELAY = 0
CHAT_FRAME_TAB_ALERTING_MOUSEOVER_ALPHA = 1
CHAT_FRAME_TAB_ALERTING_NOMOUSE_ALPHA = 0
CHAT_FRAME_TAB_NORMAL_MOUSEOVER_ALPHA = 1
CHAT_FRAME_TAB_NORMAL_NOMOUSE_ALPHA = 0
 
-- Making the chattabs invisible until mouseover
 
CHAT_FRAME_TAB_SELECTED_MOUSEOVER_ALPHA = 0.4
CHAT_FRAME_TAB_SELECTED_NOMOUSE_ALPHA = 0
 
CHAT_FRAME_TAB_ALERTING_MOUSEOVER_ALPHA = 0
CHAT_FRAME_TAB_ALERTING_NOMOUSE_ALPHA = 0
 
CHAT_FRAME_TAB_NORMAL_MOUSEOVER_ALPHA = 0.4
CHAT_FRAME_TAB_NORMAL_NOMOUSE_ALPHA = 0
 
-- Blizz Raid Frame hider
 
CompactRaidFrameManager:UnregisterAllEvents() 
CompactRaidFrameManager:Hide() 
CompactRaidFrameContainer:UnregisterAllEvents() 
CompactRaidFrameContainer:Hide() 
 
-- Forcing classcolors on
 
local frame=CreateFrame("Frame");
frame:RegisterEvent("UPDATE_CHAT_COLOR_NAME_BY_CLASS");
frame:SetScript("OnEvent",function(self,event,type,set)
    if not set then SetChatColorNameByClass(type,true); end
end);
 
-- /rl reloadUI
 
SlashCmdList['RELOAD'] = function() ReloadUI() end
SLASH_RELOAD1 = '/rl'
 
--/rc Ready Check /role RoleCheck
 
SLASH_ROLECHECK1 = "/role"
SLASH_ROLECHECK2 = "/rolecheck"
SlashCmdList["ROLECHECK"] = function(self, txt)
  InitiateRolePoll()
end
 
SLASH_READYCHECK1 = "/rc"
SlashCmdList["READYCHECK"] = function(self, txt)
  DoReadyCheck()
end

## Interface: 40300
## Author: Othgar/Lust
## Title: Lust Panels	
## Version: 1.0
## Notes: Panels of lusti-tribali-ness-esque
## OptionalDeps: Bartender4


panels.lua

and here's a .zip of the addon including the textures. Thanks for helping me out guys!
LustPanels.zip

[Phanx]

That said, I loaded your code in-game and discovered one other (fairly major) issue. You defined your color values as r, g, and b, but then you later assign the variable name g to your guild chat panel, so the coloring of all further panels (everything except the minimap panel) is wrong, because :SetBackdropColor ignores any non-number values passed to it, so you're losing the green color information.

Other than that, though, all of the panels are colored, and after I changed the local variable name for the guild chat panel, they're all the correct class color.

The only other change I made before testing was to alter the bgFile texture paths to a file that actually exists on my system.

If the code isn't working for you (after changing the guild chat panel's local variable name) I don't really know why. The only things I can suggest:

#1 - Try manually setting the color of a panel in-game:

/run local c=RAID_CLASS_COLORS.SHAMAN mpanel:SetBackdropColor(c.r, c.g, c.b, 0.5)

Change SHAMAN to the name of your class, if you want.

#2 - Try to load only the code you posted, in its own addon, with all other addons disabled.

If neither of those work, then there is something severely wrong with your WoW installation, and you should delete the Cache folder and then run the Repair.exe tool.

[Othgar]

Originally Posted by Phanx That said, I loaded your code in-game and discovered one other (fairly major) issue. You defined your color values as r, g, and b, but then you later assign the variable name g to your guild chat panel, so the coloring of all further panels (everything except the minimap panel) is wrong, because :SetBackdropColor ignores any non-number values passed to it, so you're losing the green color information. Other than that, though, all of the panels are colored, and after I changed the local variable name for the guild chat panel, they're all the correct class color. The only other change I made before testing was to alter the bgFile texture paths to a file that actually exists on my system. If the code isn't working for you (after changing the guild chat panel's local variable name) I don't really know why. The only things I can suggest: #1 - Try manually setting the color of a panel in-game: /run local c=RAID_CLASS_COLORS.SHAMAN mpanel:SetBackdropColor(c.r, c.g, c.b, 0.5) Change SHAMAN to the name of your class, if you want. #2 - Try to load only the code you posted, in its own addon, with all other addons disabled. If neither of those work, then there is something severely wrong with your WoW installation, and you should delete the Cache folder and then run the Repair.exe tool.

Thanks Phanx I thried coloring it in-game and it didn't change the color, but I could see the alpha changing if I changed the value. I think there has to be an issue with my textures. It's the only thing really left. Just for good measure though I deleted the cache folder and ran the repair tool and it said there were no problems found.

Update:

I recolored the MinimapPanel texture to solid white and it works fine now. Apparently the solid black can't be colored by Lua.

[Seerah]

Yes. If you want to color your textures, it's best if they're white (or a similarly light color). Think of the textures as paper. If you are using black paper, you won't notice what color is drawn on top of it.

[Othgar]

Originally Posted by Seerah Yes. If you want to color your textures, it's best if they're white (or a similarly light color). Think of the textures as paper. If you are using black paper, you won't notice what color is drawn on top of it.

Man I feel like an idiot now lol. But at least all is working as it's supposed to now. Thanks a lot for the help everyone. You guys rock!