Module options not displaying..

[myrroddin]

I am following along this thread to create modules for my latest build of SmartRes2. Obviously, I am missing something, because the options for SmartRes2_Chat are not showing up in SmartRes2, either by Interace/AddOns, or the LDB/minimap buttons.

I don't have SmartRes2_Chat set as LoadOnDemand, but I'd like to; I'm trying to debug first. There are no errors in either SmartRes2 or SR2C. BugSack is quiet.

About posting my code. While both the core and the module are tiny, I think it best to post both, because I can't tell which is not working. Therefore, I am attaching .zip files. Sorry about the SVN hooks and files, please ignore those. And I certainly do not expect anyone to make commits.

What I do see when opening Interface/AddOn is exactly what you'd expect with no modules. The main options tab and the profiles tab.

And yes, I know that SmartRes2_Chat currently does nothing, but at the very least its options should be displayed at this point.

[Seerah]

I don't have much time at the moment, but look at sStats and its modules.

[myrroddin]

Seerah, thank you for the the tip. Because you handle modules differently, it didn't help me. I am using AceAddon-3.0 to handle modules.

As far as I can tell, because there are no errors unless I purposely break something, the module is being loaded.

The disconnect is getting the module options into the core display. I have tried putting in a saved variables line into SmartRes2_Chat's toc, and tried without. I have tried both an SV and matching it as the name in RegisterNamespace, and treating the name as a simple string. In the section 24 - 30, I have tried multiple variations of options.args.blah.

I have tried so many variants of line 28 it makes my head swim. Originally I had line 28 exactly as Phanx wrote in the linked thread above, only substituting name, module for k, v, but those are just variable names.

Except for the third argument for AceDialog, AddToBlizOptions has been passed SmartRes2, name, module, and a few combinations thereof. What you see is the latest iteration.

I am at a total loss as to why something so simple isn't working. And this is why I attached the whole addon zips.

function SmartRes2:OnInitialize()
    -- register saved variables with AceDB
    self.db = LibStub("AceDB-3.0"):New("SmartRes2DB", defaults, true)
    db = self.db.profile
 
    -- db update callbacks
    self.db.RegisterCallback(self, "OnProfileChanged", "Refresh")
    self.db.RegisterCallback(self, "OnProfileCopied", "Refresh")
    self.db.RegisterCallback(self, "OnProfileReset", "Refresh")
 
    local options = self:GetOptions()
    Registry:RegisterOptionsTable("SmartRes2", options)
 
    options.args.profile = LibStub("AceDBOptions-3.0"):GetOptionsTable(self.db)
    options.args.profile.order = -1 
 
    -- dual spec the options
    LDS:EnhanceDatabase(self.db, "SmartRes2")
    LDS:EnhanceOptions(options.args.profile, self.db)   
 
    Dialog:AddToBlizOptions("SmartRes2", "SmartRes2", nil, "general")
 
    -- now embed module options into SmartRes2's options
    for name, module in self:IterateModules() do
        if type(module.GetOptions) == "function" then
            options.args[name] = module:GetOptions()
            local displayName = options.args[name].name
            Dialog:AddToBlizOptions("SmartRes2", displayName, "SmartRes2", options.args[name])
        end
    end
end

... And the module's OnInit

function Chat:OnInitialize()
    -- get our defaults table
    local defaults = self:GetDefaults()
 
    self.db = SmartRes2.db:RegisterNamespace("Chat", defaults)
    self:SetEnabledState(SmartRes2:GetModuleEnabled("Chat"))
end

[Seerah]

Did you look at the GetModuleOptions function on line 353 of sStats.lua?

It's called in this bit in the OnInitialize function (lines 498-500)

for k,v in pairs(modules) do
        GetModuleOptions(v:GetName())
    end

[myrroddin]

I looked at your code, slept on it, mulled it over, looked at it again. While I did learn some things, I found myself confused because your code knows the module options, like X, Y, input text. Your options are static.

However, my options for the modules are dynamic, so I don't think I can borrow your code. If I am wrong, please elaborate!

In the meantime, I tried some things. For instance, I moved the defaults and options fetch functions for the module out of their own .lua files and into the core module code. Also, I adjusted the get/set functions to db[info[#info]] format.

That done, I made sure everything else exactly matched the code Phanx wrote for BasicUI, as cokedrivers said his Buffs module and core addon were working.

So far so good, except I still don't see my module's options displaying with SmartRes2 set as the parent.

Right, that means I added some print statements. In SmartRes2:OnInit()'s module iterator, it looks like this:

-- now embed module options into SmartRes2's options
for name, module in self:IterateModules() do
    self:Printf("module name is %s", name)
    self:Printf("Module options type is %s", tostring(type(module.GetOptions)))
    if type(module.GetOptions) == "function" then
        options.args[name] = module:GetOptions()
        local displayName = options.args[name].name
        Dialog:AddToBlizOptions("SmartRes2", displayName, "SmartRes2", name)
    end
end

And lo and behold, neither of the self:Printf calls print anything. It's like the iterator isn't firing, or it isn't getting any data from the module.

That gives me something to work with, but I have no clue why it isn't picking up the module...

[Seerah]

The insertion of module options is the same, no matter where it comes from. In sStats, the core provides the module options by inserting the data table into the main options table. Any module that wants to provide additional options that the core does not know about, would then insert into the appropriate table.

If the core does not handle the module options table, then the module itself would insert its options data table into the main options table.

Isolated out of my GetModuleOptions function.

local options = sStatsOptionsTable
[...]
options.args[module] = {
    name = module,
    type = "group",
    args = {
        [...]
    }
sStats.optionsFrame[module] = LibStub("AceConfigDialog-3.0"):AddToBlizOptions("sStats", module, "sStats", module)

/edit: and what is your self:IterateModules() method doing? What does it return?

[myrroddin]

I'm still working on trying to get it to work, but now there will be a delay until after the holidays. Just wanted to say something so you weren't hanging, wonder if I have fixed it - I haven't yet.

[myrroddin]

Good news everyone! I got the slime flowing again!! Er, I mean I figured out how to get the chat module to display in the main options window after looking at KUI Nameplates code.

However, it is not obeying the default values. All the defaults for the Chat module that are Boolean are set to true, but the display has them as false, or empty checkboxes.

What I don't know for sure is whether that's because I have handler = module, or because the options table for the module get/set are wrong with self.db.profile.blah where "self" is module.db, or both are wrong.

I have not handled the SV random table code yet within Chat.lua, because it probably will be easier to find out how to do that once I figure out how/why the Booleans aren't working. Baby steps.

For reference, here is first the code for SmartRes2.lua, and then Chat.lua (the module code). Seerah, as muddled as my brain is, I want to thank you very much for your help to this point. Without your prompting, I would never have gotten this far.

function SmartRes2:OnInitialize()
    -- register saved variables with AceDB
    self.db = LibStub("AceDB-3.0"):New("SmartRes2DB", defaults, true)
    db = self.db.profile
 
    -- db update callbacks
    self.db.RegisterCallback(self, "OnProfileChanged", "Refresh")
    self.db.RegisterCallback(self, "OnProfileCopied", "Refresh")
    self.db.RegisterCallback(self, "OnProfileReset", "Refresh")
 
    local options = self:GetOptions()
    
    -- now embed module options into SmartRes2's options
    function SmartRes2:InitializeModuleOptions(module)
        if not module.GetOptions then
            return
        end
        table_insert(modules, module) -- modules is file-scope
        local opts = module:GetOptions()
        local name = module.uiName or module:GetName()
 
        options.args[name] = {
            name = name,
            handler = module,
            type = "group",
            childGroups = "tab",
            order = 10 + #self.modules,
            args = opts
        }
    end
 
    -- add profiles to options table
    options.args.profile = LibStub("AceDBOptions-3.0"):GetOptionsTable(self.db)
    options.args.profile.order = -1
 
    -- dual spec the options
    LDS:EnhanceDatabase(self.db, "SmartRes2")
    LDS:EnhanceOptions(options.args.profile, self.db)
 
    Registry:RegisterOptionsTable("SmartRes2", options)
    Dialog:AddToBlizOptions("SmartRes2")
end

-- upvalue the globals --------------------------------------------------------
local _G = getfenv(0)
local LibStub = _G.LibStub
local math_random = _G.math.random
 
-- declare our module ---------------------------------------------------------
local SmartRes2 = LibStub("AceAddon-3.0"):GetAddon("SmartRes2")
local Chat = SmartRes2:NewModule("Chat", "AceConsole-3.0", "AceEvent-3.0")
local L = LibStub("AceLocale-3.0"):GetLocale("SmartRes2")
Chat.uiName = CHAT_OPTIONS_LABEL
 
-- update localization table --------------------------------------------------
SmartRes2.L = L
 
-- get LibResInfo-1.0 ---------------------------------------------------------
local LRI = LibStub("LibResInfo-1.0")
 
-- defaults table -------------------------------------------------------------
function Chat:GetDefaults()
    local defaults = {
        profile = {
            chatType = "GROUP",
            enableModule = true,
            massResMessage = {
                "I am casting %s",
                "Mass resurrection for you! And you! And you! For everybody!",
                "All your mass resurrections are belong to me!",
                "I am in your graves, casting %s",
                "Free mass resurrections for all of you!",
                "You are all getting mass resurrected. However, I do not guarantee all your parts are intact."
            },
            notifyCollision = "WHISPER",
            notifyExpired = true,
            notifyResCancelled = true,
            notifyResEnded = true,
            notifySelf = true,
            randChatTbl = {
                "%p is bringing %t back to life!",
                "Filthy peon! %p has to resurrect %t!",
                "%p has to wake %t from eternal slumber.",
                "%p is ending %t's dirt nap.",
                "No fallen heroes! %p needs %t to march forward to victory!",
                "%p doesn't think %t is immortal, but after this res cast, it is close enough.",
                "Sleeping on the job? %p is disappointed in %t.",
                "%p knew %t couldn't stay out of the fire. *Sigh*",
                "Once again, %p pulls %t and their bacon out of the fire.",
                "%p thinks %t should work on their Dodge skill.",
                "%p refuses to accept blame for %t's death, but kindly undoes the damage.",
                "%p grabs a stick. A-ha! %t was only temporarily dead.",
                "%p is ressing %t",
                "%p knows %t is faking. It was only a flesh wound!",
                "Oh. My. God. %p has to breathe life back into %t AGAIN?!?",
                "%p knows that %t dying was just an excuse to see another silly random res message.",
                "Think that was bad? %p proudly shows %t the scar tissue caused by Hogger.",
                "Just to be silly, %p tickles %t until they get back up.",
                "FOR THE HORDE! FOR THE ALLIANCE! %p thinks %t should be more concerned about yelling FOR THE LICH KING! and prevents that from happening.",
                "And you thought the Scourge looked bad. In about 10 seconds, %p knows %t will want a comb, some soap, and a mirror.",
                "Somewhere, the Lich King is laughing at %p, because he knows %t will just die again eventually. More meat for the grinder!!",
                "%p doesn't want the Lich King to get another soldier, so is bringing %t back to life.",
                "%p wonders about these stupid res messages. %t should just be happy to be alive.",
                "%p prays over the corpse of %t, and a miracle happens!",
                "In a world of resurrection spells, why are NPC deaths permanent? It doesn't matter, since %p is making sure %t's death isn't permanent.",
                "%p performs a series of lewd acts on %t's still warm corpse. Ew."
            },
            restoreMassResMsgs = {},
            restoreRndChatTbl = {}
        }
    }
    return defaults
end
 
-- options table --------------------------------------------------------------
function Chat:GetOptions()
    local options = {
        enabled = {
            name = ENABLE,
            desc = L["Toggle module on/off."],
            type = "toggle",
            order = 10,
            get = function() return self.db.profile.enableModule end,
            set = function(info, value)
                self.db.profile.enableModule = value
                if value then
                    self:Enable()
                else
                    self:Disable()
                end
            end
        },
        selfNotification = {
            name = L["Self Notification"],
            desc = L["This tab controls messages only you can see."],
            type = "group",
            order = 20,
            args = {
                expired = {
                    name = L["Victim Resurrected Expiration"],
                    desc = L["Lets you know the victim did not accept their resurrection and can be resurrected again."],
                    type = "toggle",
                    order = 10,
                    get = function() return self.db.profile.notifyExpired end,
                    set = function(info, value)
                        self.db.profile.notifyExpired = value
                    end
                },
                cancelled = {
                    name = L["Caster Cancelled Resurrection"],
                    desc = L["Another caster (not you) cancelled their resurrection."],
                    type = "toggle",
                    order = 20,
                    get = function() return self.db.profile.notifyResCancelled end,
                    set = function(info, value)
                        self.db.profile.notifyResCancelled = value
                    end
                },
                ended = {
                    name = L["Caster Finished Cast"],
                    desc = L["Another caster (not you) completed casting their spell."],
                    type = "toggle",
                    order = 30,
                    get = function() return self.db.profile.notifyResEnded end,
                    set = function(info, value)
                        self.db.profile.notifyResEnded = value
                    end
                },
                myCasts = {
                    name = L["My Resurrections"],
                    desc = L["Tells you whom you are resurrecting, or casting a mass resurrection, or raising the Creator from the dead."],
                    type = "toggle",
                    order = 40,
                    get = function() return self.db.profile.notifySelf end,
                    set = function(info, value)
                        self.db.profile.notifySelf = value
                    end
                }
            }
        }
    }
    return options
end
 
function Chat:OnInitialize()
   self.db = SmartRes2.db:RegisterNamespace(Chat:GetName(), defaults)
   SmartRes2:InitializeModuleOptions(self)
   -- self:SetEnabledState(self.db.profile.enableModule)
end
 
function Chat:OnEnable()
end
 
function Chat:OnDisable()
    -- LRI.UnregisterAllCallbacks(self)
end