GoldFish Addon Idea!

[Grim077]

I cannot make this addon Myself so i'm asking if anyone would be willing to make it.

GoldFish

Is an addon that Selects a Quest item that is worth the most Gold,
The other thing this addon does is,
it also shows the Items you may be able to use, Judging by your Class,
Maybe Useful to you,
Is worth the most gold,

Such as an Item that might be better then what you have Equipped,
So that you don't over look the item and wish that you knew where i lived so you
Could find me and Kill me because of it, so anyway this is a pretty Nifty addon
Idea If i do say so my self

[humfras]

OneChoice by Kaelten features something like this.

http://wow.curse.com/downloads/wow-a...onechoice.aspx

[Grim077]

yeah but i'm not looking for stats i'm looking for one to tell you what one give you the most Gold.

[Talyrius]

Have you looked at VendorBait?

[Vlad]

The only issue I see is that the default frame has a limit of like, 4 or 6 quest rewards -so having a quest that rewards let's say, 5 items, then you only got room for 1 more button on it without having to alter and add more frames, and basically having to do a lot of more work to make it show properly.

On the topic of "is this better for you" is a big project, I've so far used askmrrobot stats weight for (was some work, haven't had time to do the other classes) and pretty much managed to get some sort of score number that returns a positive integer if the gear is a upgrade or negative if not, the better the higher score, i.e. 0-50 minor and must be consulted with player, while anything over 50 is a define upgrade (or something like this).

Oh I am talking nonsense now! Well in any case, are there any known libraries to help check for what item is better for you (comparing two items)? So far I think not, I tried to find but found none... If not I could release a libstub that people could use in their addons to find out what item is better for players spec.

[humfras]

Originally Posted by Grim077 yeah but i'm not looking for stats i'm looking for one to tell you what one give you the most Gold.

Well, that's what the golden "MV" symbol is displaying...

[SDPhantom]

This is code that I wrote for this exact purpose. I changed it from actually selecting the item to showing the highest vendor price with a colored border. This was because I've continually made the mistake of getting into the habit of clicking "Continue" before changing the selection to an item I actually needed.

local highlight=QuestInfoItemHighlight:GetRegions();
local selectbutton=QuestInfoItem_OnClick;
hooksecurefunc("QuestInfoItem_OnClick",function(self) highlight:SetVertexColor(1,1,1); end);
QuestFrame:HookScript("OnEvent",function(self,event,...)
    if event=="QUEST_COMPLETE" or event=="QUEST_ITEM_UPDATE" then
        local numchoices=GetNumQuestChoices();
        local maxid,maxval=0,-1;
        for i=1,numchoices do
            local link=GetQuestItemLink("choice",i);
            if not link then return; end
 
            local price=select(11,GetItemInfo(link))*select(3,GetQuestItemInfo("choice",i));
            if price>maxval then
                maxid,maxval=i,price;
            end
        end
        if maxid>0 then
            selectbutton(_G["QuestInfoItem"..maxid]);
            highlight:SetVertexColor(0,1,0);
            QuestInfoFrame.itemChoice=0;--  Hack to deselect choice
        end
    end
end);

[fixitman333]

OneChoice or VendorBait, with RatingBuster already do what you're trying to do. They do it simply, with as little overhead as possible. No point reinventing the wheel (frame), when it serves the purpose just fine as-is.

[SDPhantom]

Originally Posted by fixitman333 They do it simply, with as little overhead as possible. No point reinventing the wheel (frame), when it serves the purpose just fine as-is.

Actually, there is a point. Some people might not the additional features of OneChoice and I could write even more efficient code than what's in VendorBait. Evolution in technology often involves improving an existing design.

For example of ways to make an addon even lighter.

• Least amount of UI objects created. (They take up memory too and cannot be garbage collected)
• Whenever possible, use what already exists in the environment you're working with.
• Less code (conditional checks, function calls, calculations, etc.) means less CPU time.

[humfras]

Originally Posted by SDPhantom Actually, there is a point. Some people might not the additional features of OneChoice and I could write even more efficient code than what's in VendorBait. Evolution in technology often involves improving an existing design. For example of ways to make an addon even lighter. Least amount of UI objects created. (They take up memory too and cannot be garbage collected) Whenever possible, use what already exists in the environment you're working with. Less code (conditional checks, function calls, calculations, etc.) means less CPU time.

"You take the lead!"

Grim077 should adapt your code to modify it to his needs.
(Isn't to hard to create a Texture with your Goldfish and place it to the correct quest reward.)

Give it a try, Grim077, and let use see your results

[tinyu]

http://www.wowinterface.com/download...QuestItem.html

this is what you want it can

a) you choose a item then complete the quest
b) you choose a item that you can use and click "complete and equip selected"
c) if you cant use or dont want anything it can auto choose highest valuce (as long as you havnt selected anything)

[Grim077]

Originally Posted by humfras "You take the lead!" Grim077 should adapt your code to modify it to his needs. (Isn't to hard to create a Texture with your Goldfish and place it to the correct quest reward.) Give it a try, Grim077, and let use see your results

^.^ but like i said i can't make it, So that's why I'm asking if anyone could make it for me, I wish i could do it myself but i can't

[Grim077]

Originally Posted by SDPhantom Actually, there is a point. Some people might not the additional features of OneChoice and I could write even more efficient code than what's in VendorBait. Evolution in technology often involves improving an existing design. For example of ways to make an addon even lighter. Least amount of UI objects created. (They take up memory too and cannot be garbage collected) Whenever possible, use what already exists in the environment you're working with. Less code (conditional checks, function calls, calculations, etc.) means less CPU time.

If you would be willing to do it, I would very much appreciate it.

[fixitman333]

Originally Posted by SDPhantom Actually, there is a point. Some people might not the additional features of OneChoice and I could write even more efficient code than what's in VendorBait. Evolution in technology often involves improving an existing design. For example of ways to make an addon even lighter. Least amount of UI objects created. (They take up memory too and cannot be garbage collected) Whenever possible, use what already exists in the environment you're working with. Less code (conditional checks, function calls, calculations, etc.) means less CPU time.

The OP is looking for someone to write an addon with very specific needs in mind. All these needs are already taken care of with other addons. I simply made this point clear. No-one has actually taken the time to write a new addon, and the OP could already have what was asked for with a few clicks. I don't see where Grim077 requested more efficient code, do you?

C'mon, at least read the original post before replying.....

[tinyu]

Originally Posted by tinyu http://www.wowinterface.com/download...QuestItem.html this is what you want it can a) you choose a item then complete the quest b) you choose a item that you can use and click "complete and equip selected" c) if you cant use or dont want anything it can auto choose highest valuce (as long as you havnt selected anything)

this mod can do what he wants.

[Grim077]

Originally Posted by SDPhantom This is code that I wrote for this exact purpose. I changed it from actually selecting the item to showing the highest vendor price with a colored border. This was because I've continually made the mistake of getting into the habit of clicking "Continue" before changing the selection to an item I actually needed. local highlight=QuestInfoItemHighlight:GetRegions(); local selectbutton=QuestInfoItem_OnClick; hooksecurefunc("QuestInfoItem_OnClick",function(self) highlight:SetVertexColor(1,1,1); end); QuestFrame:HookScript("OnEvent",function(self,event,...)     if event=="QUEST_COMPLETE" or event=="QUEST_ITEM_UPDATE" then         local numchoices=GetNumQuestChoices();         local maxid,maxval=0,-1;         for i=1,numchoices do             local link=GetQuestItemLink("choice",i);             if not link then return; end               local price=select(11,GetItemInfo(link))*select(3,GetQuestItemInfo("choice",i));             if price>maxval then                 maxid,maxval=i,price;             end         end         if maxid>0 then             selectbutton(_G["QuestInfoItem"..maxid]);             highlight:SetVertexColor(0,1,0);             QuestInfoFrame.itemChoice=0;--  Hack to deselect choice         end     end end);

This works perfectly for what i want thanks, but is there anyway you could make it also tell you theres an item that you may be able to use.

[SDPhantom]

Originally Posted by Grim077 This works perfectly for what i want thanks, but is there anyway you could make it also tell you theres an item that you may be able to use.

I'm not sure if this is already done by the default UI or if it's Altoholic doing it, but the unusable items on my client are tinted red on the QuestFrame. I can look into a way of adapting my code to do this too while keeping the resource usage to the bare minimum.

Edit: The default UI is tinting the item icon for quest rewards. I tested it with all addons disabled.

[brotherhobbes]

Originally Posted by SDPhantom Edit: The default UI is tinting the item icon for quest rewards. I tested it with all addons disabled.

The default UI tints items that you can not equip as red. If you play as a plate class, many times nothing will be tinted red.

[SDPhantom]

You technically can use cloth/leather/mail items on a plate-wearer, you'll be laughed out of groups for it, but for example, it's still viable for a holy paladin to use non-plate healer gear in earlier levels, and that's where most of your questing is.

[SDPhantom]

Here's some code I'm posting separately since it spans past the realm of just quest rewards. This will change the color of any item still usable, but differs from the preferred armor type of your character to a blue tint. This doesn't look at stats, just whether it's cloth/leather/mail/plate and compares it to what type you should be wearing for your class.

Combined with what the default UI already does, this means red-tinted items are unusable while blue-tinted items are still usable, but not the best type to do so. This affects mail attachments, vendors, quest info, and trade windows, the same areas the default UI handles.

local UpdateItemButtonUsableColor; do
    local ItemClassLookup={GetAuctionItemClasses()}; for i,j in ipairs(ItemClassLookup) do
        local sub={[0]=i,GetAuctionItemSubClasses(i)};
        ItemClassLookup[j]=sub;
        for k,l in ipairs(sub) do sub[l]=k; end
    end
 
    local EquipLocations={
        INVTYPE_HEAD        =true;
        INVTYPE_SHOULDER    =true;
        INVTYPE_CHEST       =true;
        INVTYPE_ROBE        =true;
        INVTYPE_WAIST       =true;
        INVTYPE_LEGS        =true;
        INVTYPE_FEET        =true;
        INVTYPE_WRIST       =true;
        INVTYPE_HAND        =true;
    }
 
    local ArmorPreferenceData={
        CLOTH       ={2,2};
        LEATHER     ={3,3};
        LEATHER_MAIL    ={3,4};
        MAIL_PLATE  ={4,5};
        PLATE       ={5,5};
    }
    local ClassArmorPreference={
--      Cloth
        MAGE        =ArmorPreferenceData.CLOTH;
        PRIEST      =ArmorPreferenceData.CLOTH;
        WARLOCK     =ArmorPreferenceData.CLOTH;
 
--      Leather
        DRUID       =ArmorPreferenceData.LEATHER;
        ROGUE       =ArmorPreferenceData.LEATHER;
 
--      Leather/Mail
        HUNTER      =ArmorPreferenceData.LEATHER_MAIL;
        SHAMAN      =ArmorPreferenceData.LEATHER_MAIL;
 
--      Mail/Plate
        WARRIOR     =ArmorPreferenceData.MAIL_PLATE;
        PALADIN     =ArmorPreferenceData.MAIL_PLATE;
 
--      Plate
        DEATHKNIGHT =ArmorPreferenceData.PLATE;
    };
 
    local PlayerClass;
    UpdateItemButtonUsableColor=function(btn,item,flag)
        if not PlayerClass then PlayerClass=select(2,UnitClass("player")); end
        if not item then return; end
 
        local lvlid=(UnitLevel("player")<40 and 1 or 2);
        local class,sub,_,loc=select(6,GetItemInfo(item));
        local classdata=ItemClassLookup[class];
 
        if  EquipLocations[loc]
        and classdata[sub]>1 and classdata[sub]<6
        and sub~=classdata[ClassArmorPreference[PlayerClass][lvlid]]
        then
            local int=1;
            if bit.band(flag,16)>0 then int=0.5; end
 
            if bit.band(flag,1)>0 then SetItemButtonTextureVertexColor(btn,0,0,int); end
            if bit.band(flag,2)>0 then SetItemButtonNameFrameVertexColor(btn,0,0,int); end
            if bit.band(flag,4)>0 then SetItemButtonSlotVertexColor(btn,0,0,int); end
            if bit.band(flag,8)>0 then SetItemButtonNormalTextureVertexColor(btn,0,0,int); end
        end
    end;
end
 
hooksecurefunc("OpenMailFrame_UpdateButtonPositions",function()
    for i=1,ATTACHMENTS_MAX_RECEIVE do
        if select(5,GetInboxItem(InboxFrame.openMailID,i)) then
            UpdateItemButtonUsableColor(_G["OpenMailAttachmentButton"..i],GetInboxItemLink(InboxFrame.openMailID,i),1);
        end
    end
end);
 
hooksecurefunc("MerchantFrame_UpdateMerchantInfo",function()
    local numitems=GetMerchantNumItems();
    for i=1,MERCHANT_ITEMS_PER_PAGE do
        local id=((MerchantFrame.page-1)*MERCHANT_ITEMS_PER_PAGE)+i;
        if id>numitems then break; end
 
        local name,_,_,_,avail,usable=GetMerchantItemInfo(id);
        if name and usable then--   usable may return true even when it's not an item
            local mercbtn=_G["MerchantItem"..i];
            local itembtn=_G["MerchantItem"..i.."ItemButton"];
            local link=GetMerchantItemLink(id);
 
            if avail==0 then--  -1 is infinite
                UpdateItemButtonUsableColor(mercbtn,link,22);
                UpdateItemButtonUsableColor(itembtn,link,25);
            else
                UpdateItemButtonUsableColor(mercbtn,link,6);
                UpdateItemButtonUsableColor(itembtn,link,9);
            end
        end
    end
end);
 
hooksecurefunc("QuestInfo_ShowRewards",function()
    local isquestlog=QuestInfoFrame.questLog;
    local numchoice=(isquestlog and GetNumQuestLogChoices() or GetNumQuestChoices());
    local numreward=(isquestlog and GetNumQuestLogRewards() or GetNumQuestRewards());
 
    for i=1,numchoice do
        if select(5,_G[isquestlog and "GetQuestLogChoiceInfo" or "GetQuestItemInfo"](isquestlog and i or "choice",i)) then
            UpdateItemButtonUsableColor(
                _G["QuestInfoItem"..i]
                ,_G[isquestlog and "GetQuestLogItemLink" or "GetQuestItemLink"]("choice",i)
                ,3
            );
        end
    end
 
    for i=1,numreward do
        if select(5,_G[isquestlog and "GetQuestLogRewardInfo" or "GetQuestItemInfo"](isquestlog and i or "reward",i)) then
            UpdateItemButtonUsableColor(
                _G["QuestInfoItem"..(numchoice+i)]
                ,_G[isquestlog and "GetQuestLogItemLink" or "GetQuestItemLink"]("reward",i)
                ,3
            );
        end
    end
end);
QUEST_TEMPLATE_DETAIL2.elements[13]=QuestInfo_ShowRewards;
QUEST_TEMPLATE_LOG.elements[28]=QuestInfo_ShowRewards;
QUEST_TEMPLATE_REWARD.elements[7]=QuestInfo_ShowRewards;
QUEST_TEMPLATE_MAP2.elements[1]=QuestInfo_ShowRewards;
 
hooksecurefunc("TradeFrame_UpdateTargetItem",function(id)
    if select(5,GetTradeTargetItemInfo(id)) then
        local link=GetTradeTargetItemLink(id);
        UpdateItemButtonUsableColor(_G["TradeRecipientItem"..id.."ItemButton"],link,1);
        UpdateItemButtonUsableColor(_G["TradeRecipientItem"..id],link,6);
    end
end);

Edit1: Fixed problems with random items like cloaks misreading as cloth armor. Now checks on equip location too before deciding whether to tint the item.
Edit2: Fixed an error with the QuestFrame sometimes not having the items ready when calling the QuestInfo_ShowRewards() function.