Need some help on Aura filtering...

[Mischback]

Hey guys,
I think I need some advise here...

I'm currently rewriting my oUF-layout to 1.4 and it's nearly done. The last thing ****ing it up are the auras.

I had it set up (pre 1.4) like this:
Every toon has it's own SavedVars file, which contains an array (table) with spellIDs. If there is an aura with a spellID from the table, the aura is shown, if not, it's not displayed (simpe whitelisting).

Now (1.4) the filter stuff is just not working and I can't figure out why. I set up a custom filter in my layout with self.Buffs.CustomFilter = core.FilterBuffs.

This is the filter-function (basically the start of the filter-process, since I'm generalizing the functions to provide white- and blacklisting.
settings.options.friendsBuffs and settings.options.friendsDebuffs are the loaded SavedVars-tables described above.

	--[[ Filter buffs
		BOOL FilterBuffs(..., INT spellID)
	]]
	core.FilterBuffs = function(icons, unit, icon, name, rank, texture, count, dtype, duration, timeLeft, caster, isStealable, shouldConsolidate, spellID)
		if ( UnitIsFriend(unit, 'player') ) then
			return lib.FilterGeneric(spellID, settings.options.friendsBuffs)
		else
			return lib.FilterGeneric(spellID, settings.options.enemyBuffs)
		end
	end

This is the generic filter function which makes the distinction between black- and whitelisting.

	--[[ Generic filter-function (distinction between blacklist and whitelist)
		BOOL FilterGeneric(INT spellID, TABLE filterSRC)
	]]
	lib.FilterGeneric = function(spellID, filterSRC)
		if (mode == 'blacklist') then
			return lib.FilterBlacklist(spellID, filterSRC)
		else
			return lib.FilterWhitelist(spellID, filterSRC)
		end
	end

This is the blacklisting-function. Whitelisting is similar, BOOLs switched, obviously. lib.in_array() is working correctly, too. It's a very slim table lookup.

	lib.FilterBlacklist = function(spellID, list)
		if ( #list ~= 0 ) then
			if ( lib.in_array(spellID, list) ) then
				return false
			end
		end
		return true
	end

So, my problem is: Every of this function is working correctly, as far as I can tell from debugging. in oUFs aura.lua my CustomFilter-function is called (in updateIcon() ) and after the functions are processed, it returns true or false.
In updateIcon() everything seems to work correctly, since it jumps to the correct parts, depending on show. But my buffs/debuffs won't show up.

If I deactivate my CustomFilter, the auras show up in the right placed, obviously without any filtering.

Can someone pls have a look on this... I'm clueless.

[yj589794]

There is a bug in oUF 1.4 at the moment, but Haste will not be able to fix it until August.


See here: http://www.wowinterface.com/portal.p...bug&bugid=6664

[Mischback]

Thank you for pointing me in the right direction, yj589794.

In fact, it is a weakness in oUF aura.lua.

I found a nasty hack, which is working for me, but sorry, I can't really say, if it has any side-effects on your layouts. Anyway, and of course, it may help Haste, here's the fix:

In the (original) function filterIcons(), "unneeded" icons are hidden. I estimate, this is done, to hide those short auras, which have expired.
But since the icons are not ordered in the icons-table, you can not simply hide them by their index.

My fix works like this: I hide all icons, before the function updateIcon() is called, because inside of updateIcon(), there are calls to hide/show the icon anyway.

This may have some performance issues, I'm sure Haste can provide a better solution, but till august it'll do the trick.

Simply replace the WHOLE filterIcons() with this one:

local filterIcons = function(unit, icons, filter, limit, isDebuff, offset, dontHide)
	if(not dontHide) then		-- FIX
		for i = 1, #icons do	-- FIX
			icons[i]:Hide()		-- FIX
		end						-- FIX
	end							-- FIX
	if(not offset) then offset = 0 end
	local index = 1
	local visible = 0
	while(visible < limit) do
		local result = updateIcon(unit, icons, index, offset, filter, isDebuff)
		if(not result) then
			break
		elseif(result == VISIBLE) then
			visible = visible + 1
		end
		index = index + 1
	end
	-- if(not dontHide) then
		-- for i = offset + visible + 1, #icons do
			-- icons[i]:Hide()
		-- end
	-- end
	return visible
end

[Dawn]

The problem with that "fix" is, that it doesn't work for auras. It works for the debuff part of them, but entirely removes the buffs.

It kinda works if you only use debuffs and/or buffs, though.

[Mischback]

Quite funny, I'm just messing around with it today...
The fix was put together, when I don't use auras, but buffs and debuffs.

I will look into it again, perhaps I can find something working for all three possibilities.

k, this sucks...
Problem with my so called "fix" is, that everytime the update()-function is called, all icons are hidden. Then there is a conflict in SetPosition() and the icons are NOT set into position. Damn.

As you already mentioned, it works quite well, if you work with self.Buffs and self.Debuffs, but not with self.Auras. I think I'll stick for the moment with my fix for my UF and will delay my other project until August.

[Dawn]

Nevermind, it's just very unlucky that haste is gone for so long, shortly after pushing 1.4 out to the public.

[haste]

I'll point someone to this thread. There are a couple of people I've asked to do minor bug fixes while I'm on vacation. One of them might have some time to spend on this.

[Mischback]

That would be awesome, thank you very much haste!