Cant get a button click to execute a macro

jeroenvo · 04-03-23, 01:20 AM

Hello!

Im new to wow lua scripting and trying to make a addon that executes a macro text on a button click. When i bind a macrotext to a button (/sit as a example) nothing happens when i click it.

I found this example somewhere online:

Code:

local frame = CreateFrame("Frame", "Test", UIParent, "SecureHandlerStateTemplate")
frame:SetSize(40, 40)
frame:SetPoint("TOPLEFT", UIParent, 10, -150)
 
local button = CreateFrame("Button", "TestBtn", frame, "SecureActionButtonTemplate")
button:ClearAllPoints()
button:SetSize(32, 32)
button:SetPoint("CENTER", frame)

local texture = button:CreateTexture("$parent_tex", "BACKGROUND")
texture:SetAllPoints(true)
texture:SetTexture(GetSpellTexture(783))
button.texture = texture
 
button:RegisterForClicks("LeftButtonUp", "RightButtonUp")
button:SetMouseClickEnabled(true)
button:SetAttribute("type1", "macro")
button:SetAttribute("macrotext", "/sit")
 
button:SetScript("PostClick", function(self, arg1)
    print("POSTCLICK: Clicked button=", self:GetName(), "  macroTxt=", self:GetAttribute("macrotext"))
end)

The PostClick function gets called but the /sit is not being executed. Does someone knows what the issue is?

Fizzlemizz · 04-03-23, 11:32 AM

It should be executing /sit on leftbutton, but not rightbutton

Lua Code:

local frame = CreateFrame("Frame", "Test", UIParent, "SecureHandlerStateTemplate")
frame:SetSize(40, 40)
frame:SetPoint("TOPLEFT", UIParent, 10, -150)
 
local button = CreateFrame("Button", "TestBtn", frame, "SecureActionButtonTemplate")
button:ClearAllPoints()
button:SetSize(32, 32)
button:SetPoint("CENTER", frame)
 
local texture = button:CreateTexture("$parent_tex", "BACKGROUND")
texture:SetAllPoints(true)
texture:SetTexture(GetSpellTexture(783))
button.texture = texture
 
button:RegisterForClicks("LeftButtonUp", "RightButtonUp")
button:SetAttribute("type1", "macro")
button:SetAttribute("type2", "macro")
button:SetAttribute("macrotext", "/sit")
 
button:SetScript("PostClick", function(self, arg1)
    print("POSTCLICK: Clicked button=", self:GetName(), arg1, "  macroTxt=", self:GetAttribute("macrotext"))
end)

Added

Code:

button:SetAttribute("type2", "macro")

for rightbutton.

For information on click attributes (Modified attributes) see

jeroenvo · 04-03-23, 01:08 PM

Thanks for your reply! The macro is still not being executed. Also tried to disable all my other addons.

Fizzlemizz · 04-03-23, 01:29 PM

You probably have the ActionButtonUseKeyDown CVar set to 1.

Register the button to use Down clicks instead of Up or,

run

Code:

/console ActionButtonUseKeyDown 0

and try again.

jeroenvo · 04-04-23, 12:56 AM

Originally Posted by Fizzlemizz

You probably have the ActionButtonUseKeyDown CVar set to 1.

Register the button to use Down clicks instead of Up or,

run

Code:

/console ActionButtonUseKeyDown 0

and try again.

The command didn't work. The PostClick function is called. It prints the string in chat but the macro is not executed

Fizzlemizz · 04-04-23, 09:08 AM

The code as posted (with the CVar in sync. with the registered clicks) works here on retail.

jeroenvo · 04-05-23, 04:00 AM

Added SetCVar("ActionButtonUseKeyDown", 0) as first line of the script and now it works. Thanks for your help!