Quantcast Fixing an old Addon for 6.x - WoWInterface
 
Thread Tools Display Modes
09-04-14, 04:34 AM   #1
Tntdruid
Premium Member
 
Tntdruid's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Jan 2005
Posts: 54
Fixing an old Addon for 6.x

This is when testing on WoD Beta


Message: Interface\AddOns\TurnIn\TurnIn.lua:335: attempt to call global 'QuestInfoFadingFrame_OnUpdate' (a nil value)
Time: 09/04/14 12:27:20
Count: 1
Stack: Interface\AddOns\TurnIn\TurnIn.lua:335: in function `TI_HandleAcceptQuest'
Interface\AddOns\TurnIn\TurnIn.lua:320: in function <Interface\AddOns\TurnIn\TurnIn.lua:264>


Locals: (*temporary) = nil
(*temporary) = nil
(*temporary) = 1
(*temporary) = "attempt to call global 'QuestInfoFadingFrame_OnUpdate' (a nil value)"


335 is


function TI_HandleAcceptQuest()
QuestInfoFadingFrame_OnUpdate(QuestInfoFadingFrame, 1);
QuestDetailAcceptButton_OnClick();
end



Any way to fix that? been looking on http://www.wowwiki.com/Api no luck, i'm new to wow coding


The addon is abandoned, i hope i can fix it, was 1 of my fav addons
 
09-04-14, 05:04 AM   #2
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
The quest tracker has changed quite a bit in WoD. I'm not familiar with the addon you're using, and you didn't provide a link, but based on what little detail you did provide, it looks like an "auto turn in quests" addon -- have you considered switching to a more modern addon that's actively maintained? There are plenty to choose from, eg. QuickQuest.
__________________
Author/maintainer of Grid, PhanxChat, oUF_Phanx, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
 
09-04-14, 05:08 AM   #3
Tntdruid
Premium Member
 
Tntdruid's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Jan 2005
Posts: 54
Link http://wow.curseforge.com/addons/turn-in/

I was gonna use the addon to learn some lua whit
 
09-04-14, 08:49 PM   #4
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
Well, based on the code you posted, that addon is not using very good coding practices, so I would strongly recommend against using it as a learning tool. It also appears to using rather circuitous methods to automate quests, by maniuplating the default UI's frames to replicate exactly what happens when you interact with those frames yourself, rather than doing what an addon should be doing, which is just calling the underlying API methods directly.

It's like designing a machine to cook ramen for you, but instead of just making something like you'd probably imagine -- a self-contained unit, kind of like a rice cooker maybe -- you instead make an android that can do all the things you'd do yourself to cook the ramen for you in a pot on the stovetop. Obviously this is inefficient and will break if you change anything about your kitchen setup. Much easier just to make a self-contained unit you can just hook up to a water line, then drop in a packet of ramen and push a button, so it doesn't need to know what your pots look like, how to use your stove controls, how to open your cupboards, etc.

If you want to use a quest-automating addon to learn about writing WoW addons, I'd suggest looking at the one I linked earlier, as it's author is actually using the API correctly and the addon is written in a sensible way in accordance with current best practices.
__________________
Author/maintainer of Grid, PhanxChat, oUF_Phanx, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
 
09-04-14, 11:33 PM   #5
Tntdruid
Premium Member
 
Tntdruid's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Jan 2005
Posts: 54
Thanks for the tip, i'm not gonna use this that old addon
 
 

WoWInterface » Site Forums » Archived Beta Forums » WoD Beta archived threads » Fixing an old Addon for 6.x

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off