Weird tag behaviour is freaking me out

[drakull]

Hey, hope you guys can help me out with this one!

Im trying to create some tags to display my faction standings in my oUF layout but some of them are giving me a headache.

oUF.Tags['drk:currep']  = function(unit)
    local _, _, cur, _, total = GetWatchedFactionInfo()
    if cur and total then
        return total-cur
    end
end
oUF.TagEvents['drk:currep'] = 'UPDATE_FACTION'
 
oUF.Tags['drk:maxrep']  = function(unit)
    local _, _, cur, max = GetWatchedFactionInfo()
    if cur and max then
        return max-cur
    end
end
oUF.TagEvents['drk:maxrep'] = 'UPDATE_FACTION'

This 2 tags sometimes return nil even if i have a watched faction. One simple way to reproduce the error is to chose a faction and then check the "show as experience bar" box... The tags will correctly return the min and max standings for the selected faction... Now try unchecking and checking the same box back again... both tags returns nil.
This only happens when u uncheck/check the same faction. If I uncheck one faction and then check another one the tags return correct values.

The funny thing is that this bug does not happens to the following tag:

oUF.Tags['drk:repstanding']  = function(unit)
    local _, standing = GetWatchedFactionInfo()
    if standing then
        return "(".._G["FACTION_STANDING_LABEL"..standing]..")"
    end
end
oUF.TagEvents['drk:repstanding'] = 'UPDATE_FACTION'

It always return the expected value as long as there's a faction being watched.

Now for the freaking part: if you put this last tag together with one or both of the first (bugged) tags inside the same fontstring, the bug is gone and all tags always returns the expected value.

Please excuse my poor english.

[haste]

I'm unable to recreate this. All three tags behave as expected.

You might want to note that, GetWatchedFactionInfo(), returns: nil, 0, 0, 0, 0 when no faction is selected. This can make your drk:repstanding tag error out, as it tries to fetch FACTION_STANDING_LABEL0, which is a nil value. This might be creating the odd behavior for the two other tags.

So, make sure you have Lua errors turned on.

[drakull]

Yeah, thanks for pointing that out. I've corrected the code. But the problem is still there.

In fact, I created those tags hoping to solve the same problem i was having with ouf_reputation's default tags. I was getting the same nil and zero results from it's tags so i tried creating my own but with no luck.

I even tried disabling every single addon, leaving just ouf, ouf_drk and ouf_reputation but the problem persists.

Here's the code for the plugin:

-- oUF_Reputation
local addRepBar
do
    local PostUpdateRep = function(Reputation, unit, min, max)
        if GetWatchedFactionInfo() then
            local FACTION_BAR_COLORS = {
                [0] = {r = 1, g = 0.3, b = 0.22}, 
                [1] = {r = 0.8, g = 0.3, b = 0.22}, -- hated, dark red
                [2] = {r = 1, g = 0, b = 0},        -- hostile, bright red
                [3] = {r = 1, g = 0.5, b = 0},      -- unfriendly, orange
                [4] = {r = 0.9, g = 0.7, b = 0},    -- neutral, yellow
                [5] = {r = 0, g = 0.6, b = 0.1},    -- friendly, dark green
                [6] = {r = 0, g = 1, b = 0},        -- honored, bright green
                [7] = {r = 0.25, g = 0.4, b = 0.9}, -- reverted, blue
                [8] = {r = 0.6, g = 0.2, b = 0.8},  -- exalted, purple
            }
            local _, id = GetWatchedFactionInfo()
            local r, g, b
            local multiplier = 0.3
            
            r = FACTION_BAR_COLORS[id].r;
            g = FACTION_BAR_COLORS[id].g;
            b = FACTION_BAR_COLORS[id].b;
            
            Reputation:SetStatusBarColor(r, g, b)
            Reputation.bg:SetVertexColor(r * multiplier, g * multiplier, b * multiplier)
        end
    end
 
    lib.addRepBar = function(self)
        if IsAddOnLoaded("oUF_Reputation") then
            -- Rep bar
            local rep = CreateFrame("StatusBar", nil, self)
            rep:SetStatusBarTexture(cfg.statusBarTexture)
            rep:SetHeight(4)
            rep:SetWidth(250)
            rep:SetFrameLevel(1)
            rep:SetPoint("BOTTOMLEFT", self,"TOPLEFT", 0, 8)
            
            local repBG = rep:CreateTexture(nil, "BACKGROUND")
            repBG:SetTexture(cfg.statusBarTexture)
            repBG:SetAllPoints(rep)
            rep.bg = repBG
            
            -- Text display
            local repName= setFont(rep, cfg.smallfont, 13, "OUTLINE", 0)
            repName:SetPoint("LEFT", 0, 5)
            repName:SetPoint("RIGHT", rep, "RIGHT", 0, 5)
            repName:SetJustifyH("CENTER")
            self:Tag(repName, "[drk:currep]/[drk:maxrep] [drk:repstanding] - [reputation]")
            
            createBGFrame(rep, 0)
            
            self.Reputation = rep
            self.Reputation.PostUpdate = PostUpdateRep
        end
    end
end

The bar itself always shows the right ammount of rep and the right color, the problem is just the tags, no matter if i use the plugin's default tags or mine.

[drakull]

Any toughts?

[haste]

I haven't had any time to do more testing, but the two first tags (min/max) was working fine when I tested, as was the last one when fixed to not throw errors.

[drakull]

It must be something I'm doing in my layout. I've rewrited most of the code and now I have noticed this and some other strange behaviours. oUF_DebuffHightlight is also acting weird, wrong colors are being applied to it's frame. And oUF_Experience's rested bar completely fills the bar even if I don't have any rested XP.

Even the built in runebar element sometimes displays permanent death runes, they persist even long time after I leave combat.