UnitCreatureFamily and Warlocks?

[flaicher]

I used this as a trigger in WeakAuras.

function()
    local _, autocast = GetSpellAutocast(134477)
    local petclass = UnitCreatureFamily("pet")
    if (not autocast) and petclass == "Felguard" then
        return true
    end
end

It worked like a charm. Now I replaced petclass == "Felguard" with (petclass == "Wrathguard" or "Felguard") as I got Grimoire of Supremancy talent and it's going whacko.

EDIT: (petclass == ("Wrathguard" or "Felguard")) fixed the problem.. but now I can't figure out what is the CreatureFamily of Voidlord. It certainly isn't Voidlord, nor Voidwalker..

[Tim]

Easy way to figure that stuff out is to summon the void lord and do this:

/run print(UnitCreatureFamily("pet"))

[SDPhantom]

Originally Posted by flaicher EDIT: (petclass == ("Wrathguard" or "Felguard")) fixed the problem

Actually, this doesn't work the way you think it does. The original line evaluated petclass == "Wrathguard" first and if that was false, it evaluated "Felguard", which anything that isn't strictly nil or false evaluates to true. This eventually made the condition to always evaluate to true no matter what happened.

Your edit evaluates "Wrathguard" or "Felguard" first because of the parenthesis. Both are true conditions, but because of how or operates, it returns the first operand if it's a true condition. This makes the line always try to evaluate petclass == "Wrathguard". Which isn't covering the Felguard condition.

To have the condition return correctly, you need to make the change highlighted below.

function()
	local _, autocast = GetSpellAutocast(134477)
	local petclass = UnitCreatureFamily("pet")
	if (not autocast) and (petclass == "Felguard" or petclass == "Wrathguard") then
		return true
	end
end

[flaicher]

EDIT: I didn't refresh the page before posting this, so I missed SDPhantom's post.
Your advice fixed the problem I had with Voidwalker/Voidlord as well. I fixed Felguard/Wrathguard functions too.


It does claim that voidlord's creature family is "Voidlord"..
WeakAuras does recognize that I have a pet alive when a voidlord is summoned buuuuut this simple function doesn't return "true".

function()
    local petclass = UnitCreatureFamily("pet")
    if (petclass == ("Voidwalker" or "Voidlord")) then
        return true
    end
end

Nor does it recognize if I try to check for autocast states with voidlord summoned. Works just fine for voidwalker, felguard and wrathguard. I guess I'll have to bug WeakAuras author?